klausc/commutativerings.jl

CAS, Commutative Rings, Fraction Fields, Quotient Rings, Polynomial Rings, Galois Fields

commutativerings.jl's Issues

register 0.3.1

@JuliaRegistrator register

register v0.3.0

@JuliaRegistrator register v0.3.0

Bug in factorization of non-monic univ polynomial

The following test case is broken:

    P = ZZ{BigInt}[:x]
    x = monom(P)
    p = 2x^3 + 7x^2 + x + 1
    @test factor(p)[1][1] == p
    @test factor(p, 30)[1][1] == p(x^30)
    @test_broken factor(p, 40)[1][1] == p(x^40)

Needs investigation (error in algorithm or in implementation?)

`oneunit(ZZmod{5, Int8}) \ y::Bool` not defined

In a nanosoldier run for JuliaLang/julia#43972, I came across this issue: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/a95ca94_vs_811e534/CommutativeRings.primary.log. That PR tries to make triangular matrices be able to handle unitful eltypes. When solving unittriangular systems, I need to divide by the oneunit of the matrix's eltype, which is where this packages failed in the nanosoldier run. What do you think would be a good solution here. I'm surprised that the zzmod numbers are not subtypes of Number, since then promotion should work out of the box. Instead, it tries to compute oneunit(ZZmod{5, Int8}) \ y::Bool via y / adjoint(oneunit(ZZmod{5, Int8})). One solution could then be to define

Base.adjoint(a::ZZmod) = a

?

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Documentation

Move documentation to new doc pages and minimize README.md

register 0.6.0

@JuliaRegistrator register
v0.6.0

Release notes:

added lucas for Lucas Numbers and extended fibonnacci to all integers.

register v0.2.0

@JuliaRegistrator register
v0.2.0

Registration

@JuliaRegistrator register

Improve Test Coverage

Update Polynomials dependency

All tests passed for Polynomials 2.0.22

register 0.4.0

@JuliaRegistrator register v0.4.0

Factorization of univariate polynomials over integers

This functionality should be added.