icons in general need a sane default

[keshto]

icons in general need a sane default

[LBCrion]

Zoom icon cropping is a bug - this should be fixed now.
Let me think about the best way to implement default icon sizes.

[keshto]

You are on fire! Will test and report back. Thanks!

…

On March 23, 2023 10:28:02 PM UTC, LBCrion ***@***.***> wrote: Zoom icon cropping is a bug - this should be fixed now. Let me think about the best way to implement default icon sizes. -- Reply to this email directly or view it on GitHub: #79 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[keshto]

It would be nice if the v/hexpand or Min(height, width) of parent would work for images that would be a good default

[keshto]

Changes look like they broke more than they fixed. nm-applet is weird size it used to be same as others. zoom is same

EDIT: this is how it looks without the last 2 commits

[LBCrion]

Ok, let's try this again. Would you mind testing the latest git version when you get a chance?

[keshto]

latest change fixes the clipping. Thanks!
We should probably keep this open until you decide what to do about sane defaults.

[LBCrion]

I added 16x16px default to the code. If min-wdith / min-height are set to zero, they will default to 16px, otherwise specified number will be used.

[keshto]

I will test and report back shortly

…

On March 25, 2023 3:44:24 PM UTC, LBCrion ***@***.***> wrote: I added 16x16px default to the code. If min-wdith / min-height are set to zero, they will default to 16px, otherwise specified number will be used. -- Reply to this email directly or view it on GitHub: #79 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[keshto]

World of a difference! now if someone does not stylize their icons they can still see them as opposed to before where they were tiny and in some cases invisible. Great job!