pe's People
pe's Issues
Add command is too long and restrictive
Description
The add
command is too long and restrictive. It enforces the presence of every single field which might prove to be too restrictive as there might be scenarios where a user might not want to enter all the fields and want to quickly enter a user into the application. As an application optimised for CLI, the commands should be easy to type. The long command with many different prefixes to remember might prove to be a feature flaw as it is not truly optimised for CLI users.
Reason for severity
Likely to affect a large portion of users at the very beginning when they first use the application. Severity decreases as users gets used to the application and uses it more.
Help window jumping around
Description Set the context.
Help window jumping around
Steps to reproduce
- Type the
help
command - Shift the help pop up anywhere
- Close the help pop up
- Type the
help
command again - The help window will jump around
I have attached a video recording of the replication
Expected behaviour
The help window should show up like the first time
Actual behaviour
The help window jumps to the bottom left corner before jumping to the the middle again
Reason for severity
Does not affect daily usage of users. Unlikely to occur alot after some level of use as the users should be familiar with the commands and
would not need to keep referring to help
.
video:https://raw.githubusercontent.com/lipwei1808/pe/main/files/785e67e3-2b7a-441b-87be-2f34fde3add7.mov
Inconsistent use of colour in diagrams
The diamond in the activity diagram is inaccurate
Unable to add benefit by the provided error response
Description
Upon entering an invalid command for benefit, there is an error response as attached. However using any of those options would lead to an invalid command still.
Expected behaviour
The command should be accepted as stated
Actual behaviour
The command is rejected
Reason for severity
This could affect a large amount of users as they try to add a benefit and would be stuck not knowing why their command is rejected
Unclear return value in sequence diagram
Nested diagrams which leads to diagram being overly cluttered
Large minimum view width
Description Set the context.
The minimum view width of the application is very high
Expected behaviour
The minimum view width of the application is almost 80% of my screen which is a 14 inch macbook. This could inconvenience users using a different platform with a smaller width. They might not be able to view the application fully.
Actual behaviour
There should be actions done to provide responsive display and allow for a smaller width.
Reason for severity
An issue that could affect a significant portion of users using computers with a smaller display. However it would not affect functionality but cause a minor inconvenience. However, as it could potentially cause users to constantly move around the display, the severity could increase to medium if the portion of users affected turns out to be higher
Weird use of index to select person
Description
Unclear use of selection index to choose Person
.
Steps to reproduce
Based on the original list, there was a person on index 4. As I want to view the payslip for the person at index 3 followed by the person at index 4
- Run the command
payslip 3
- Run the command
payslip 4
- An invalid index is shown
Expected behaviour
Step 2 results in an error of invalid index.
Actual behaviour
I should be able to view payslip of the person at index 4 on the original list
Reason for severity
There is not a clear documentation on how the index is used. It is intuitive for the user to wish to view payslips of multiple people successively. However, with the unclear use of index, there seems to be issues with this.
Ideas
This might be caused by the use of index in finding people from the filtered list already. If so, there should have been a clearer documentation to prompt users to reset the list with list
again before running any other commands
test
No details provided by bug reporter.
Incorrect use of ref frames in diagram
Invalid use of sequence diagram return arrow
Email validation is too strongly validated
Description
The email validation is too strongly validated which restricts user inputs.
Steps to reproduce
- Run the command
add /n Jane Smith /e Pelé@example.com /p 12345678 /a 123 Main St /b123456789 /jd 12/09/2023 /s 1000.00 /l 10
. - The input will be rejected as the email is not valid
Expected behaviour
The input is rejected by the application
Actual behaviour
The input should be valid.
Reason for severity
In accordance to RFC 6530, the email I provided should be valid. However, the email validation logic only allows for a much smaller restricted set of alphanumeric characters. This could prove to be an inconvenience to a significant chunk of users.
Unclear Model class diagram on filtered and all roles
Inaccurate call of nested function in sequence diagram
Leaves does not get recorded properly
Description Set the context.
Leaves does not get recorded properly
Steps to reproduce
- Add a few leaves by using
addleave
- Edit the
Person
leave to be lower - Add another leave.
- The previous leave entries are deleted
This issue can be replicated by closing the application after editing a Person
leave. Upon reopening the application, the leaves that were previously entered would be lost.
A video recording of this is attached
Expected behaviour
The leaves that were previously added should remain
Actual behaviour
The application deletes the leaves that were recorded prior to the edit
Reason for severity
This could affect many users as it is highly likely that leaves will be updated throughout the year and it is a huge inconvenience to re update all the previously added leaves.
Unable text on the Model class diagram
Duplicate detection with spaces in name
Description
Duplication detection is not optimised
Steps to reproduce
- Run
add /n Jane Smith /e [email protected] /p 12345678 /a 123 Main St /b 123456789 /jd 12/09/2023 /s 1000.00 /l 10
- Run
add /n Jane Smith /e [email protected] /p 12345678 /a 123 Main St /b 123456789 /jd 12/09/2023 /s 1000.00 /l 10
- Both commands will run successfully
Note the only difference in the 2 commands is the name field.
Expected behaviour
As the 2 people are most likely to the be the same person, the application should reject adding the 2nd command.
Actual behaviour
The application allows for 2 people with the same name but varying spaces within the name to be added.
Reason for severity
As the name field does trimming of whitespaces, there should be optimisation done to prevent duplicates through having spaces within the name as well. Since the name "Jane Smith" and "Jane Smith" are most likely the same person, there should be control done to prevent adding these 2 duplicate people with exactly the same fields.
Use of addressbook seems out of place
Text input unscrollable
Description
The text input is unscrollable
Steps to reproduce
I have attached a screenshot of the replication
Expected behaviour
The input box should be scrollable when the input text is longer than the width of the input box.
Actual behaviour
Input box is unscrollable.
Reason for severity
The input box being unscrollable would cause inconvenience to users that wishes to preview what they wrote and would like to edit.
Given that the first command to add
contains a command that already exceeds the input box width, it shows that this issue would be rather prevelant and affect a significant portion of users.
Inaccurate Parser class diagram
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.