mannrobo/in-the-zone-b

Code for Some Assembly Required's VRC "In The Zone" robot.

In The Zone Code

Version 2.0

Features

• LCD Library
  • Simple Helpers
  • Autonomous Routine Selection
  • UI Components:
    • Pick
    • Menu
    • Custom Debug Menu (with multiple, live, configurable screens)
• Motion Control:
  • Simple PID Library Functions
  • PID Integration into Hardware Abstraction Layer
  • Motion Profiling
• Smart Motors:
  • Slew Rate
  • Truespeed
  • Deadband
• Rerun:
  • Record Reruns
  • Integrate playback into autonomous and programming skills systems

🚀

in-the-zone-b's Issues

No Inheritence in Motor Classes

Refactor Motor Classes to take advantage of inheritence

Standardize Code Style: Class Accessors

Standardize it!

Incompatible type conversion: 'char (*)[12]' to 'char [16][12]'

lcd.cpp: In function 'void lcd::menu(char (*)[12], void (*)(int))':
lcd.cpp:99:28: error: incompatible types in assignment of 'char (*)[12]' to 'char [16][12]'

Despite the fact that the function is defined clearly, it is being interpreted differently

void menu(char options[16][12], void(*callback)(int choice));

void menu(char options[16][12] , void(*callback)(int choice)) {
        lcd::menuOptions = options;
        lcd::menuCallback = callback;
}

char menuOptions[16][12];

New Feature Bugs

The most recent commits have introduced the following bugs:

File "C:\Users\bmcgui7575\Documents\Robotics\itz-code\main.c" compiled on Nov 13 2017 15:39:09
**Error**:Undefined variable 'pids'. 'short' assumed.
**Error**:LValue for '[]' operator must be a pointer
**Error**:'[]' operator requires pointer value on left hand side [2].
**Error**:Variable 'pids' is subsequently duplicately defined.
**Error**:Duplicate variable declaration of 'pids'
**Error**:Variable 'pids' redefinition.
**Error**:Type mismatch with previous 'const' declaration for variable with same name
**Error**:Executable statements not valid in 'main' declaration block
**Error**:Unexpected '{' during parsing
**Error**:Not enough parameters specified. Call to 'pidActivate'. Parameter: 'long * ports' is 'None specified'.
**Info***:Include file 'C:\Users\bmcgui7575\Documents\Robotics\itz-code\config.c' has already been opened.
**Error**:Executable statements not valid in 'main' declaration block
**Info***:Include file 'C:\Users\bmcgui7575\Documents\Robotics\itz-code\lib\util.c' has already been opened.
**Info***:Include file 'C:\Users\bmcgui7575\Documents\Robotics\itz-code\config.c' has already been opened.
**Error**:')' missing. Ummatched left parenthesis '('
**Error**:Expected->')'. Found '['
**Error**:No body declared for procedure
**Error**:Expected->'}'. Found '['
**Error**:Unexpected '[' during parsing
**Error**:Unexpected ']' during parsing
**Error**:Unexpected ',' during parsing
**Error**:Missing ';' before ')'
**Error**:Unexpected ')' during parsing
**Error**:Duplicate definition for task 'main'.
*Warning*:Unreferenced function 'motorSet'
**Error**:Undefined variable 'ports'. 'short' assumed.
**Error**:Expected->'('. Found '['
**Error**:')' missing. Ummatched left parenthesis '('
**Error**:Expected->')'. Found '['
**Error**:Unexpected '[' during parsing
**Error**:Expected->';'. Found ']'
**Error**:Unexpected ']' during parsing
**Error**:Unexpected ')' during parsing
*Warning*:Substituting similar variable 'I' for 'i'. Check spelling and letter case.
**Error**:Missing ';' before ')'
*Warning*:Meaningless statement -- no code generated
*Warning*:Substituting similar variable 'I' for 'i'. Check spelling and letter case.
**Error**:LValue for '[]' operator must be a pointer
**Error**:'[]' operator requires pointer value on left hand side [2].
**Error**:'enable' is not a 'struct' element of struct reference 'pids[i]'
**Error**:Undefined variable 'auto'. 'short' assumed.
**Error**:Expected->';'. Found 'test'
**Error**:Executable statements not valid in 'main' declaration block
**Error**:Undefined variable 'test'. 'short' assumed.
*Warning*:Meaningless statement -- no code generated

Use camelCase for everything

Currently inconsistent, some things using underscores, others using camelCase. Inconsistency is bad

Update IME Sensor Type

Currently, the update function does not work with IMEs. This is due to the fact that updating an IME requires creating a pointer

Standardize Code Style: Top Comment

Top comments are inconsistent. Fix it.

Get rid of warnings

The following warnings are present at 580059c:

lcd.cpp: In function 'void lcdTask(void*)':
lcd.cpp:21:36: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
lcd.cpp:22:33: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
lcd.cpp:57:38: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

lcd.cpp: At global scope:
lcd.cpp:86:17: warning: 'void lcd::write(int, const char*)' defined but not used [-Wunused-function]
lcd.cpp:90:17: warning: 'void lcd::center(int, const char*)' defined but not used [-Wunused-function]

Get rid of them (preferably without adding the flags)

Transfer sensor to its own file

sensor.h already exists, transfer the Sensor class to it

Create header files for everything

Circular dependencies are leading to incompilation.
Create header files for all library files