Comments (4)
Changes I made to fix this issue:
diff --git a/src/species/clicker.js b/src/species/clicker.js
index 1ff294b..cf82a16 100644
--- a/src/species/clicker.js
+++ b/src/species/clicker.js
@@ -20,10 +20,10 @@ const getDefaultConfig = (randomizer) => {
const defaultPositionSelector = () => {
return [
randomizer.natural({
- max: document.documentElement.clientWidth - 1,
+ max: Math.max(0, document.documentElement.clientWidth - 1),
}),
randomizer.natural({
- max: document.documentElement.clientHeight - 1,
+ max: Math.max(0, document.documentElement.clientHeight - 1),
}),
];
};
diff --git a/src/species/scroller.js b/src/species/scroller.js
index 3bc0258..d6e4b80 100644
--- a/src/species/scroller.js
+++ b/src/species/scroller.js
@@ -21,10 +21,10 @@ const getDefaultConfig = (randomizer) => {
return [
randomizer.natural({
- max: documentWidth - documentElement.clientWidth,
+ max: Math.max(0, documentWidth - documentElement.clientWidth),
}),
randomizer.natural({
- max: documentHeight - documentElement.clientHeight,
+ max: Math.max(0, documentHeight - documentElement.clientHeight),
}),
];
};
diff --git a/src/species/toucher.js b/src/species/toucher.js
index 7f8d8b5..3a05530 100644
--- a/src/species/toucher.js
+++ b/src/species/toucher.js
@@ -17,10 +17,10 @@ const getDefaultConfig = (randomizer) => {
const defaultPositionSelector = () => {
return [
randomizer.natural({
- max: document.documentElement.clientWidth - 1,
+ max: Math.max(0, document.documentElement.clientWidth - 1),
}),
randomizer.natural({
- max: document.documentElement.clientHeight - 1,
+ max: Math.max(0, document.documentElement.clientHeight - 1),
}),
];
};
diff --git a/src/species/typer.js b/src/species/typer.js
index 852b569..1b59cfb 100644
--- a/src/species/typer.js
+++ b/src/species/typer.js
@@ -61,10 +61,10 @@ export default (userConfig) => (logger, randomizer) => {
const eventType = randomizer.pick(config.eventTypes);
const key = config.keyGenerator();
const posX = randomizer.natural({
- max: documentElement.clientWidth - 1,
+ max: Math.max(0, documentElement.clientWidth - 1),
});
const posY = randomizer.natural({
- max: documentElement.clientHeight - 1,
+ max: Math.max(0, documentElement.clientHeight - 1),
});
const targetElement = config.targetElement(posX, posY);
from gremlins.js.
Thanks for the report.
I agree with you fix, can you open a pull request ?
from gremlins.js.
Done in #160.
Thanks
from gremlins.js.
Deploy on npm, https://github.com/marmelab/gremlins.js/blob/master/CHANGELOG.md#210-2020-04-22
from gremlins.js.
Related Issues (20)
- Current project status HOT 4
- Example of bugs? HOT 3
- Roadmap to Gremlins.js 2.0 HOT 3
- Bug: Input with `type="number"` breaks gremlins HOT 3
- Bug: Gremlins won't execute in Cypress test HOT 2
- Incorrect params for `customGremlin` in README HOT 2
- Command line interface? HOT 2
- How to test a website? HOT 1
- Detailed logs HOT 3
- Using Within Playwright HOT 3
- the newly opened windows also be monkey tested
- Unable to capture the result /log HOT 1
- Bug: gremlins is not defined in some page HOT 2
- Add support for right click (or in general other buttons) HOT 1
- Interactions not completely deterministic despite seeding the randomizer HOT 4
- Bug: gremlins.js aborts too early.
- Running gremlins.js on a webview
- Is there an example of successfully finding a bug or error? HOT 1
- Bug:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gremlins.js.