Giter Site home page Giter Site logo

query args order about maggma HOT 4 CLOSED

materialsproject avatar materialsproject commented on July 3, 2024 2
query args order

from maggma.

Comments (4)

shyamd avatar shyamd commented on July 3, 2024

I'm fine with it. I definitely templated on QueryEngine and had no logical reason for the order. I personally try and use named args whenever I use it so that it doesn't matter.

from maggma.

montoyjh avatar montoyjh commented on July 3, 2024

Cool, I'll submit a PR soon.

from maggma.

dwinston avatar dwinston commented on July 3, 2024

Great. I think we should switch. I personally use named args every time only because I want to put criteria first. :) I might get time for this after pre-workshop stuff, but if anyone wants to tackle this with a PR, self-assign this issue. I'll de-assign @shyamd now.

from maggma.

dwinston avatar dwinston commented on July 3, 2024

well played, @montoyjh... I should have refreshed the page before submitting that comment. :)

from maggma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.