Ensure indices seems to fail silently with read_only credentials

[materialsproject]

Ensure indices seems to fail silently with read_only credentials

[shyamd]

So there is a true/false return with the intention that if it can't ensure the index it will just return false.

Is there another situation that might not fit in this paradigm?

[mkhorton]

well, yes, I wasn't checking the return types :) I just ran the function and it executed and moved onto the next line, I didn't realize it hadn't worked

[shyamd]

Ok. Sounds like it's not an issue then.

[mkhorton]

passive-aggressively reopens issue it's definitely an issue, it should raise an exception if it can't ensure the index!

[mkhorton]

Specifically, these lines:

maggma/maggma/stores.py

Lines 257 to 261 in 1f875fc

	try:
	self.collection.create_index(key, unique=unique, **kwargs)
	return True
	except:
	return False

create_index already raises the appropriate exceptions, but we're silently catching them and just returning False instead, I don't think that's a great idea?

[shyamd]

Ok, re-opened.
My reason for that behavior is that usually not having an index will not halt the operation, but merely slow it down.

I leave this issue open for debate.