Giter Site home page Giter Site logo

Comments (11)

benschuster788 avatar benschuster788 commented on May 25, 2024 6

I'll take this one

from mattermost-plugin-github.

jwilander avatar jwilander commented on May 25, 2024 2

Hi @cpitclaudel, currently you need to manually subscribe to each repository if you wanted to do this. I'm not opposed to adding a feature for this though. I've added the help wanted label in case someone wants to work on it

from mattermost-plugin-github.

hanzei avatar hanzei commented on May 25, 2024 2

Submitted a PR to fix 2.

from mattermost-plugin-github.

dhadiseputro avatar dhadiseputro commented on May 25, 2024 1

I'll work on this, from where benschuster788 left off. I am not familiar yet with the code base and this can be my 'hello world' project if you guys allow. Am I good to take his code and add the fixes needed in #53 and #56 ?

from mattermost-plugin-github.

jasonblais avatar jasonblais commented on May 25, 2024

If anyone is interested working on this ticket:

  1. First PR merged here: #52
  2. Second PR containing further bug fixes was closed, but not merged, here: #56

Moreover, a PR to unsubscribe from an organization was closed but not merged, here: #53

from mattermost-plugin-github.

jasonblais avatar jasonblais commented on May 25, 2024

@dhadiseputro Go for it! If you have any questions working through it let us know. You're also open to sharing the approach you're planning to take for review 👍

from mattermost-plugin-github.

dhadiseputro avatar dhadiseputro commented on May 25, 2024

I am planning to do something similar to benschuster.
The high level idea is, in SubscribeOrg I'll get all the repos in that org and do AddSubscription for each repo.

I have some questions:

from mattermost-plugin-github.

jasonblais avatar jasonblais commented on May 25, 2024

pinging @crspeller or @aaronrothschild on the above

For channelID - that refers to the ID of a Mattermost channel. To find the ID of a channel, click the dropdown next to the channel name, then select "View Info". The ID is displayed at the bottom of the resulting dialog

image
image

from mattermost-plugin-github.

crspeller avatar crspeller commented on May 25, 2024

Looks like #67 already implements this?
Is there work left to do on this ticket? @jwilander

from mattermost-plugin-github.

dhadiseputro avatar dhadiseputro commented on May 25, 2024

Ah, yes.. #67 implemented this ticket. So repo can have the value of either just the org's name or the complete org/repo right? I was a little confused with the var naming

from mattermost-plugin-github.

jwilander avatar jwilander commented on May 25, 2024

Yes, sorry should have closed this earlier. Sorry for the churn @dhadiseputro

from mattermost-plugin-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.