Comments (11)
I'll take this one
from mattermost-plugin-github.
Hi @cpitclaudel, currently you need to manually subscribe to each repository if you wanted to do this. I'm not opposed to adding a feature for this though. I've added the help wanted label in case someone wants to work on it
from mattermost-plugin-github.
Submitted a PR to fix 2.
from mattermost-plugin-github.
I'll work on this, from where benschuster788 left off. I am not familiar yet with the code base and this can be my 'hello world' project if you guys allow. Am I good to take his code and add the fixes needed in #53 and #56 ?
from mattermost-plugin-github.
If anyone is interested working on this ticket:
- First PR merged here: #52
Second PR containing further bug fixes was closed, but not merged, here: #56
Moreover, a PR to unsubscribe from an organization was closed but not merged, here: #53
from mattermost-plugin-github.
@dhadiseputro Go for it! If you have any questions working through it let us know. You're also open to sharing the approach you're planning to take for review 👍
from mattermost-plugin-github.
I am planning to do something similar to benschuster.
The high level idea is, in SubscribeOrg
I'll get all the repos in that org and do AddSubscription
for each repo.
I have some questions:
- If we pass
repo=""
toSubscribe
, we will get here https://github.com/mattermost/mattermost-plugin-github/blob/master/server/subscriptions.go#L84, but thenghOrg
is not getting use anywhere after that. Also,repo
will still be empty, how can we continue to do theAddSubscription
at the end of the method? - What is
channelID
?
from mattermost-plugin-github.
pinging @crspeller or @aaronrothschild on the above
For channelID
- that refers to the ID of a Mattermost channel. To find the ID of a channel, click the dropdown next to the channel name, then select "View Info". The ID is displayed at the bottom of the resulting dialog
from mattermost-plugin-github.
Looks like #67 already implements this?
Is there work left to do on this ticket? @jwilander
from mattermost-plugin-github.
Ah, yes.. #67 implemented this ticket. So repo
can have the value of either just the org's name or the complete org/repo
right? I was a little confused with the var naming
from mattermost-plugin-github.
Yes, sorry should have closed this earlier. Sorry for the churn @dhadiseputro
from mattermost-plugin-github.
Related Issues (20)
- Feature Request: Subscribe to GitHub Action workflow failures HOT 4
- Feature Request: Subscribe to release events
- The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). HOT 2
- [Feature request] When linking to pull requests / issues on a private repository, show a preview instead of an error page
- this plugin is totally uselsss waste of time HOT 1
- Ephemeral message "Not able to get list of webhooks" after creating a subscription HOT 3
- `issue_creations` subscription with labels should support labeling an existing issue
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 1
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post"
- Consider implementing subscriptions feature as a form/modal HOT 1
- How to remove GitHub integration in mattermost? HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.