Giter Site home page Giter Site logo

flickity-imagesloaded's People

Contributors

desandro avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

flickity-imagesloaded's Issues

When flickity is focused, and tab is pressed, flickity scrolls to last slide.

I have a carousel with 5 slides. When I focus the carousel (click on a dot to move to for ex. slide #2), and hit tab, the carousel scrolls to the last slide (#5). I am using flickity-imagesloaded and initializing it like so:

      {
        accessibility: true,
        draggable: '>1',
        friction: 0.4,
        prevNextButtons: true,
        imagesLoaded: true
      })    ```

Everything else appears to working correctly. Any idea what might cause this bug?

My suspicion is that this behavior is caused by a button that is on the last flickity slide.

Can't figure out how to use imagesloaded

I npm installed flickity and am including it into my project via es6 syntac in the following way:

import Flickity from 'flickity';

and calling it with following options

this.flkty = new Flickity(this.refs.carousel, {
      cellAlign: 'left',
      wrapAround: false,
      pageDots: false,
      prevNextButtons: false,
      draggable: true,
      freeScroll: false,
      autoPlay: false,
      imagesLoaded: true
    });

but imagesLoaded doesn't seem to work in my case, as container still cuts them off.

Update Imagesloaded to v5

@desandro Hey David,

it seems like this package is still loading an old version of Imagesloaded (v4) which is not working correctly with srcset. Is there any way to update this to the latest version? When I install imagesloaded separately it still uses this old version within Flickity.

Thank you so much in advance,
Manuel

Plugin fires 'cellSelect' event for every image in gallery

Hi David, thanks for the great plugin you have created.

It seems when using imagesloaded: true, the cellSelect event is fired once for every image in the gallery when the plugin loads. Here is a Codepen demo showing the problem in action (you will need to view the console).

Digging around in the code I found these lines so I enabled freeScroll and sure enough the issue goes away.

I would have submit a PR but I'm not sure whether this is a bug or intended behaviour. It seems counterintuitive to be firing before the plugin is loaded. Unfortunately I can't enable freeScroll and use cellSelect to fire off a number of different actions so for my use case this is a huge problem. My workaround in the meantime is to use the settle event instead, but cellSelect would be preferred for both semantic reasons and because it fires immediately whereas settle is delayed by animation.

Thanks for your time.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.