Wrong website URL returned for library defined via XML

[mikepenz]

Wrong website URL returned for library defined via XML

[mikepenz]

@johnjohndoe seems correct. Will try it at home today with the newer version. Perhaps debugging will show me what's wrong.

You tried already to do a clean build?

[johnjohndoe]

The build is clean and the installation is fresh on the device. The error occurs at runtime.

[mikepenz]

It's really strange. I can't reproduce it with the current master and the jackson definition (which i added to the internal libs)

[johnjohndoe]

Can you try it with the old version. Also try it as a external definition file with the new and old release.

[mikepenz]

Found the exception.
If a specific library does not contain a website i won't set the onClickListener. So it will use the onClickListener of the view of the previous holder element.

Here's my fix:

//Define onClickListener
if (!TextUtils.isEmpty(library.getAuthorWebsite())) {
    holder.libraryCreator.setOnClickListener(new OnClickListener() {@Override
        public void onClick(View view) {
            //do the logic
        }
    });
} else {
    //reset the onClickListener for this listelement
    holder.libraryCreator.setOnClickListener(null);
}

[johnjohndoe]

Looks good. Might be needed for other onClickListener too.

[mikepenz]

@johnjohndoe so it's in v3.1.0 for you and v4.4.0 ;)