mingli1/unlucky

Java LibGDX Android 2D RPG Game

unlucky's Issues

numFrames and delay are never used in the init() method of Particle class Bug.

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Particle Class
• Store this instance in a variable
• Call the init() method on this variable, with the following params: int type, Vector2 position, Vector2 velocity, float lifespan, int numFrames and float delay.

Assert:

• A new particle instance will be created after the call of the init() method with the use of all of the parameters.

Excepting:

• init() method will use every parameters to create a new Particle instance.

Actually:

• We can specify the numFrames and delay params, but they are never used in the method.

Possible solution:

• Deleting the numFrames and delay variables from the parameter list of the init() method in the Particle Class.

Set the type of a Move to something else then 0, 1, 2 or 3 Bug.

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Move Class with the following parameters:
  • type=6
  • the other parameters can be anything.

Assert:

• The constructor will handle that the type is not 0, 1, 2 or 3 (because there are only 4 types of moves, written by the javadoc to the Move class. They can 0=Accurate, 1=Wide, 2=Crit and 3=Healing).

Excepting:

• We got an exception or a warning that we cannot make a new Move with a type of 6.

Actually:

• We can freely make a new "move" with the type of 6, and we do not get any warning.

Add percent HP potions and exp potions

Potions that restore 30% of hp or something
Also scale potion hp by level?

"Variable is already assigned to this value" in the init() method of Particle class Bug

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Particle Class
• Store this instance in a variable
• Call the init() method on this variable, with the following params: int type, Vector2 position, Vector2 velocity, float lifespan, int numFrames and float delay.

Assert:

• A new particle instance will be created after the call of the init() method.

Excepting:

• No unnecessary line of codes run in the method.

Actually:

• There is an if statement that check, if the anim variable is null and if yes, then assign this variable a null, but the variable already has the value of null, so the if statement is unnecessary in the init() method.

Possible solution:

• Delete the 81 line of the Particle Class, since the anim variable has been already assigned to this value.

Lightning bug and shadows

Lightning when night is toggled off turns it back on.
Remove shadows during the night except when in light

Make item enchantments cost gold

Need to have a cost to them rather than just luck.

Enchant Cost Bug

Sometimes items bought from the shop have 0 enchant costs. Not a huge issue because if the player has enough gold to buy the item, they probably have enough to enchant it as well.

@TODO Revert ice animation

Set animation to a single frame.

Delta time movement shaky

The player shakes a bit when moving with delta time movement because of float screen position rounding to integer tile position

Cull lighting outside of player's view

Don't render light outside the player's view to increase performance.

Inventory bug

swapping an equipped item and an item of the same type from inventory then moving the equipped item on top of that item causes 2 items in the same slot. can be resolved by moving the item on top to a different slot

@TODO Random tile scaling

Set "?" tile to scale off of map level.

ERROR LAPTOP

I've downloaded for pc run it and in the game doesn't happen when I click the keys awsd or any and also using the mouse nothing happens

@TODO Adjust move names to match damage

Damage is underwhelming/doesn't correspond to move names.

Enemy AI

Enemies should heal once when below a percentage of hp if it can
Bosses should be smarter and heal if the player uses moves like Reflect

Make items have a hidden level

Give each item some level so that only monsters of that level or higher can drop it

Shop items don't have enchantment costs

They cost nothing to enchant because there is no hidden level of items yet to scale base enchanting costs off of. Currently enchanting costs are based on enemy/map level.

Shield bug

Shield bar and status icon still appears in a new battle if untouched in the previous battle.
To reproduce: Defeat an enemy after using shield and start a new battle.

Both the origin and position of an instance of the Moving class is changing instead of the position only, and origin no Bug.

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.
• The com.badlogic.gdx.math.Vector2 Class is available and we can make Vector2 objects from it.

Act:

• Making an instance of Moving Class with the following parameters:
  • origin = new Vector2(1, 2)
  • target = new Vector2(7, 5)
  • speed = 1.4f
• Store this instance in a variable and call it as "moving1".
• Call the start() method on the "moving1" variable.
• Call the update() method on the "moving1" variable with number two as parameter.

Assert:

• The position of the object is changing, but the origin will not.

Excepting:

• The position of the object is changed, while the origin stay still after the call of the update() method.

Actually:

• Both the origin and position of the "moving1" changed after the call of the method.

Adding an Item to the Equipment with the addEquip() method while the index of the Item is 0 or 1 Bug

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Equipment Class
• Creating an Item with a type value of 0.
• Adding this Item to the Equipment with the addEquip() method.

Assert:

• The method will handle that the type is not greater or equals then 2.

Actually:

• We got ArrayIndexOutOfBoundsException.

Set the damage to 0 or 1 while creating a new move from Move Class Bug.

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Move Class with the following parameters:
  • damage=0
  • the other parameters can be anything.
• Store this instance in a variable and call it as "move1".
• Check if the min/max damage is anything else then 0 and 1.

Assert:

• The min/max damage can not be 0 or 1 written by the javadoc to the Move constructor.

Excepting:

• We got an exception or something that warn us that we cannot create a new Move with damage=0 or damage=1.

Actually:

• We can freely make a new "move" with damage=0 and damage=1 without any problem, even if the javadoc said that we cannot do it.

ResourceManager cannot be instantiated during junit testing bug

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Creating a TestFile where we want to run the test case.
• Making an instance of ResourceManager Class
• Check if the instance is created of not with assertNull.

Excepting:

• We can make an instance of the ResourceManager class and run different test cases on it to check, if it's working properly or not.

Actually:

• During the test, we got a NullPointerException.

Special move/spell set system

The player unlocks different special moves as they level up. They can have an inventory of special moves where they can choose 3 or 4 as a set to bring into battle.

Add enchant scrolls

Enchant scrolls of various rankings that increase the chance of enchanting success from default 50% to +10%, +20%..., +40%.
To use them, the user would drag the scroll onto the item they want to enchant and the next enchant they attempt will have increased probability to succeed.

Starting transferring data to jsons

Load data like dialog rather than hardcode it in

Modding

Am I allowed to edit the version I downloaded on my device. If so how do I edit the files or value that you would recommend.

Sorry I don't know how to just comment

Merge skins into main atlas

When all assets have been finished, merge the ui skin and dialog skin into the main TextureAtlas for less texture bindings.

We can add the Util.SHIELD moveset twice to an instance of a SpecialMoveset class twice, as special moveset Bug

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of a SpecialMoveset Class
• Store this instance in a variable
• Check if addSMove() method is declared and implemented in the SpecialMoveset Class
• Call the addSMove() method on the variable (that stores an instance of the SpecialMoveset Class) and call it with a Util.SHIELD as parameter, and do it twice.

Assert:

• Only one moveset should be stored as special moveset.

Excepting:

• Only 1 moveset is stored as special moveset in the variable.

Actually:

• The size of the array is 2, so we stored twice the Util.SHIELD as moveset.

Statistics

Track player statistics for battle and other stuff

Show item name when enchanting or selling

For example, the prompt should say "Are you sure you want to enchant [item name]?" or "Are you sure you want to sell [item name]?"

set the min to be greater then the max in the constructor of the Move class Bug

Arrange:

• Configuring the environment (with for example Gradle v3.3).
• Importing the junit .jar files, so we can run junit test cases.

Act:

• Making an instance of Move Class with the following parameters:
  • min = 25
  • max = -3
  • the other parameters can be anything.

Assert:

• The constructor will handle that the min value is greater then then max value.

Excepting:

• The constructor set the value of the max to be the value of the min (because the min is greater then the max, and wtih this, the value of the min <= then the value of the max.

Actually:

• The constructor set the value of the min to the value that is stored in the parameters as min and set the value of the max to the value that is stored in the parameters as max.
• The constructor not handle that the value of the min is greater then the value of the max.

Reflect special move

New special move called Reflect that reflects the enemy's next attack. If it's a heal then it heals the enemy for twice as much.

Rain aesthetics

When rain falls on lava it should produce a steam effect

New special moves

Stun - enemy has a chance of skipping its turn
Invert - heal moves do damage and damage moves heal
Shield - shields the player for one turn for a certain amount of damage
Also, make special moves available every 3 turns