mmlabs-mindmaze/xdffileio

Library to read/write EEG data file formats

xdffileio's Issues

Test suite failures on i386

Hi,
I intend to upgrade the Debian packaged version of xdffileio to version 1.0. We are building against the Debian packaged libmmlib version 1.4.2 which requires some patches which might be relevant for the issue.
The test suite passes nicely in our CI for amd64 architecture. However, for i386 we get:

FAIL: testbdf
FAIL: testedf
FAIL: testgdf1
FAIL: testgdf2
FAIL: readcheck
FAIL: recompose-gdf.sh
FAIL: errorcheck
FAIL: unittests.tap 1 - xdf_prepare_end_transfer_test.c:xdf-prepare-end-transfer:test_xdf_prepare_transfer: Assertion 'xdf != ((void *)0)' failed
FAIL: unittests.tap 2 - xdf_prepare_end_transfer_test.c:xdf-prepare-end-transfer:test_xdf_end_transfer: Assertion 'xdf != ((void *)0)' failed
PASS: unittests.tap 3 - open_test.c:open:trunc_flag: Passed
FAIL: unittests.tap 4 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 5 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 6 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 7 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 8 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 9 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 10 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 11 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 12 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 13 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 14 - read_test.c:read:unscaled_read: configuration failed
FAIL: unittests.tap 15 - read_test.c:read:unscaled_read: configuration failed
ERROR: unittests.tap - exited with status 1
=========================================
   xdffileio 1.0: tests/test-suite.log
=========================================
# TOTAL: 23
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  21
# XPASS: 0
# ERROR: 1
.. contents:: :depth: 2
FAIL: testbdf
=============
    Version : xdffileio 1.0
04/12/23 20:11:13 ERROR mmlib            : unlink(essaiw.bdf) failed ; No such file or directory (mm_unlink() in ../src/file-posix.c:370)
04/12/23 20:11:13 ERROR mmlib            : unlink(essaiw.bdf.event) failed ; No such file or directory (mm_unlink() in ../src/file-posix.c:370)
04/12/23 20:11:13 ERROR mmlib            : unlink(essaiw.bdf.code) failed ; No such file or directory (mm_unlink() in ../src/file-posix.c:370)
04/12/23 20:11:13 ERROR mmlib            : lseek(3, 5376, 163836936) failed ; Invalid argument (mm_seek() in ../src/file.c:100)
04/12/23 20:11:13 ERROR mmlib            : lseek(3, 236, -135446776) failed ; Invalid argument (mm_seek() in ../src/file.c:100)
    The files differs at 0x000000ec
FAIL testbdf (exit status: 1)
FAIL: testedf
=============
    Version : xdffileio 1.0
04/12/23 20:11:13 ERROR mmlib            : unlink(essaiw.edf) failed ; No such file or directory (mm_unlink() in ../src/file-posix.c:370)
04/12/23 20:11:13 ERROR mmlib            : lseek(3, 5376, 142337032) failed ; Invalid argument (mm_seek() in ../src/file.c:100)
04/12/23 20:11:13 ERROR mmlib            : lseek(3, 236, -135106808) failed ; Invalid argument (mm_seek() in ../src/file.c:100)
    The files differs at 0x000000ec
FAIL testedf (exit status: 1)
FAIL: testgdf1
==============
    Version : xdffileio 1.0
04/12/23 20:11:13 ERROR mmlib            : unlink(essaiw.gdf1) failed ; No such file or directory (mm_unlink() in ../src/file-posix.c:370)
...

Feel free to check the full build log on i386

Kind regards, Andreas.

UINT24_MAX cannot be even

33:xdftypes.h #define UINT24_MAX 16777216

This value cannot be even. It should be one less.

Buffering issue with xdffileio

Hello

I faced the problem when biosemi sometimes stops sending data packets to the cnbitk loop. You commented the following part in xdffile.c

    // Make sure that the whole record has been sent to hardware

•   /*
  if (fsync(xdf->fd)) {
          xdf->reportval = -errno;
          return -1;
  }
  

•   */
  xdf->nrecord++;
  
  return 0;
  

Check the problem