[FEAT] Scala 2.13 support?

[kg005]

[FEAT] Scala 2.13 support?

[RobinL]

Thanks for the request. We're pretty stretched at the moment so we're unlikely to be able to get round to this soon. If you're willing/able, feel free to do a PR, which would be gratefully accepted!

[kg005]

Hi @RobinL, here is a PR for the changes needed to build the splink_scalaudfs for Scala 2.13. As I am new to Scala, I would be happy to have it reviewed so I can adjust it as needed.

[RobinL]

@kg005 Thank very much. Just to say we're taking a look at this. I'm also not a scala person myself, but the code looks ok to me at least.

One thing we need to be careful with is accepting an external PR that includes the jar, since we have no easy way of knowing whether it contains malicious code. (The diff looks ok, and the code you're wrote looks fine btw, so this is no reflection on you, just security policy!)

I'm going to try and get a colleague to build it on their machine. But if you happen to work for somewhere 'trusted' (e.g. uk gov, let me know and it'll make it a little easier - [email protected]!)

[kg005]

Thanks for the heads up @RobinL. I understand the policies. Feel free to override the jar with a new version that you manage to build using your infrastructure.