Is it possible to ignore files?

[mike-zorn]

Is it possible to ignore files?

[naholyr]

Hmmm, not really.

You can ignore TODOs one by one when you will push this bunch of code for the first time (fastidious but safe), or use option files but it's inclusive not exclusive so you will have to list all folders except the one you want to exclude.

Let's work on this ;)

[mike-zorn]

Yeah, that's less than ideal 😉 I think this actually is a valid use case because people check in their node_modules in certain circumstances too. What are your thoughts on adding a .github-todos-ignore-files file?

[naholyr]

What do you think of supporting -pattern in files option?

In your case:

ght config files '**, -deps/fftw-*/**'

It's not as flexible as a new dot-file, but on the other hand it does not create a new dot-file ;)

[mike-zorn]

Works for me!

[naholyr]

It's pushed on master, but as a few other big changes currently land here I'd like to push it after more tests. Would you like to test? (hint: DRY_RUN works)

npm install -g naholyr/github-todos

I'll start working on a separate branch (develop) for next changes like that.

[mike-zorn]

I'm getting the following when I try to init.

[Github-Todos] To disable checking credentials on 'init', add option '--no-connect'
[Github-Todos] Hook file not found, create new one…
[Github-Todos] Hook installed
[Github-Todos] Option 'repo' is not set
[Github-Todos] Now guessing initial configuration from remote 'origin'…
[Github-Todos] TypeError: Object apechimp/node-fftw has no method 'then'
[Github-Todos] Failed to fetch 'repo' option
[Github-Todos] Now guessing initial configuration from remote 'origin'…
TypeError: Object apechimp/node-fftw has no method 'then'

[naholyr]

Hmm did not reproduce it, what's the output of ght config --local and then DEBUG=* ght init ?

[mike-zorn]

ght config --local returned nothing. DEBUG=* ght init returned

DEBUG=* ght init --force
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos Shell: git rev-parse --git-dir +95ms
[Github-Todos] To disable checking credentials on 'init', add option '--no-connect'
  github-todos Shell: git rev-parse --git-dir +2ms
  github-todos service.connect +116ms
  github-todos:github connect +0ms { _version: '2.1.0',
  'github.token': 'xxxxREDACTEDxxxx' }
  github-todos:github token found: authenticate +23ms xxxxREDACTEDxxxx
  github-todos:github checkToken +0ms
[Github-Todos] Hook file found, github-todos command found.
[Github-Todos] Execution forced by option --force: add github-todos command on top anyway…
[Github-Todos] Hook installed
  github-todos Shell: git rev-parse --git-dir +233ms
[Github-Todos] Option 'repo' is not set
[Github-Todos] Now guessing initial configuration from remote 'origin'…
  github-todos Shell: git config --local remote.origin.url +6ms
  github-todos Shell: git rev-parse --git-dir +5ms
[Github-Todos] TypeError: Object apechimp/node-fftw has no method 'then'
[Github-Todos] Failed to fetch 'repo' option
[Github-Todos] Now guessing initial configuration from remote 'origin'…
  github-todos Shell: git config --local remote.origin.url +7ms
  github-todos Shell: git rev-parse --git-dir +5ms
TypeError: Object apechimp/node-fftw has no method 'then'
Possibly unhandled TypeError: Object apechimp/node-fftw has no method 'then'
    at /usr/local/lib/node_modules/github-todos/lib/cli/init.js:132:71
    at tryCatch1 (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/util.js:45:21)
    at Promise$_callHandler [as _callHandler] (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/promise.js:660:13)
    at Promise$_settlePromiseFromHandler [as _settlePromiseFromHandler] (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/promise.js:675:18)
    at Promise$_settlePromiseAt [as _settlePromiseAt] (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/promise.js:845:14)
    at Promise$_settlePromises [as _settlePromises] (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/promise.js:988:14)
    at Async$_consumeFunctionBuffer [as _consumeFunctionBuffer] (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/async.js:77:12)
    at Async$consumeFunctionBuffer (/usr/local/lib/node_modules/github-todos/node_modules/bluebird/js/main/async.js:40:14)
    at process._tickCallback (node.js:419:13)

[naholyr]

Perfect, thanks for the data, I'm on it

[naholyr]

Could you please try again, after a new npm i -g naholyr/github-toods.

I added a new option ght --version, it shoud print "3.0.0-dev" after that. Really sorry I couldn't find any way to face the bug myself.

Could you please provide the url of your remote too? git config remote.origin.url

[mike-zorn]

So the pattern appears to do the opposite of what I'd expect.

$ git push origin develop
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos Shell: git rev-parse --abbrev-ref HEAD +275ms
  github-todos Shell: git diff -u 14c44ee02b1e5f45a000430b1795faf37d2b62ef..3f26d1ebd3c23c0ddcbe1e24311b7af661cf1b8a +9ms
  github-todos Ignore +12ms src/plan.cc
  github-todos Shell: git rev-parse --git-dir +1ms
  github-todos no client: connect before work +15ms
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos service.connect +8ms
  github-todos:github connect +0ms { _version: '3.0.0-dev',
  'github.token': 'xxxREDACTEDxxx',
  repo: 'apechimp/node-fftw',
  files: '**, -deps/fftw-*/**' }
  github-todos:github token found: authenticate +38ms xxxREDACTEDxxx
  github-todos:github checkToken +0ms
  github-todos:github findIssueByTitle +205ms apechimp/node-fftw shouldn't be there
  github-todos:github allIssues +0ms
? Create new issue "shouldn't be there" (deps/fftw-3.3.4/api/execute-split-dft-c2r.c:31) Create issue
  github-todos Shell: git rev-parse --git-dir +3s

  github-todos no client: connect before work +8s
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos service.connect +10ms
  github-todos:github connect +0ms { _version: '3.0.0-dev',
  'github.token': 'xxxREDACTEDxxx',
  repo: 'apechimp/node-fftw',
  files: '**, -deps/fftw-*/**' }
  github-todos:github token found: authenticate +7ms xxxREDACTEDxxx
  github-todos:github checkToken +1ms
  github-todos:github createIssue +135ms apechimp/node-fftw shouldn't be there Ref. [deps/fftw-3.3.4/api/execute-split-dft-c2r.c:31](https://github.com/apechimp/node-fftw/blob/3f
26d1ebd3c23c0ddcbe1e24311b7af661cf1b8a/deps/fftw-3.3.4/api/execute-split-dft-c2r.c#L31)

//TODO shouldn't be there

(automatically generated by [Github-Todos](https://github.com/naholyr/github-todos))
[Github-Todos] Created issue #9 (shouldn't be there) - https://github.com/apechimp/node-fftw/issues/9
[Github-Todos] OK.
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos Shell: git rev-parse --abbrev-ref HEAD +265ms
Counting objects: 17, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.

Occurs when I commit mike-zorn/node-fftw@3f26d1ebd3c23c0d

[naholyr]

Ok then we're in some testable reproducible playground now ;)

What's your ght config files ? I'll test it here, fix and should be ready for a publish then.

(edit: FU markdown)

[mike-zorn]

$ ght config files
  github-todos Shell: git rev-parse --git-dir +0ms
  github-todos Shell: git rev-parse --git-dir +399ms
**, -deps/fftw-*/**

[naholyr]

Yep, that was simply reversed in fact.

You can use master version until published (I'll add a comment here to let you know). I'll add some unit tests before publishing 'cause I don't want next issues to be so chaotic ;)

[mike-zorn]

Thanks!!!

haha yeah, I looked at your commit 😝

[naholyr]

Note: your version is now in develop branch, and should be meger to master as stable in one or two weeks (a newborn will be home then, I may have more night time :'))

[naholyr]

Published as v2.2.0, tests will have to come later I already had published most dangerous commits in v2.1.0 anyway :x