najamelan/async_nursery

Primitive for structured concurrency.

async_nursery's Issues

`tracing` feature has an implicit dependency on `futures` crate which should be declared

If the tracing feature of this crate is enabled without also enabling the implementation feature (e.g. default-features = false):

error[E0432]: unresolved import `futures`
 --> /home/teohhanhui/.cargo/registry/src/github.com-1ecc6299db9ec823/async_nursery-0.4.0/src/tracing.rs:5:2
  |
5 |     futures         :: { FutureExt                              } ,
  |     ^^^^^^^ use of undeclared crate or module `futures`

Use shorter lifetimes

Right now, I use the function: fn nurse( &self, fut: impl Future<Output = Out> + Send + 'static ) -> Result<(), NurseErr>; This unfortunately means I can't use references in my async fn with a lifetime less than 'static, which is quite inconvenient.

I'm not really sure of the complexity of changing that, but I'd appreciate any thoughts you have on it.

Possibility to split the core into a separate crate?

For example, in my library I have an interval function which takes a Nurse<_> and calls NurseExt<_> methods on it:

https://github.com/teohhanhui/callbag-rs/blob/d0a7523018854a44a3c4d1687fefa893afa3beb0/src/interval.rs

Currently, every user of my library would be forced to bring in a whole lot of dependencies, even if they don't use this interval function.

This is because async_nursery depends on async_executors and futures.

From what I can see, if we were to split into a crate such as async_nursery_core, which includes:

• https://github.com/najamelan/async_nursery/blob/3c6c55aa9900c31c86fdce709395a7dc3e575aaa/src/error.rs
  https://github.com/najamelan/async_nursery/blob/3c6c55aa9900c31c86fdce709395a7dc3e575aaa/src/local_nurse.rs
• https://github.com/najamelan/async_nursery/blob/3c6c55aa9900c31c86fdce709395a7dc3e575aaa/src/nurse.rs

It only needs to have these dependencies:

• futures-channel:
  • TrySendError
• futures-task:
  • FutureObj
  • LocalFutureObj
  • SpawnError

And we shouldn't run afoul of coherence rules, since struct Nursery<_, _> and struct NurseryStream<_, _> will both still be defined in the async_nursery crate.