nicklondhe/wikiindexer

Starter code and tests for wikipedia indexer

wikiindexer's Issues

Could you add .DS_Store to .gitignore file?

Thank you very much!

Bug in TokenStreamTest

1.  //same token repeated
   stream = new TokenStream("hello");
   stream.append("hello","hello","hello","helllo");
   assertEquals(0, stream.query("test"));
   assertEquals(5, stream.query("hello"));
   stream = null;
   

   in line 177 line of the origin file. I think the there is a typo on the third line. Should the helllo be hello?

2.  for (int i = 0; i < 4; i++)
       stream1.mergeWithNext();
   

   on line 883. here is refered as (1)

   //with merge with previous
   stream = new TokenStream("this");
   stream.append("is", "a", "test", "string");
   stream.next();
   stream.mergeWithPrevious();
   assertEquals(0, stream.query("this"));
   assertEquals(1, stream.query("this is"));
   stream = null;
   

   on line 199. here is refered as (2)

   //with merge with next
   stream = new TokenStream("this");
   stream.append("is", "a", "test", "string");
   stream.mergeWithNext();
   assertEquals(0, stream.query("this"));
   assertEquals(1, stream.query("this is"));
   stream = null;
   

   on line 208. here is refered as (3)

   I'm not quite sure about whether here is a bug. But at code (1), the pointer of the tokenstream is before the first element. here we can only merge the following two elements. But at code (2)and (3), the test cast require us to merge the elements around the pointer(since pointer in between "this" and "is"). I think here is a conflict on the behaviour of the function.

Bug in TokenStreamTest

//same token repeated
stream = new TokenStream("hello");
stream.append("hello","hello","hello","helllo");
assertEquals(0, stream.query("test"));
assertEquals(5, stream.query("hello"));
stream = null;

The last appended word is misspelled as "helllo" instead of "hello" and the test case fails.