nrel/pv_ice

An open-source tool to quantify Solar Photovoltaics (PV) Energy and Mass Flows in the Circular Economy, from a Reliability and Lifetime approach

pv_ice's Issues

Update versioning control

Find new versioning control software;
versioneer is failing :(

S.

Function to compare baseline files and see differences

Function to compare baseline files and see differences

TEMP folder .gitignore

RE-add .gitignore to TEMP folder and make sure it creates on new installations.

Broken link

The first four links in the file README.md are broken. The readthedocs hyperlink in the Peer Reviewed Journals section is also broken.

import data - convert units function needed

Internally the program assumes everything is grams, but if baseline has "kg" it shoudl be able to conver to.

Current solution is have all baselines in g. This might be okay but a function to doublecheck will be needed.

description or process changed for mat_MFG_scrap_Recycled_into_HQ ?

mat_MFG_scrap_Recycled_into_HQ [%]: float Material Manufacturing Scrap Recycled into High Quality in percentage. Percentage of manufacturing scrap which is recycled into high quality/high purity material and used for non-PV applications (open-loop).

https://pv-ice.readthedocs.io/en/latest/data.html

It used to be that material could either be low quality or high quality, and then if it is high quality it can go into PV; as it reads right now ti seems to be exclusive and if this column (column G) has values then it voids column H?

@heathermirletz

Improved Batthub Curve

EOL_PG... and others, add a '0' padding

Add Weibull function - Alpha only

To replicate Heath's results, we need a Weibull function with Alpha only.

Handle data and materialdata indexes

Currently, data and mateiraldata is indexed in int. If different lengths (not same years), it crashes.

Ideally:

1. Set indexes to PerdioIndex - year
2. Clip years in materialdata that are not in data, and padd years that are missing from materialdata that are in data.

Installation Issues

Well, I'm sure at some point I did this correctly because even Heather installed it <2 months ago, but now it's not working.

It used to work by cloning, navigating to folder and then doing a pip install -e .

Now that doesnt even work.
Much less the pyppi, been stuck on that forever...