p4535992/foundryvtt-pin-cushion

Adds additional functionality around Map Pins

Pin Cushion (note on canvas and journal directory enchantment)

If you want to buy me a coffee

Adds additional functionality around Map Pins

NOTE

In compliance with the licenses, some piece of code of some feature has been inserted by other projects that I describe in detail in the "Credits" department of this README, I invite you to support these developers.

My aim is not to take credit for their work, I just don't want to install 100 modules for 100 features which then collide with each other, every single external feature can be disabled in the settings of this module to allow the use of modules between them .

Installation

It's always easiest to install modules from the in game add-on browser.

To install this module manually:

1. Inside the Foundry "Configuration and Setup" screen, click "Add-on Modules"
2. Click "Install Module"
3. In the "Manifest URL" field, paste the following url: https://raw.githubusercontent.com/p4535992/foundryvtt-pin-cushion/master/src/module.json
4. Click 'Install' and wait for installation to complete
5. Don't forget to enable the module in game using the "Manage Module" button

Known issue

• This module slows down opening journals a bit (the rendering to understand each other), I guess for all the controls, filters and overrides i do, any help is solved this issue is welcome

libWrapper

This module uses the libWrapper library for wrapping core methods. It is a hard dependency and it is recommended for the best experience and compatibility with other modules.

Settings

• Force to show notes: Automatically flag journal notes to show on the map without having to have your players turn it on themselves.

• Preview Maximum Length: TEXT PREVIEW ONLY How many characters should the text preview show?

• Preview Delay: How long before preview appears (in milliseconds)

• Default Journal Entry Permission: The default permission journal entries will be created with

• Default Journal Entry Folder: The default folder journal entries will be created in when creating Map Pins with a double-click

• Show by default the icon image of the journal on the map note: If a image is set on the journal by default is the first image set from Pin Cushion

• Enable Player-Only Icons by default: Newly created notes will have player-only icons enabled automatically.

• Default Note Icon for Players: The default icon used for player-only icons

• GM Label: Add the ability for Note tooltips to be configured so that GMs see different text to Players. So secret information can be displayed to GMs whilst players see the 'public' information about the Note.

• Enable revealed state on scene Notes: When enabled, then the 'revealed' state will be used to determine if the Note is visible to players. (The default Foundry VTT behavior is for Notes to be visible to players only if the linked document is accessible by the player.)

• [Only if setting 'Enable revealed state on scene Notes.' is enabled] Set the tint color of the Note revealed state on scene Notes: Is an option to set the tint color of the Note icon to indicate if the linked document is reachable or not (if the Note has no linked document, then it will always be displayed in the 'unreachable' tint).

• [Only if setting 'Enable revealed state on scene Notes.' is enabled] Note Tint Color when linked: For PLAYERs, the RGB value to be used to tint scene Notes if they have a reachable link (if left blank then the tint, if any, will remain unchanged). For GMs, this is the initial Icon Tint set during import.

• [Only if setting 'Enable revealed state on scene Notes.' is enabled] Note Tint Color when not linked: For PLAYERs, the RGB value to be used to tint scene Notes if they do not have a reachable link (if left blank then the tint, if any, will remain unchanged). For GMs, this is the initial Icon Tint set during import.

• Select Specific Folder: Make sense only with the module setting 'Default Journal Entry Folder' set with value 'Specific folder'

• Enable feature Backgroundless Pins: If enabled this setting will let you with a additional checkbox 'Has Backgorund ?' on the note configuration panel remove or not the background box from map notes. WARNING: If you disable this module setting you simply have all your notes with background (the standard way), but the flags on the notes are not delete, so you can re-enable this when you want. YOU NEED TO REFRESH THE PAGE FOR APPLY THE SETTING.

• Enable Sidebar Journal Images for GM Users:

• Enable Sidebar Journal Images for Player Users:

• [Only if setting 'Enable Sidebar Journal Images for GM Users' or 'Enable Sidebar Journal Images for Player Users' is enabled] Thumbnail Position: Whether the thumbnail is left of the journal entry title or right.

• Use mouse position for show the tooltip: When you hover a note on the canvas the tooltip is build based on the current mouse position instead the journal icon position. This solution seem to be more dynamic.

Features

This module add many new settings for many use case on the Note config dialog, here some of the most interesting, but there is more:

• Create Pin on canvas with double click

• Customized note configuration

• Journal preview on the sidebar

• Changes the dropdown of map pin icons into a filepicker so users can select any icons they like
• Adds the ability to double-click the canvas while on the Notes Layer and create a map pin (and corresponding Journal Entry)
• Adds a preview of the associated Journal Entry when you hover over a map pin
• Removes the background box from map notes

• Add the possibility to add a thumbnail preview of the journal

• [Only with setting 'Enable revealed state on scene Notes' enabled] Add an option to have a 'revealed' state on scene Notes: When enabled, then the 'revealed' state will be used to determine if the Note is visible to players. (The default Foundry VTT behaviour is for Notes to be visible to players only if the linked document is accessible by the player.)

• [Only with setting 'Enable revealed state on scene Notes' enabled] Add an option to set the tint colour of the Note: Icon to indicate if the linked document is reachable or not (if the Note has no linked document, then it will always be displayed in the "unreachable" tint).

• [Only with setting 'Enable revealed state on scene Notes' enabled] Provide tint colours to allow GMs to see if notes have been revealed to players. Setting the tint to a blank string will remove this tinting.

• Add an option to hide the label text: It will hide the label text when you hover on the note, it useful for avoid the "double" test given from the 'label' and 'title' attributes.

• Add an option to always show the label text: The label of the note is always visible without the need to go to hover the note useful for note on a map or any use case.

• Add an option to do not show Journal Preview: Do not show the journal preview to the player can be useful in some case.

• Add an option for setup the tooltip placement (default: 'e') Placement location of the tooltip relative to the element it is open for. Values can be n, e, s, w, nw, ne, sw, se, nw-alt, ne-alt, sw-alt, or se-alt (as in north, east, south, and west). This only matters if followMouse is set to false.

• Add an option for setup the tooltip stylish color

• Add an option for setup the tooltip smartplacement behaviour: (default: false) When enabled the plugin will try to keep tips inside the browser viewport. If a tooltip would extend outside of the viewport then its placement will be changed to an orientation that would be entirely within the current viewport.

• Add an option for setup the pin is transparent ? behaviour: Now with a simple checkbox on the note configuration it is possible to make the icon transparent without wasting time looking for the transparent image file. Very useful for people who use maps with icons printed on the map and just want to show the tooltip when the cursor is over that image and it saves me a lot of time. NOTE: This configuration is applied only to the icon image of the note , not the image tooltip.

• Add an option for setup the Show only to GM ? behaviour: Quite simply regardless of the associated permissions it shows the note only to the gm, it is very useful when used with this other module Automatic Journal Icon Numbers to prepare notes for the GM or random encounter with the Ironmonk modules, personally it saves me a lot of time in not continuously setting the permissions on the associated journal.

• Enable drag note on token layer if GM: Enable drag note on token layer if GM

• Enable autoscale for nameplates of the note on the canvas: Enable autoscale for nameplates of the note on the canvas",

• Default image icon for on creation of a note Set the path to a image to use as default icon during the creation of the note on the canvas.

• Shows Pages in the journal directory: Adds expandable elements to the journals in their directory to show the journal's pages

Build

Install all packages

npm install

dev

dev will let you develop you own code with hot reloading on the browser

npm run dev

npm build scripts

build

build will build and set up a symlink between dist and your dataPath.

npm run build

build-watch

build-watch will build and watch for changes, rebuilding automatically.

npm run build-watch

prettier-format

prettier-format launch the prettier plugin based on the configuration here

npm run-script prettier-format

Changelog

Issues

Any issues, bugs, or feature requests are always welcome to be reported directly to the Issue Tracker, or using the Bug Reporter Module.

License

• FVTT-Backgroundless-Pins (GPLv3 License)
• foundryvtt-journal-thumbnail (MIT)
• Point of Interest Teleporter (MIT)
• vtt-gmtext-in-notes (MIT)
• fvtt-revealed-notes-manager (MIT)
• journal-sidebar-images (MIT)
• jquery-powertip (MIT)
• Pin Fixer (MIT)
• fvtt-revealed-notes-manager (MIT)
• Journal Anchor Links (Foundry License)
• Player Pin Defaults (???)
• journal-directory-pages (???)

This package is under an GPLv3 License and the Foundry Virtual Tabletop Limited License Agreement for module development.

Acknowledgements

• Thank you to schultzcole for the module FVTT-Backgroundless-Pins inspiration
• Thank you to J-Guenther for the module foundryvtt-journal-thumbnail inspiration
• Thank you to zeel for the module Point of Interest Teleporter
• Thank you to farling42 and the module vtt-gmtext-in-notes
• Thank you to farling42 and the module fvtt-revealed-notes-manager
• Thank you to jessev14 and the module journal-sidebar-images
• Thank you to stevenbenner and the javascript project jquery-powertip
• Thank you to zeel for the module Pin Fixer
• Thank you to farling42 and the module fvtt-one-click-note-creation
• Thank you to Friendly Lambda and the module map-note-hover-display
• Thank you to aMediocreDad and the module Journal Anchor Links
• Thank you to ClipplerBlood and the module Player Pin Defaults
• Thank you to xaukael and the module journal-directory-pages

foundryvtt-pin-cushion's Issues

[Feature][Discord] Change the size of the pin to create rectangles

Hey, I just saw that you are the creator of the Pin Cushion module. I totaly love it and I wondered if there will be an v10 update. The most important feature for me would be to hide the pin background. Also very useful would be if you could change the size of the pin to create rectangles

From: Mugglemage on discotd

[BUG] Enable revealed state on scene notes fails canvas drawing

Hi,

using the newest module version and the current stable foundry v10. When enabling the module option "Enable revealed state on scene notes" and refreshing no scene will load anymore, only with a black screen. The error "Canvas drawing failed: PIN_IS_REVEALED is not defined" pops up.

Make "jump to pin" from journal tab works

Maybe I should file this under bug, but I would like to be able to right-click and "jump to pin" from the journal tab. Unfortunately, notes created with Pin Cushion do not offer this option.

Thanks!

[BUG] v1.8.28 Causes Chat Room to slide whenever you right click on a Journal Entry on a map.

The chat room will slide about 1/4th of the way to the left whenever you right click a Journal Entry on the map. Right clicking off of it restores it, however, I am using this module in conjunction with Multilevel Tokens and Point of Interest Teleporter to use Journal Entries to jump to other maps. When I do so, the shifting of the chat room remains permanent.

[Feature/Customization] Player Note Defaults + Player Token Pin Artwork

I am allowing players to set pins in our PF2 Abomination Vault to identify dangerous locations, sounds and tracks of enemies, so we reached the limits of the current features of Foundry V10 and PinCushion so I need few additional features to remove the need to always go after player pins after the session and fix them manually.

1. Option to set the default size of the player Pins. They are currently set to 40px while GM pins are at 113px. I want to be able to set them relatively close to each other.
2. Option that makes player pins always show their text label without needing to press ALT and without needing to edit the pin
3. Option to use the actor's own token image (avatar or token) as the pin image instead of default pin image set for players.

[BUG] ressing ALT does not reveal all notes labels anymore

Module Version: v1.7.5

Before open any issue

Describe the bug

https://discord.com/channels/170995199584108546/722566083499786352/1010209403007418438

When the module "Pin cushion" is enabled then pressing ALT does not reveal all notes labels anymore. Instead there seems to be a maximum and every time you press alt it cycles through other labels being displayed. Also happens with all other modules disabled.
To Reproduce

Expected behavior

Screenshots

Browser:

Foundry Version:

Game System:

Additional context

Allow Width to Size Ratio to be a fraction

The ability to use images as icons has opened up new use cases, unfortunately, the images are either distorted into squares or, if using the Width to Size ratio, wide rectangles (wider than they are tall).

I have a use case where I would prefer to use tall rectangles, example: a 200 x 400 image. Turning the images into squares with a transparent background is a simple stop-gap; however, in the long-term, I would like to see Pin Cushion support fractions in the Width to Size Ratio field.

For example, if I want to use a 200x400 image, I could simply enter 0.5 in the Width to Size Ratio field and 400 in the Icon Size field.

[BUG] Sidebar Journal Images don't work with pdf-only journal-entrys

Module Version: v1.8.20

To Reproduce
Steps to reproduce the behavior:

1. Create a Journal-Entry which contains only a single PDF
2. View Journal Entrys overview
3. see the thumbnail showing as broken

Expected behavior
Create a thumbnail from the first PDF-Page or don't show thumbnails for pdfs at all.

Screenshots

Browser:
Foundry native and Chrome.

Foundry Version:
V10.288

[Feature request][Auto assigned] Have a pin with text name not tied to a Journal entry.

[BUG]Module.json links to wrong repository.

Module Version: v1.8.1

Describe the bug
Module.json provides links to the Variant Encumbrance Module

To Reproduce
Steps to reproduce the behavior:
Open module.json, see line 118 - 123

Expected behavior
Properly include Pin Cushion Links

Screenshots

Possibly related to #29

[BUG] Image do not show when there is no journal entry connected

Describe the bug
Linked Image do not show when there is no journal entry connected to map note. Also when try hover and see image (when there is no journal entry connected) something breaking, and until refresh-F5 images of others pins, which working before stop working.

Screenshots

Version:
Foundry v9 build 269
Pin-cushion v1.7.7

Text only as Pin

A big suggestion with 3 parts :

• Text as pin cushion (only text, no icon) using pin title
• Text streching using "Bézier curve" algorithm or others
• Priority layer to prevent multiple text overlapping interactions or text and icon overlapping interactions

Feature request: General support for page and header links

Core FoundryVTT v10 supports dropping header links inside journals and other text areas, but weirdly not for scene notes; Journal Anchor Links actually adds in this function. Would love to have the co-ability(?) for Pin Cushion's text preview to auto-scroll to linked headers.

[BUG] FVTT freezing when opening journals

Module Version: v1.8.20

Describe the bug
When I try to open a journal entry, it takes 20-30s for it to open up, freezing the rest of FVTT for the time. It only happens if Pin Cushion is enabled.

(no errors thrown into the console)

To Reproduce
Steps to reproduce the behavior:

1. Have Pin Cushion enabled
2. Click on a journal entry to open
3. FVTT freezes

Expected behavior
There should not be any significant delay or FVTT freeze.

Browser:
Chrome, Edge

Foundry Version:
10.290

Game System:
5E

[BUG] PDF-Thumbnails generate heavy traffic

Module Version: v1.8.22

Describe the bug
The fix for PDF thumbnails has an unpleasant side effect. If there are PDFs in the root directory, they are all reloaded every time a document is opened from the journal. This generates a lot of traffic and can put a lot of strain on weaker connections.

Expected behavior
Is it possible to create only a thumbnail of PDFs instead of loading the whole document? Then that would be the solution, otherwise it makes more sense to simply not create a thumbnail for PDFs.

Browser:
All

Foundry Version:
10.291

[BUG] No tooltip visible

Module Version: v1.8.24

Before open any issue
No debugging option in settings,
F12 shows no errors.

Describe the bug
No Tooltip when I hover mouse over note.

To Reproduce
Install module with default settings.
Hover mouse over note.

Expected behavior
See tooltip when mouse is hovering.

Chrome

Foundry Version:
v10 Build 291

Game System:
5E

[BUG][Self Assigned] Manage undefined, null value on note gm feature

[BUG] Entry Icon gets overwritten by the Journal Note Image

Module Version: v1.6.7

Describe the bug
When editing a Map Note, its image/icon gets overwritten by the Journal Note Image, no matter if you set a different Entry Icon.

To Reproduce

1. Create a Journal Note with text and image.
2. Put it on the scene
3. Change Entry Icon to something else, Update
4. Open it again, Update

bandicam.2022-05-23.09-38-11-890.mp4

Adding Levels/Categories to pins

A feature that I would love for managing my games would be, being able to set layer/levels/categories to pin. Such that you could then categorise them and select which ones you want to see. EG: Town pins, Hunting pins, Quest pins, and being able to hide the town and quest pins so you can just look at the hunting ones.
Thanks

Pin Cushion works in Foundry ver 10 if the module was installed with ver 9, but it can't been installed into a fresh v 10 install

Pin Cushion works with Foundry version 10 if the module was installed before updating to 10.
When I try to install Pin Cushion in a fresh install that has always been 10 I get the following error message
"Installation Failed: module pin-cushion version 1.7.1 requires an older version of . See the Console (F12) for more details."

[BUG] The Align to centre dose not work anymore as of latest foundry update

The Align to centre dose not work anymore as of latest foundry update

Edit after being placed

Maybe I am missing something.
But is there actually a way to edit the pin after it has been placed on the scene?
I can only double click to open the journal.
Would be nice to have a feature to right click and edit the cushion instead of deleting it and place a new one when you need to edit it.

[BUG] cannot read properties of undefined (reading 'toJSON')

Module Version: v1.8.0

Describe the bug
The marker on the map is not created and there is an error in the console

To Reproduce
Steps to reproduce the behavior:

1. double clic on the map
2. put a name at random and just clic save (chossing a folder end up with the same issue)

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Foundry Version:
v12 build 287

Centre text not being centre

when you set the text to centre it is not centre its left

[Translation] German Translation ready to be pulled

I just finished the German translation. In case you want to already incorporate it into another update,, you can force pull from weblate. Otherwise a pull request will be created after 24 hours. Cheers Mate and thank you for the fixes. Works like a charm now.

[Feature Request][Auto assigned] Configurable preview on a per-pin basis

It would be nice to configure for each individual pin whether the preview shows or not. In the Map Note Configuration screen there could be a checkbox that determines whether a preview is show for that individual map note.

Reference: death-save#10

[BUG] Error on opening any note sheet

Pin Cushion v1.8.23, foundry 10.291, pf2e 4.4.2

Getting this error any time I open the config sheet for a note:

commons.js:2192 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'cushionIcon')
[Detected 1 package: pin-cushion]
    at setProperty (commons.js:2192:16)
    at Object.fn (pin-cushion.js:223:2)
    at #call (foundry.js:724:20)
    at Hooks.callAll (foundry.js:681:17)
    at NoteConfig._render (foundry.js:5153:13)
    at async NoteConfig._render (foundry.js:5822:5)
setProperty @ commons.js:2192
(anonymous) @ pin-cushion.js:223
#call @ foundry.js:724
callAll @ foundry.js:681
_render @ foundry.js:5153
await in _render (async)
_render @ foundry.js:5822
render @ foundry.js:5067
render @ foundry.js:6394
_onClickRight2 @ foundry.js:25593
callback @ foundry.js:27813
_handleClickRight2 @ foundry.js:28107
_handleRightDown @ foundry.js:28069
a.emit @ index.js:181
r.dispatchEvent @ interaction.min.mjs:8
r.processPointerDown @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.findHit @ interaction.min.mjs:8
r.processInteractive @ interaction.min.mjs:8
r.onPointerDown @ interaction.min.mjs:8

Only dependencies and module management+ active. I've tried notes dragged from entries, created on the canvas, all seem to act the same. I can't actually find any functionality breaking? But I haven't played with it much, this was my first time using this module in earnest.

[BUG] Default Journal Entry Folder not respected

Module Version: v1.7.2
Foundry Version: v9 Build 269
Game System: D&D 5e 1.6.3

Describe the bug
The settings for default entry folder don't seem to work, when you configure the setting it's still adding notes to the root directory in the journal entries menu

To Reproduce
Steps to reproduce the behavior:

1. Configure 'Default Journal Entry Folder' to 'Specific Folder'
2. Configure 'Select Specific Folder' to 'My Test Folder'
3. Select Journal Notes, Select Notes, HUD option
4. Double click scene, 'Journal Entry Folder' states 'Specific Folder'
5. Save 'Create a Map Pin', save new 'Note' with 'Update Map Note'
6. In Journal Entries the journal is in the root directory, not 'My Test Folder'

Expected behavior

1. Configure 'Default Journal Entry Folder' to 'Specific Folder'
2. Configure 'Select Specific Folder' to 'My Test Folder'
3. Select Journal Notes, Select Notes, HUD option
4. Double click scene, 'Journal Entry Folder' states 'My Test Folder'
5. Save 'Create a Map Pin', save new 'Note' with 'Update Map Note'
6. In Journal Entries the journal is in the 'My Test Folder' directory

Browser:

• Firefox 103.0.1
• Chrome 104.0.5112.80

[BUG] Hovering over map pins too quickly with too low a delay breaks the hover feature

If you hover over map pins too quickly, it breaks the hover feature.

While testing settings to diagnose this and see if I could fix it, I figured out that it was due to the Preview Delay in Module Settings being set too low. Testing determined: 0ms caused it to break, 10ms caused it to break, 100ms did not cause it to break. I didn't test any other intervals.

Perhaps just add to the Preview Delay flavor text that setting the delay too low can cause the preview feature to stop working - I spent an hour trying to figure out what was happening and I'd like to spare anybody else the trouble.

[BUG] Missing Labels

Module Version: v1.5.14

Describe the bug
Labels are missing from pins. It seems to be connected to Backgroundless Pin option but I had the problem with a fresh install. Never had this problem with previous versions (<1.5.14)

To Reproduce
Steps to reproduce the behavior:

1. Turn on Pin Cushion on a new world
2. Put a pin
3. See that there is no label

Expected behavior
A label below pin

Screenshots

QUESTION: Install this version vs. wait for main branch merge?

Hi @ p4535992 I am one of the people that has been waiting for the main Death Save branch to merge your PR but I see this release here now. Guessing that this was released because the merge hasn't happened yet?

Does it matter whether I wait for the main branch or download this one? I'm assuming everything would be compatible as far as already placed pins but just want to verify before switching mods.

Thanks!

Unable to Install with Foundry V10

Unable to install with Foundry V10
Image provided is the error in the console

Install JSON errors with 404...

https://raw.githubusercontent.com/p4535992/foundryvtt-pin-cushion/master/module.json

Errors with a 404.

Doesn't download by either option

Cannot find "K" and the Manifest link does not wok either

[BUG] Default Journal Entry Permission not respected

Module Version: v1.7.2
Foundry Version: v9 Build 269
Game System: D&D 5e 1.6.3

Describe the bug
The setting for default journal entry permission doesn't seem to work, when you configure the setting it's still opening the creation menu defaulted to 'None'

This applies to all defeaults you may configure, I use 'Owner' as my example

To Reproduce
Steps to reproduce the behavior:

1. Configure 'Default Journal Entry Permission' to 'Owner'
2. Select Journal Notes, Select Notes, HUD option
3. Double click scene, 'Default Permission' states 'None'
4. Save 'Create a Map Pin', save new 'Note' with 'Update Map Note'
5. In Journal Entries the journal entry is configured with All Players permission as 'None' and the creator as 'Owner'

Expected behavior

1. Configure 'Default Journal Entry Permission' to 'Owner'
2. Select Journal Notes, Select Notes, HUD option
3. Double click scene, 'Default Permission' states 'Owner'
4. Save 'Create a Map Pin', save new 'Note' with 'Update Map Note'
5. In Journal Entries the journal entry is configured with All Players permission as 'Owner' and the creator as 'Owner'

Browser:

• Firefox 103.0.1
• Chrome 104.0.5112.80

Show Player Labaer name instead Journal entry name

Hey, Can you change or add option to show Player Label name instead Journal entry name above Image?
I mean instead "Fichetal | Warownia Fichetal" (this is Journal entry name) show "Warownia Fichetal" (Player Label name)

[BUG] Unable to create new pins

Pin Cushion v.1.8.24, foundry 10.291, pf2e 4.4.2.

Pins which existed previously all open fine, but adding new pins, dropping in from journals, etc. all throw this error and revert to the default map pin menu:

commons.js:2182 Uncaught (in promise) TypeError: key.indexOf is not a function
[Detected 1 package: pin-cushion]
    at setProperty (commons.js:2182:14)
    at Object.fn (pin-cushion.js:184:9)
    at #call (foundry.js:724:20)
    at Hooks.callAll (foundry.js:681:17)
    at NoteConfig._render (foundry.js:5153:13)
    at async NoteConfig._render (foundry.js:5822:5)
setProperty @ commons.js:2182
(anonymous) @ pin-cushion.js:184
#call @ foundry.js:724
callAll @ foundry.js:681
_render @ foundry.js:5153
await in _render (async)
_render @ foundry.js:5822
render @ foundry.js:5067
render @ foundry.js:6394
_createPreview @ foundry.js:31301
await in _createPreview (async)
🎁call_wrapped @ libWrapper-wrapper.js:507
notesCreatePreview @ monks-enhanced-journal.js:1053
🎁call_wrapper @ libWrapper-wrapper.js:616
🎁NotesLayer.prototype._createPreview#0 @ libWrapper-wrapper.js:189
_onDropData @ foundry.js:36329
await in _onDropData (async)
_onDrop @ foundry.js:24691
handleDrop @ dragupload.js:144
callback @ foundry.js:56837
_handleDrop @ foundry.js:56888

[BUG] Compatability Issue w/Simple Calendar

Have discovered a compatibility issue with Simple Calendar when adding notes or deleting them in Simple Calendar the Foundry interface becomes unresponsive without throwing any console errors. Not sure if you would need to make changes to remediate this issue or if this would have to be resolved by the Simple Calendar dev (have informed him of the issue too).

vigoren/foundryvtt-simple-calendar#419

[BUG]Width to Size Ratio breaks Scene and makes it not load if a value larger than 1 is put in.

Module Version: v1.8.1

Describe the bug
When creating or editing a map note, the width to size ratio option creates an error if a value greater than 1 is used.
This error prevents a scene from loading on refresh/restart of Foundry VTT.

To Reproduce
Steps to reproduce the behavior:

1. Go to the 'Add Journal Entry to a Scene'
2. Edit the 'Width to Size Ratio' option to a value larger than 1
3. Click 'Update Map Note'
4. See error and the note itself vanishing from sight.

Additionally:

1. Press F5 to refresh.
2. See error

Expected behavior
No Scene Breaking behavior and/or a fail-save that prevents faulty input numbers.

Screenshots

1. 
2. 
3. 

Browser:
Foundry Desktop Client

Additional context

Am I correct in assuming, that this setting is used to make the used icon not square, but for example a rectangle? If so, this function is not working at all, also with values below 1 (no breaking error occurs in this case)
Screenshot Nr. 3 shows an error that occurs on hover, mentioning deprecated dependencies.

[BUG]Unable to install Latest 1.5.11 or Master

Module Version: v1.5.11 and v1.5.12

Describe the bug
Attempting to follow the instructions in the readme to install the latest version give the error that zip is not found for 1.5.12 using this as the Manifest URL:
https://raw.githubusercontent.com/p4535992/pin-cushion/master/module-dev.json

Attempting to install 1.5.11 "Stable" from here using this as the Manifst URL:
https://github.com/p4535992/pin-cushion/releases/tag/v1.5.11/module.json
In that case it indicates that does not provide a manifest file?

I've never installed modules this way before I always use those in the UI/UX; perhaps I'm doing something wrong?

Expected behavior
Module should install.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser:
Chrome Latest

Foundry Version:
0.9 Build 255

Game System:
5E

Additional context
Add any other context (like other modules installed) about the problem here.

Icon Selector Replacement Options

Would it be possible to configure the access to the Icon Selector?

Currently Players, even if they have no file browser access, are presented with the new file browser option which they cannot access.

I suppose the ideal would be anything without file browser access is given the default drop-down menu, whereas others are given the selector?

Modify Icon Size below 32px

There are times when an icon for the pin needs to be smaller. Please remove the restrictions and instead replace w/ a warning if preferred.

Remove preview for specific journals and preview position

Issue 1: Remove preview for specific journals when global "Show Journal Preview" is ON

It seems there is no way to have only the label (not the preview) as a GM when enabling the option "Show Journal Preview" in the Settings. I would like to keep Journal Preview ON for most scenes but for a few others I don't want this option enabled. It would be great to have an option to remove the preview for an individual journal or a folder of journals, even as a GM.

Issue 2: Change position of the previews

Also, is there a way to move a preview so that it is not over the icon? Maybe a bit more to the right? Or give the option to choose the preview's position.

Example of both issues below

Thank you

Thank you so much for supporting this tool. It's really useful!

[Feature Request][Auto Assigned] Toggle Show Players option?

Reference : https://www.reddit.com/r/FoundryVTT/comments/ve256c/pf2e_toggle_show_players_option/

I am having an issue with the Journals that have the Show Players option. It seems that it will automatically show the players if you accidentally click it which is really annoying.

Is there a way to toggle a confirmation to Show Players so it asks if "you're sure you want to Show Players?"

Bring back module setting 'enableBackgroundlessPins'

Being able to customise the background individually on each pin is a good thing. But the problem is that after a recent upgrade from 1.5.0 to the latest version of this fork, which is now offered as the main one when updating the module in Foundry, ABSOLUTELY ALL my pins have turned into a piece of crap. And the thing is, I had taken the default background into account beforehand, and this module decided to disable the background everywhere for me. This is the greatest problem, as I now have to manually redo over a thousand pins.

Pin Cushion 1.7 broke "Do not show Journal Preview"

Since updating to version 1.7, all journal entries with "Do not show Journal Preview" checked are acting as if they are unchecked. The only way to fix this is to go into every journal icon and unclick and re-click it. For those of us with hundreds of journal entries, this is going to take forever to fix.

Always (when hover) show name of pin up (above) to others pin

Hey, I just update from 1.5.0 to 1.7.2
Is any way to always when hover show name of pin up (above) to others pin? (see image). For now, which image is up (above) is based on date of creation, so old pin go back, like in this case.

Pathfinder Second Edition Functionality

I was wondering if it would be possible to add functioning buttons (like the button links to character sheets and conditions pictured in the second image) for three PF2 journal functionalities that are explained here:
https://github.com/foundryvtt/pf2e/wiki/Style-Guide

Namely the Rolls, Saving Throws and Templates.

(Image 1) Currently, using rolls in a journal pin results in [object Promise] being displayed instead of either the button or the text.

(Image 2) Trying to display the Saving Throws or Templates results in their plain text being displayed instead of their buttons.

Forge : last v9 compatible version appears to be 1.7.11, not 1.8.0

My Foundry is hosted on The Forge. There, I can update to 1.8.0, but when I do, the module cannot be activated in the game (it does not even appear in the Modules tab). 1.7.11 still works fine.

Thank you!

[BUG] Tooltip shows journal's first page contents, regardless of which page the note is for.

Module Version: v1.8.10

The tooltip of a map note shows the title of the entire journal and the text of the first page in the journal entry, not the contents of the linked page.

To Reproduce
Steps to reproduce the behavior:

1. Create a journal entry
2. Add a page, make it's contents "A"
3. Add a page, make it's contents "B"
4. Drag and drop the first page onto the canvas.
5. Drag and drop the second page onto the canvas.
6. Open the Pin Cushion settings for each page and uncheck "Do not show Journal Preview"
7. Hover the mouse over each page until the tooltip is observed. Both tooltips will show "A"

Expected behavior
The first page's map note's tooltip is "A", and the second page's is "B".

Screenshots

Browser:

• Chrome

Foundry Version: 10.288

Game System: DnD5e v2.0.3

---

As a total aside, the bug template tells people to enable debugging in the module settings, but that's not an option in this module.