p4535992 / foundryvtt-pin-cushion Goto Github PK
View Code? Open in Web Editor NEWThis project forked from death-save/pin-cushion
Adds additional functionality around Map Pins
License: GNU General Public License v3.0
This project forked from death-save/pin-cushion
Adds additional functionality around Map Pins
License: GNU General Public License v3.0
Hey, I just saw that you are the creator of the Pin Cushion module. I totaly love it and I wondered if there will be an v10 update. The most important feature for me would be to hide the pin background. Also very useful would be if you could change the size of the pin to create rectangles
From: Mugglemage on discotd
Module Version: v1.8.10
The tooltip of a map note shows the title of the entire journal and the text of the first page in the journal entry, not the contents of the linked page.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The first page's map note's tooltip is "A", and the second page's is "B".
Browser:
Foundry Version: 10.288
Game System: DnD5e v2.0.3
As a total aside, the bug template tells people to enable debugging in the module settings, but that's not an option in this module.
Module Version: v1.8.24
Before open any issue
No debugging option in settings,
F12 shows no errors.
Describe the bug
No Tooltip when I hover mouse over note.
To Reproduce
Install module with default settings.
Hover mouse over note.
Expected behavior
See tooltip when mouse is hovering.
Chrome
Foundry Version:
v10 Build 291
Game System:
5E
Reference : https://www.reddit.com/r/FoundryVTT/comments/ve256c/pf2e_toggle_show_players_option/
I am having an issue with the Journals that have the Show Players option. It seems that it will automatically show the players if you accidentally click it which is really annoying.
Is there a way to toggle a confirmation to Show Players so it asks if "you're sure you want to Show Players?"
Module Version: v1.7.5
Before open any issue
Describe the bug
https://discord.com/channels/170995199584108546/722566083499786352/1010209403007418438
When the module "Pin cushion" is enabled then pressing ALT does not reveal all notes labels anymore. Instead there seems to be a maximum and every time you press alt it cycles through other labels being displayed. Also happens with all other modules disabled.
To Reproduce
Expected behavior
Screenshots
Browser:
Foundry Version:
Game System:
Additional context
Module Version: v1.7.2
Foundry Version: v9 Build 269
Game System: D&D 5e 1.6.3
Describe the bug
The settings for default entry folder don't seem to work, when you configure the setting it's still adding notes to the root directory in the journal entries menu
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Browser:
Maybe I am missing something.
But is there actually a way to edit the pin after it has been placed on the scene?
I can only double click to open the journal.
Would be nice to have a feature to right click and edit the cushion instead of deleting it and place a new one when you need to edit it.
Maybe I should file this under bug, but I would like to be able to right-click and "jump to pin" from the journal tab. Unfortunately, notes created with Pin Cushion do not offer this option.
Thanks!
It seems there is no way to have only the label (not the preview) as a GM when enabling the option "Show Journal Preview" in the Settings. I would like to keep Journal Preview ON for most scenes but for a few others I don't want this option enabled. It would be great to have an option to remove the preview for an individual journal or a folder of journals, even as a GM.
Also, is there a way to move a preview so that it is not over the icon? Maybe a bit more to the right? Or give the option to choose the preview's position.
Thank you so much for supporting this tool. It's really useful!
Module Version: v1.8.20
Describe the bug
When I try to open a journal entry, it takes 20-30s for it to open up, freezing the rest of FVTT for the time. It only happens if Pin Cushion is enabled.
(no errors thrown into the console)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
There should not be any significant delay or FVTT freeze.
Browser:
Chrome, Edge
Foundry Version:
10.290
Game System:
5E
Module Version: v1.8.20
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Create a thumbnail from the first PDF-Page or don't show thumbnails for pdfs at all.
Screenshots
Browser:
Foundry native and Chrome.
Foundry Version:
V10.288
Cannot find "K" and the Manifest link does not wok either
Since updating to version 1.7, all journal entries with "Do not show Journal Preview" checked are acting as if they are unchecked. The only way to fix this is to go into every journal icon and unclick and re-click it. For those of us with hundreds of journal entries, this is going to take forever to fix.
My Foundry is hosted on The Forge. There, I can update to 1.8.0, but when I do, the module cannot be activated in the game (it does not even appear in the Modules tab). 1.7.11 still works fine.
Thank you!
when you set the text to centre it is not centre its left
Pin Cushion works with Foundry version 10 if the module was installed before updating to 10.
When I try to install Pin Cushion in a fresh install that has always been 10 I get the following error message
"Installation Failed: module pin-cushion version 1.7.1 requires an older version of . See the Console (F12) for more details."
I was wondering if it would be possible to add functioning buttons (like the button links to character sheets and conditions pictured in the second image) for three PF2 journal functionalities that are explained here:
https://github.com/foundryvtt/pf2e/wiki/Style-Guide
Namely the Rolls, Saving Throws and Templates.
(Image 1) Currently, using rolls in a journal pin results in [object Promise] being displayed instead of either the button or the text.
(Image 2) Trying to display the Saving Throws or Templates results in their plain text being displayed instead of their buttons.
Module Version: v1.8.0
Describe the bug
The marker on the map is not created and there is an error in the console
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Foundry Version:
v12 build 287
The chat room will slide about 1/4th of the way to the left whenever you right click a Journal Entry on the map. Right clicking off of it restores it, however, I am using this module in conjunction with Multilevel Tokens and Point of Interest Teleporter to use Journal Entries to jump to other maps. When I do so, the shifting of the chat room remains permanent.
Module Version: v1.8.22
Describe the bug
The fix for PDF thumbnails has an unpleasant side effect. If there are PDFs in the root directory, they are all reloaded every time a document is opened from the journal. This generates a lot of traffic and can put a lot of strain on weaker connections.
Expected behavior
Is it possible to create only a thumbnail of PDFs instead of loading the whole document? Then that would be the solution, otherwise it makes more sense to simply not create a thumbnail for PDFs.
Browser:
All
Foundry Version:
10.291
A feature that I would love for managing my games would be, being able to set layer/levels/categories to pin. Such that you could then categorise them and select which ones you want to see. EG: Town pins, Hunting pins, Quest pins, and being able to hide the town and quest pins so you can just look at the hunting ones.
Thanks
Module Version: v1.5.11 and v1.5.12
Describe the bug
Attempting to follow the instructions in the readme to install the latest version give the error that zip is not found for 1.5.12 using this as the Manifest URL:
https://raw.githubusercontent.com/p4535992/pin-cushion/master/module-dev.json
Attempting to install 1.5.11 "Stable" from here using this as the Manifst URL:
https://github.com/p4535992/pin-cushion/releases/tag/v1.5.11/module.json
In that case it indicates that does not provide a manifest file?
I've never installed modules this way before I always use those in the UI/UX; perhaps I'm doing something wrong?
Expected behavior
Module should install.
Screenshots
If applicable, add screenshots to help explain your problem.
Browser:
Chrome Latest
Foundry Version:
0.9 Build 255
Game System:
5E
Additional context
Add any other context (like other modules installed) about the problem here.
If you hover over map pins too quickly, it breaks the hover feature.
While testing settings to diagnose this and see if I could fix it, I figured out that it was due to the Preview Delay in Module Settings being set too low. Testing determined: 0ms caused it to break, 10ms caused it to break, 100ms did not cause it to break. I didn't test any other intervals.
Perhaps just add to the Preview Delay flavor text that setting the delay too low can cause the preview feature to stop working - I spent an hour trying to figure out what was happening and I'd like to spare anybody else the trouble.
I just finished the German translation. In case you want to already incorporate it into another update,, you can force pull from weblate. Otherwise a pull request will be created after 24 hours. Cheers Mate and thank you for the fixes. Works like a charm now.
There are times when an icon for the pin needs to be smaller. Please remove the restrictions and instead replace w/ a warning if preferred.
Have discovered a compatibility issue with Simple Calendar when adding notes or deleting them in Simple Calendar the Foundry interface becomes unresponsive without throwing any console errors. Not sure if you would need to make changes to remediate this issue or if this would have to be resolved by the Simple Calendar dev (have informed him of the issue too).
The Align to centre dose not work anymore as of latest foundry update
Module Version: v1.8.1
Describe the bug
When creating or editing a map note, the width to size ratio option creates an error if a value greater than 1 is used.
This error prevents a scene from loading on refresh/restart of Foundry VTT.
To Reproduce
Steps to reproduce the behavior:
Additionally:
Expected behavior
No Scene Breaking behavior and/or a fail-save that prevents faulty input numbers.
Screenshots
Browser:
Foundry Desktop Client
Additional context
Am I correct in assuming, that this setting is used to make the used icon not square, but for example a rectangle? If so, this function is not working at all, also with values below 1 (no breaking error occurs in this case)
Screenshot Nr. 3 shows an error that occurs on hover, mentioning deprecated dependencies.
Core FoundryVTT v10 supports dropping header links inside journals and other text areas, but weirdly not for scene notes; Journal Anchor Links actually adds in this function. Would love to have the co-ability(?) for Pin Cushion's text preview to auto-scroll to linked headers.
Hi @ p4535992 I am one of the people that has been waiting for the main Death Save branch to merge your PR but I see this release here now. Guessing that this was released because the merge hasn't happened yet?
Does it matter whether I wait for the main branch or download this one? I'm assuming everything would be compatible as far as already placed pins but just want to verify before switching mods.
Thanks!
Being able to customise the background individually on each pin is a good thing. But the problem is that after a recent upgrade from 1.5.0 to the latest version of this fork, which is now offered as the main one when updating the module in Foundry, ABSOLUTELY ALL my pins have turned into a piece of crap. And the thing is, I had taken the default background into account beforehand, and this module decided to disable the background everywhere for me. This is the greatest problem, as I now have to manually redo over a thousand pins.
Module Version: v1.5.14
Describe the bug
Labels are missing from pins. It seems to be connected to Backgroundless Pin option but I had the problem with a fresh install. Never had this problem with previous versions (<1.5.14)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A label below pin
Hi,
using the newest module version and the current stable foundry v10. When enabling the module option "Enable revealed state on scene notes" and refreshing no scene will load anymore, only with a black screen. The error "Canvas drawing failed: PIN_IS_REVEALED is not defined" pops up.
Pin Cushion v1.8.23, foundry 10.291, pf2e 4.4.2
Getting this error any time I open the config sheet for a note:
commons.js:2192 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'cushionIcon')
[Detected 1 package: pin-cushion]
at setProperty (commons.js:2192:16)
at Object.fn (pin-cushion.js:223:2)
at #call (foundry.js:724:20)
at Hooks.callAll (foundry.js:681:17)
at NoteConfig._render (foundry.js:5153:13)
at async NoteConfig._render (foundry.js:5822:5)
setProperty @ commons.js:2192
(anonymous) @ pin-cushion.js:223
#call @ foundry.js:724
callAll @ foundry.js:681
_render @ foundry.js:5153
await in _render (async)
_render @ foundry.js:5822
render @ foundry.js:5067
render @ foundry.js:6394
_onClickRight2 @ foundry.js:25593
callback @ foundry.js:27813
_handleClickRight2 @ foundry.js:28107
_handleRightDown @ foundry.js:28069
a.emit @ index.js:181
r.dispatchEvent @ interaction.min.mjs:8
r.processPointerDown @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.recursiveFindHit @ interaction.min.mjs:8
t.findHit @ interaction.min.mjs:8
r.processInteractive @ interaction.min.mjs:8
r.onPointerDown @ interaction.min.mjs:8
Only dependencies and module management+ active. I've tried notes dragged from entries, created on the canvas, all seem to act the same. I can't actually find any functionality breaking? But I haven't played with it much, this was my first time using this module in earnest.
It would be nice to configure for each individual pin whether the preview shows or not. In the Map Note Configuration screen there could be a checkbox that determines whether a preview is show for that individual map note.
Reference: death-save#10
Module Version: v1.7.2
Foundry Version: v9 Build 269
Game System: D&D 5e 1.6.3
Describe the bug
The setting for default journal entry permission doesn't seem to work, when you configure the setting it's still opening the creation menu defaulted to 'None'
This applies to all defeaults you may configure, I use 'Owner' as my example
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Browser:
Would it be possible to configure the access to the Icon Selector?
Currently Players, even if they have no file browser access, are presented with the new file browser option which they cannot access.
I suppose the ideal would be anything without file browser access is given the default drop-down menu, whereas others are given the selector?
Describe the bug
Linked Image do not show when there is no journal entry connected to map note. Also when try hover and see image (when there is no journal entry connected) something breaking, and until refresh-F5 images of others pins, which working before stop working.
Version:
Foundry v9 build 269
Pin-cushion v1.7.7
I am allowing players to set pins in our PF2 Abomination Vault to identify dangerous locations, sounds and tracks of enemies, so we reached the limits of the current features of Foundry V10 and PinCushion so I need few additional features to remove the need to always go after player pins after the session and fix them manually.
Module Version: v1.8.1
Describe the bug
Module.json provides links to the Variant Encumbrance Module
To Reproduce
Steps to reproduce the behavior:
Open module.json, see line 118 - 123
Expected behavior
Properly include Pin Cushion Links
Possibly related to #29
Module Version: v1.6.7
Describe the bug
When editing a Map Note, its image/icon gets overwritten by the Journal Note Image, no matter if you set a different Entry Icon.
To Reproduce
The ability to use images as icons has opened up new use cases, unfortunately, the images are either distorted into squares or, if using the Width to Size ratio, wide rectangles (wider than they are tall).
I have a use case where I would prefer to use tall rectangles, example: a 200 x 400 image. Turning the images into squares with a transparent background is a simple stop-gap; however, in the long-term, I would like to see Pin Cushion support fractions in the Width to Size Ratio field.
For example, if I want to use a 200x400 image, I could simply enter 0.5 in the Width to Size Ratio field and 400 in the Icon Size field.
Pin Cushion v.1.8.24, foundry 10.291, pf2e 4.4.2.
Pins which existed previously all open fine, but adding new pins, dropping in from journals, etc. all throw this error and revert to the default map pin menu:
commons.js:2182 Uncaught (in promise) TypeError: key.indexOf is not a function
[Detected 1 package: pin-cushion]
at setProperty (commons.js:2182:14)
at Object.fn (pin-cushion.js:184:9)
at #call (foundry.js:724:20)
at Hooks.callAll (foundry.js:681:17)
at NoteConfig._render (foundry.js:5153:13)
at async NoteConfig._render (foundry.js:5822:5)
setProperty @ commons.js:2182
(anonymous) @ pin-cushion.js:184
#call @ foundry.js:724
callAll @ foundry.js:681
_render @ foundry.js:5153
await in _render (async)
_render @ foundry.js:5822
render @ foundry.js:5067
render @ foundry.js:6394
_createPreview @ foundry.js:31301
await in _createPreview (async)
🎁call_wrapped @ libWrapper-wrapper.js:507
notesCreatePreview @ monks-enhanced-journal.js:1053
🎁call_wrapper @ libWrapper-wrapper.js:616
🎁NotesLayer.prototype._createPreview#0 @ libWrapper-wrapper.js:189
_onDropData @ foundry.js:36329
await in _onDropData (async)
_onDrop @ foundry.js:24691
handleDrop @ dragupload.js:144
callback @ foundry.js:56837
_handleDrop @ foundry.js:56888
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.