howto set CA to trust, or set tls options

[palantir]

howto set CA to trust, or set tls options

[davidkarlsen]

Seems like I can hook in with WithClientMiddleware - can I return my own configured transport from this function?

[bluekeyes]

This is not currently supported (other than via system wide mechanisms like SSL_CERT_FILE and SSL_CERT_DIR), but I agree that it makes sense. In #92, we discussed adding a WithHTTPClient option, but ended up not needing it for the feature there. This seems like a good justification for adding one (or a more limited WithTLSConfig.)

While you could maybe work around this using WithClientMiddleware, you'll have to be careful to still delegate to the incoming http.RoundTripper. If you return your own configured transport and ignore the input, you'll remove the GitHub authentication and other helpers provided by this library.

I might have some time today to add the mentioned option function.

[davidkarlsen]

This is not currently supported (other than via system wide mechanisms like SSL_CERT_FILE and SSL_CERT_DIR), but I agree that it makes sense. In #92, we discussed adding a WithHTTPClient option, but ended up not needing it for the feature there. This seems like a good justification for adding one (or a more limited WithTLSConfig.)

withTlsConfig would suffice and makes sense, it also leaves things better encapsulated than messing around and the comms-level which feels a bit low.

While you could maybe work around this using WithClientMiddleware, you'll have to be careful to still delegate to the incoming http.RoundTripper. If you return your own configured transport and ignore the input, you'll remove the GitHub authentication and other helpers provided by this library.

I might have some time today to add the mentioned option function.

That would be awesome and highly appreciated.