Pass token to net/http for asset download

[palantir]

Pass token to net/http for asset download

[jamestoyer]

@lukehinds have you tried client.Client()? This should return you an instance of the underlying HTTP client with the correct middleware to do an authenticated request.

[lukehinds]

Hey @jamestoyer , nice tip off, but it seems no dice.

clientConnection := client.Client()
resp, _ := clientConnection.Get(downloadURL)
fmt.Println("Status: ", resp.StatusCode)

This gives me a 404 Not Found. I know the asset is there though, as when I change the repo from private to public, I can access the release asset with no problem.

[jamestoyer]

I guess I'm a little confused as to why you're trying to use the browser_download_url. I suspect the reason this is failing when it's private is that it doesn't actually understand the auth tokens and probably only understands cookie auth.

[lukehinds]

Yes, I agree, this is confusing on my part.

Tokens only work with https://api.github.com not https://github.com/owner/repo/releases/download/

Butbrowser_download_url is the only direct access that GitHub provides to retrieve a release asset.

Sorry about the noise here, but seems this is an invalid / outside issue. I need to dig into githubs API a bit more.

[lukehinds]

A bit further along, turns out you need an Accept header of application/octet-stream and if you do, GitHub redirects (and gives your actual file).

I found this out by debugging with curl, with the -L flag, you don't get the file. I just need to figure out how to wire in http.Client.CheckRedirect now

Sorry for the noise again, I will make sure I close this, but I figure it might be of use to someone in the future.

[lukehinds]

Right, a little more digging reveals that there is a DownloadReleaseAsset which can handle GitHubs redirect.

I need to figure out how to populate an accept application/octet-stream into client.Client()