Giter Site home page Giter Site logo

Comments (2)

bluekeyes avatar bluekeyes commented on May 30, 2024

This sounds like something we can add. I think it hasn't come up before because the existing strategy works as long as any reverse proxies preserve (or set) the Host header, which is the configuration we always use and seems to be common for other users.

I should be able to put something together in a few days or I'm happy to review a PR if you'd like to contribute this.

from go-githubapp.

steebchen avatar steebchen commented on May 30, 2024

Sounds good, in my case I'm using a different URL just for testing purposes, I guess I wouldn't have this problem in prod with a proper setup, but I do in my testing case.

My fix is basically this:

#176

So now I can do this

return oauth2.NewHandler(
	oauth2.GetConfig(config.Config.Github, []string{"user:email"}),
	oauth2.SetRedirectURI(getRedirectURI()),
	// ...
)

However, I'm not sure if this would break existing applications if for some reason the redirectURL would be set already, but I wouldn't know where it would.

from go-githubapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.