Comments (2)
This sounds like something we can add. I think it hasn't come up before because the existing strategy works as long as any reverse proxies preserve (or set) the Host
header, which is the configuration we always use and seems to be common for other users.
I should be able to put something together in a few days or I'm happy to review a PR if you'd like to contribute this.
from go-githubapp.
Sounds good, in my case I'm using a different URL just for testing purposes, I guess I wouldn't have this problem in prod with a proper setup, but I do in my testing case.
My fix is basically this:
So now I can do this
return oauth2.NewHandler(
oauth2.GetConfig(config.Config.Github, []string{"user:email"}),
oauth2.SetRedirectURI(getRedirectURI()),
// ...
)
However, I'm not sure if this would break existing applications if for some reason the redirectURL would be set already, but I wouldn't know where it would.
from go-githubapp.
Related Issues (20)
- howto set CA to trust, or set tls options HOT 3
- Upgrade to v2 of github.com/alexedwards/scs HOT 7
- can't use app authentication with v4 client HOT 6
- Context Deadline Exceeded in Google Cloud Run HOT 4
- avoid jwt-go HOT 3
- Consider defining new module in `example` package HOT 1
- Exposing metrics via HTTP HOT 2
- 404 page not found HOT 2
- Example app clarification HOT 4
- PR #212 has broken the example code HOT 3
- Pass token to net/http for asset download HOT 6
- Errors loading config larger than 1MB HOT 2
- Capture stack traces for recovered handler panics
- Add GraphQL query logging middleware
- Emit metrics for async webhook processing errors
- Duplicate request with same delivery ID HOT 2
- Upgrade to be compatible with github.com/google/go-github/v33 HOT 1
- PrepareRepoContext should take an interface
- Updating to go-github/v38/github HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-githubapp.