FR: Handle approvals embedded in GHE review comments

[palantir]

FR: Handle approvals embedded in GHE review comments

[bluekeyes]

We see this occasionally with users who are less familiar with GitHub and accidentally leave a "comment" review (instead of an "approve" review) with ":+1:" as the text of the comment and are then confused about why their comment wasn't counted by policy-bot.

As you said, because supporting this is redundant and encourages "bad" habits with GitHub, we haven't implemented it yet, but it happens enough in our environment that it was worth tracking in an issue.

[NargiT]

IMHO It's redundant to look to the comment of a github approval, by definition when it is approved, the PR is validated. Do you have a use case ?

[jgiannuzzi]

This also happens quite a bit in our organization, where users will be in the "Files changed" tab of the PR and leave a review comment (thus not an approval or a request for change). This seems natural to them as they assume it's essentially the same as a regular comment. It also makes sense to them to leave the comment right there instead of switching back to the "Conversation" tab after reviewing the changes.

I think that adding matching review comments (again, not approvals or requests for changes) to the candidates would be a nice improvement. To be clear, I am talking about the body field of PullRequestReview objects whose state field has the value COMMENTED. Review comments on specific code lines would thus not be considered.

If you agree, I am willing to submit a PR implementing this.

[bluekeyes]

@jgiannuzzi that sounds reasonable to me, if you'd like to submit a PR. For the implementation, I think you'll want to include these in the return frompull.Context#Comments(). Once there, everything else should work without changes. I can't think of a reason why we'd want to treat these differently from regular comments.

[jgiannuzzi]

Thanks for the tip, @bluekeyes! I have submitted a PR with your suggested implementation.