patschke/xwing

Squad builder for the X-Wing Miniatures game by Fantasy Flight Games.

xwing's Issues

Conflicting pilots

Hi Patschke, looks like there is still an issue with the Xi-shuttle quickbuild, I think it's because Commander Malarus is a Tie/FO pilot a Xi-shuttle pilot and a crew card. If you pick the Xi-shuttle then change to say First order courier then change back to Commander Malarus she's gone from being in a Xi-shuttle to a Tie/FO.

German ship names are added to french translations

Although french names are correctly used in the exportObj.renameShip part, german names are used in the pilot_translations part:

    "Academy Pilot":
       name: """Pilote de l'Académie"""
       ship: """TIE/ln-Jäger"""

Here, ship value should be """Chasseur TIE"""

Apostrophe problem when translating to french

French uses a lot of apostrophe character and this breaks the translations. One example, the « Attack Shuttle » translates to « Navette d’attaque » so this happens:

    exportObj.renameShip 'Attack Shuttle', 'Navette d'Attaque'

French string should be escaped like 'Navette d\’attaque'.

Also, not sure if this is related but some pilot names get strange quotes like:

'"Wampa"':
   name: '"""Wampa"'""

JSON Downloader error

I think I don’t need this right now as there is already a api_export_fr.json but I gave it a try anyway.

Running python3 jsonDownloader.py fr gets me this error:

Traceback (most recent call last):
  File "jsonDownloader.py", line 4, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

Looks to me that they are some dependency missing. Again I don’t speak python fluently so please excuse me if I missed some obvious step.

OAuth not working for App

Currently OAuth is not working for the App version of YASB. If I am able to resolve this, I may publish it. The main problem is, that OAuth is unable to redirect to the app. The Browser will open, sending you to your Identity provider, but will not get back to the App.

One might try to resolve this using these ideas: https://www.oauth.com/oauth2-servers/redirect-uris/redirect-uris-native-apps/
The App registers the URI scheme yasb://

Autoformat: Translate.py

Can we agree on a style for the Python file? Any style is okay for me, but every time I auto format the code by force of habit I create a thousand changes in the document. I have no problem adjusting my auto format to whatever we decide on, but I don't think anything is decided there - sometimes there is a space after a comma, sometimes there isn't. Sometimes there are spaces arount %, sometimes there isn't.

I know, it's minor, but since it's your project I wouldn't want to just use my auto format on your code and force you to adjust yours ;)

Phrase translation

Phrase translations are difficult in french without the context (spelling may varies depending on the context). The only help I can get is the german translations and unfortunately I didn’t practice german a lot since high school :) although it helped me guess that « SMALL » should be translated to « Vaisseau petit » and not « petit ». Maybe adding the english translations or even better, some comments to provide context would help?