Play on Sound with unfinished preload leads to an additional preload call ending in a double buffer assignment

[takerukoushirou]

Play on Sound with unfinished preload leads to an additional preload call ending in a double buffer assignment

[bigtimebuddy]

Oh good catch! Yeah the play should probably wait for the initial preload instead of kicking off another request.

[takerukoushirou]

I ran into this as I wanted to defer loading additional bgm tracks as much as possible, but especially for the first track this ends up in a sequence of creating a Sound object with preload property set to true and a call to Sound.play() pretty much immediately afterwards. At first I thought I oversaw something in the documentation 😄

To circumvent the issue I now check whether the track media is already loaded and if not defer the Sound.play() call to the loaded callback.

Some ideas for the fix: Both IMedia implementations seem to be designed for one fixed asset (associated to a single Sound instance) and as such calling IMedia.load() more than once could be ignored (leaving the question how to deal with the additional callback) or probably better lead to an error due to invalid usage.
Sound should probably either way check whether media is already loading and skip another load call if it's the case. For that Sound._preload() may be the place to check that and skip another media load call, but it should keep track of the additional optional loaded callback for consistency.

[bigtimebuddy]

Seems like you've already dug into the source on this one. If you want to make a PR, happy to see it. We are doing more work in the PixiJS main project, so I likely won't be able to address this right away.

[takerukoushirou]

I can try, will probably take a few days to find some time though, too.
The initial error backtrace was in this case little helpful, so I went through the code when I tried to figure out what's going on.