Comments (17)
Thanks a lot for reporting this, yes they should be the same. Fortunately the error was only in the reporting, and shouldn't have affected the doublet scores.
It error should be fixed now on the github version (would be happy if you could confirm with your dataset), and I'll push it to Bioc devel once the checks have passed.
from scdblfinder.
Hi @Yunuuuu ,
could you confirm that this solved your problem? Will close the issue if there's no answer.
Pierre-Luc
from scdblfinder.
Hi, I downloaded the latest plger/scDblFinder using pak::pkg_install and restart R, it remains here:
from scdblfinder.
I checked the source code of scDblFindeer
function, which indicates this has been modified:
from scdblfinder.
I try to understand the code, but I'm not familiar with the internal function:
when samples
is not NULL and returnType
is "sce" or "full", following code won't run in scDblFinder
funtion:
if (returnType == "counts") {
for (s in names(d)) d[[s]]$sample <- s
return(do.call(cbind, d))
}
from scdblfinder.
You're absolutely right, I did this too quickly... should hopefully be fixed for real in the latest push :)
from scdblfinder.
@Yunuuuu , hopefully everything is as expected now?
from scdblfinder.
I'll try this again @plger
from scdblfinder.
the package GithubSHA1 is here:
from scdblfinder.
Thanks for the development of this package @plger, I'll do more test this weekend, I cannot find what's wrong now
from scdblfinder.
Hi @Yunuuuu , okay now I don't get why you're having this problem, as I can't reproduce it with my toy data. Could you share a minimal example, e.g. SCE with only count matrix and sample id, only 2-300 genes, perhaps subsampling the cells? (you can rename genes & remove other cell metadata if you're worried about the data)
from scdblfinder.
Is there any method to share rds data ?
from scdblfinder.
You can email it to [email protected]
if it's <20mb, otherwise if you don't have a platform for sharing of larger files you can write me an email and I'll send you some details.
Thanks!
from scdblfinder.
hi, I have uploaded it to the Google Drive,and the link has been emailed to [email protected]
. I can confirm this data can induce the problem. Thanks!
[R]> set.seed(221113L)
[R]> anyDuplicated(colnames(test_data))
[1] 3466
[R]> sce_qc <- scDblFinder::scDblFinder(
test_data,
clusters = TRUE, dims = 50L,
nfeatures = 2000L,
samples = "Sample",
multiSampleMode = "split",
returnType = "sce"
)
There were 26 warnings (use warnings() to see them)
[R]> data.frame(colData(sce_qc)) %>%
dplyr::select(Sample, scDblFinder.sample
) %>%
dplyr::filter(Sample != scDblFinder.samp
le) %>%
head()
Sample scDblFinder.sample
TTTCCTCTCAACTCTT-1 sample3 sample2
GTCAAACTCCACGAAT-1 sample3 sample1
GGTTAACCAGCGCTTG-1 sample3 sample2
AGCATCATCGGCTTGG-1.1 sample3 sample1
TGGAACTGTGACAGCA-1.1 sample3 sample1
from scdblfinder.
It seems the column cell names matters, for I have some duplicated column names ? By changing colnames with colnames(test_data) <- paste0("cell_", seq_len(ncol(test_data)))
, this problem can be figured out.
[R]> colnames(test_data) <- paste0("cell_", seq_l
en(ncol(test_data)))
[R]> anyDuplicated(colnames(test_data))
[1] 0
[R]> set.seed(221113L)
[R]> sce_qc <- scDblFinder::scDblFinder(
test_data,
clusters = TRUE, dims = 50L,
nfeatures = 2000L,
samples = "Sample",
multiSampleMode = "split",
returnType = "sce"
)
There were 28 warnings (use warnings() to see them)
[R]> # logNormCounts
data.frame(colData(sce_qc)) %>%
dplyr::select(Sample, scDblFinder.sample
) %>%
dplyr::filter(Sample != scDblFinder.samp
le) %>%
head()
[1] Sample scDblFinder.sample
<0 rows> (or 0-length row.names)
from scdblfinder.
Ok, thanks @Yunuuuu , that explains a lot.
I'm afraid I'm going to have to throw an error msg on duplicated colnames, because I need to match the cells with the original object (to provide the full original object with added slots).
from scdblfinder.
@plger Thanks a lot, enforcing unique colnames have already solved this.
from scdblfinder.
Related Issues (20)
- Issue with knownDoublets HOT 3
- Dimension reduction option HOT 2
- Forgot to import sweep from DelayedArray HOT 3
- BiocParallel error - could not find symbol 'useNames' in environment of the generic function HOT 2
- Issue running scDblFinder on scATAC-seq data HOT 3
- Exploring Overrepresented Doublets HOT 3
- scDblFinder not deterministic when using batch+BPPARAM HOT 9
- xcgboost install HOT 2
- size factors should be positive in computeDoubletDensity HOT 1
- why error ? HOT 4
- Possible Bug: cxds2 call does not include artificial doublets in whichDbls HOT 1
- V minor coding bug with multiSampleMode = 'split' and returnType = 'table'
- Running scDblFinder deterministic and serial with the 'samples' parameter HOT 3
- Error in installing scDblFinder: object ‘colBlockApply’ is not exported by 'namespace:beachmat' HOT 5
- How to find all features used in training HOT 1
- Doublet numbers still not reproduced even though I used BPPARAM and bpstart HOT 2
- Deprecated "dgcMatrix" HOT 2
- doublets mostly differ between scDblFinder and doubletFinder HOT 18
- Merging multiple samples with scATAC prior to scDblFinder HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scdblfinder.