Giter Site home page Giter Site logo

memo's People

Contributors

christoph-heinrich avatar po5 avatar xfzv avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

memo's Issues

Show the current page number in the menu title

It would help the general orientation inside the history if the current page number was visible. Additionally, the total number of pages could be displayed to give a relative sense of where the current page stands, which you already get from one bound (that being the first) but not from the other.

All pagination implementations I can think of that are not infinite, i.e. don't have the necessary information available, have an indication of the current and the number of total pages, so it's not unusual.

Optimize search while typing

Right now the cursor gets reset on every search update, and we parse everything over again.

My solution would be similar to page state, storing a list of known matching entries for each query, and the cursor position since we may have to parse extra entries to get a full page of results. Will require some changes to fakeio.

[FR] Keybinding to add selected entry to the playlist

With current behavior, pressing either "return" or right arrow will start playing the selected entry. It would be nice if we could add it to the playlist with another keybinding instead, so that the current playback isn't stopped.

Maybe not useful but I'm using Eisa01/SmartCopyPaste.lua, which allows to do this.

Pretty similar to #7 but maybe it's easier to implement? Anyway, that's just an idea.

Store history in application state directory

Currently, history_path defaults to ~~/memo-history.log, ~~/ being mpv's config directory.
That should probably be ~~state/memo-history.log, which uses the application state directory: ${XDG_STATE_HOME}/mpv on various unices.

For more information about the distinction, see the XDG Base Directory specification.

Possible to Prompt for Title?

Could the script prompt the user for a title for the history item? This would be very useful when using memo-log for bookmarking.

Better keyboard navigation in the menu

Not sure how much of this would lie in uosc's responsibility (which I am using), but then it wouldn't apply to the non-usoc menu.

Anyway, after opening the recent file (or url) history and not seeing the video you are about to open on the first page, I would like to immediately move to the next page, e.g. using the page down key. Similarly, moving back a page using Page Up would be very useful.

Another nice idea would be binding the number keys 1 to 0 to select the nth item (with 0 => 10th) to immediately select that item once you found it. This isn't usually something you'd use in a uosc menu, but I imagine it would be quite useful for listings like this.

Keyboard navigation is currently possible using arrow keys (and page down to scroll multiple items at a time), but it feels very unintuitive to use the right arrow after selecting the "Newer entries <" entry to go … left. It may also be a better idea to have the "Newer entries >" entry as the first item to make it easier to differentiate the two pagination items and have a more natural scrolling feeling.

More responsive menus

I've been thinking about our conversations in #13 and the need for a secondary script to do non-blocking processing.
In some ways, that's correct. But I just had an idea that doesn't involve extra mpv instances or extra script files, while still allowing for real parallel operations! The concept works in the limited tests I've done so far, I need to update memo to work with it.
The vanilla UI will of course benefit the most, but it will also be great for responsiveness because it will allow cancelling uosc searches when the query changes.

If the memo experiment works I'll definitely implement it in other scripts that do lengthy blocking operations, or need very fast feedback (thumbfast?).

[Question] History not logged when opening files in joshuto with `fork = true` option

I've been playing around with kamiyaa/joshuto lately, and I've noticed something.

By default, video are opened in mpv with fork = true option.

References:


  • With fork = true:
  1. Open a video from joshuto
  2. Exit mpv
  3. Open mpv again
  4. Said video does not appear in memo history

  • With fork = false: normal behavior, the video appears in memo history.

I also noticed that save-position-on-quit="yes" in mpv.conf still works fine with fork = true. Opening the video again starts where I left it, and a file is written to ~/.local/state/mpv/watch_later directory.

Is there a workaround for this? I'd like to keep using fork = true if possible.

Problems with `osd-back-color`

While testing #17 I noticed that your menu doesn't play nice with osd-back-color. I think it's that bad because for each thing ass:new_event() is called, and now each of those gets it's own background.

Screenshot with osd-back-color=0/0/0/0.7
image

In quality-menu I fixed it with a \\rDefault to get rid of all mpv provided styling, but I don't know if you want to do that.

[Feature Request] : save yt video title in menu

as of now if i try to play a yt vid through the menu only the url is shown, which is not helpful as i dont know which link is what.

image

recent menu saves the title
image

i think if we save the yt title also it would be easier for people to identify what to choose.

Ignore missing videos

If a video is already listed in the menu, and is moved to a different folder it still shows up in the menu, and clicking it does nothing.

Would it be possible to somehow track the file moved, or is that infinitely harder than just ignoring missing files?

For example I have a folder called Videos, where my torrents are downloaded, using webtorrent-mpv-hook. After downloading I move the video into either my shows or movies subfolder. Could the script track this movement, so the initial menu entry still works?

Delete Item From History

Is there a way to delete an item from the menu? memo-log works well for manually creating bookmarks, but then they can't be removed without editing the text file.

conflicts with sub-skip, speed-transition, or recent menu

I really wanna get either sub-skip or speed-transtition to work and they do but only if memo.lua isn't there. I'm guessing there is a conflict with mp.register event possibly. Anyway to rectify this perhaps.

edit: ok sorry I'm pretty sure the culprit is a new script blackout with property changes...

Adding memo-clear to clear entire history

I just keep history only for sometime. After a period of time (complete watching remaining videos), I usually clear the entire history.
Please add this feature. I think some users may benefit from it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.