Check for updates

[pouriyajamshidi]

Check for updates

[icemint0828]

From reading the Github API documentation, it appears that unauthenticated requests from the same IP are limited to 60 per hour.

For unauthenticated requests, the rate limit allows for up to 60 requests per hour.
Unauthenticated requests are associated with the originating IP address, and not the person making requests.

If we implement this feature without the flag, users may end up consuming a number of API requests on github every time they run tcping.

Is there any good way to do this?

[icemint0828]

This is my first time dealing with this type of problem, but I would like to give it a try.
The following is the process I'm considering

• Get release version with go-github package.
• Compare with const version.
• If latest version is exist, print message to prompt for version up.

What do you think?

P.S.
I become able to use slack!
If you have no problem, please invite me.

[pouriyajamshidi]

This is my first time dealing with this type of problem, but I would like to give it a try. The following is the process I'm considering

• Get release version with go-github package.
• Compare with const version.
• If latest version is exist, print message to prompt for version up.

What do you think?

P.S. I become able to use slack! If you have no problem, please invite me.

[email protected]

Hi,

Your thought process looks fine to me as well.

I am not really familiar with go-github package but it is fine for me.
I would like to keep our program clean and also as simple as possible. If you notice, I did refactor a lot of things over the weekend as well.

I also contacted you through the email you provided (and removed the email from your comment for privacy reasons).

[pouriyajamshidi]

From reading the Github API documentation, it appears that unauthenticated requests from the same IP are limited to 60 per hour.

For unauthenticated requests, the rate limit allows for up to 60 requests per hour.
Unauthenticated requests are associated with the originating IP address, and not the person making requests.

If we implement this feature without the flag, users may end up consuming a number of API requests on github every time they run tcping.

Is there any good way to do this?

That is a very valid concern. Let's not automatically do it by default.
Better to only do it when they actually check for an update.

[pouriyajamshidi]

Based on the discussion here, this issue can be ruled out in favor of #15

[icemint0828]

Hi.

Your thought process looks fine to me as well.

Thank you for your opinion!

That is a very valid concern. Let's not automatically do it by default.

I see.
I'll make sure it's finally implemented that way.

Better to only do it when they actually check for an update

Yes, I think too. But, I don't have any ideas at the moment.

First, when I implement the update message is displayed without flag, I will put out a PR.

[pouriyajamshidi]

Hi.

Your thought process looks fine to me as well.

Thank you for your opinion!

That is a very valid concern. Let's not automatically do it by default.

I see. I'll make sure it's finally implemented that way.

Better to only do it when they actually check for an update

Yes, I think too. But, I don't have any ideas at the moment.

First, when I implement the update message is displayed without flag, I will put out a PR.

perfect!