The pong from psycokwet

Several game Challenges at the same time - One play can not play

Several users challenge user A at the same time. When A accepts on challenge, on of them can not move the paddle. It does not happen if there is only one challenge at time to a unser

[game] mauvais pseudo challenge and spectate

It was challenges sent by Alice and Pwet to Pony, and Pony was seeing this.

Same happen on spectate, I didn't screen, but it was pony versus pony

404 on first load of the page for the auth root

Not a big deal, only after all the rest is good.

this.server.sockets.sockets.get(

wrong sockets

Channel Create bug

When in a channel, with message, if you create a new channel, message history isn't reloaded !
MESSAGE_HISTORY must be sent for a newly created channel (and it will be a object with nothing in it)

Check if we always use user when we have it

Check if there isn't any if(!user) throw error in the back

Need input validation on user.entity

As it's the case with class-validator at other places, we need to set it on user.entity as well. And maybe, on other entity that need user input

Protecting build from submitting fake 42 login

[back][chat] issue on display new list channel

On listChannel change, the channel selector doesn't update properly.
To test it:

connect with 2 accounts (with false42login for exemple),
then go to chat,
then go to the channel selector,
with the other account,
create a public channel (with or without password),
on the first account,
see missing new channel on join channel selector.

Need to change routed page on disconnect to avoid 404 redirection

When disconnecting while being on a /route on front, we get a 404 redirecting error page, we need to redirect the user once they are disconnect directly

User is banned (or kicked). He's no longer in the room. But if he's in the room, and not changing his page, he can still send message and other can still receive it. This happens to ban and kick.
Here bb is kicked/banned, you can see that he's not in the user list of that room. But we can still see his message.

[websocket][chat] Alice et bob pas dans la liste partout dans la liste user du chan

Alice et Bob on rejoint le meme channel, mais, Bob, second a avoir rejoint le channel n'apparait pas chez alice. Je n'arrive pas a savoir exactement les conditions de reproductibilité, mais ça m'es arrivé plusieurs fois aujourd'hui

[front?][back?] sometime, we get connected on the app with same account even on multiples browsers

I did not figure out exactly how the issue occurred, but I believe I've seen it before as well.

Sometime, I connect, let's say, on chrome, and the session update on firefox as well.

To determine the issue's source.

Friend related API

Some friend related API requests needs to be updated to actual conventions :

get_friend_list & add_friend are not camelcased
getFriendList & addFriend requests login42, they're not supposed to
The getFriendList should return an Inteface User, not only a login

No redirection to login page after token expires

This issue seems a bit random at the moment: sometimes when the token expires, the user is sent back to the login page (which is correct), and sometimes they just stay on the page they left.
Essentially, they are not connected but it seems like they are.
This is especially problematic on pages which refresh data live (chat, friends, matchmaking).

set picture, check file format on back

Il faudrait essayer de voir si on peut verifier le format de fichier uploaded ^^ Verifier que c'est bien une image valide ^^ Merci !

Whitespace on 1st login page

From what I understood, the Settings page is called upon 1st login but without a NavBar, which leaves an empty white space at the bottom.

Bug : Hot reload front broken

hot reload works in local, but not in docker. Since we are not yet connecting back and front, you can work locally if you prefer to have the hot reload. I'll fix that asap.

[WebSockets][Back] error message

I don't know what it is, I sent a hell lot of message on chat and got that at a moment, but everything kept working fine so.... Just creating issue to track in case we can fix later !

one user can play against itself using 2 tabs

here is the game result.
We need it to be forbidden to happen

[back][front] Issue on refused challenge while accepting another

The cursor is not captured for the right challenge when gaming after refusing a challenge, somehow

bug on main, on login

#58

handleConnection has not protection against:

getUserFromSocket => parse crash
getUserFromSocket crash

Websocket not broken on signout.

Two players are waiting to join a game. Game does not start.

Sometime there are two specific users who can not play with each other. But with a refresh page, the problem is solved

Sign out from any page will get to NotFound page (then it sign out)

Protect build environnement from fake login page

Petite mission pour toi @mescande je le met en issue pour pas oublié vu que ce week end tu n'es pas trop là ^^
La mission est simple, il faut que tu protege cette fonctionnalité pour qu'elle ne soit pas accessible en environnement de prod, coté front c'est facile. Si tu as la deter, tu peux regarder pour le back aussi. Y'a au moins une option aussi simple coté back, je me demande si y'a pas une façon plus elegante, pour ne vraiment pas embarquer le code dans le build final, mais j'ai pas encore trouvé. Fait moi savoir si tu veux faire que le front, ou si tu veux aussi faire le back, au moins la version facile :)

Merci n_n

Destroy channel when no members are left

Right clicks buttons have no effect

Sometime, we can click on right button menu to see profile for exemple, with no effect, until we refresh the page or a miracle happen. I had the issue multiple time, but can't seem to etablish a proper to do to reproduce it. Sorry for that :/

Logout app doesnt disconnect from websocket

We need a socket.disconnect somehwere on front

Issue on mozilla firefox

Firefox page reload

When on Firefox, each reload make you reconnect via signin 42 button

Attached Users List Confirmation

This Route return a standard DB User, and it should return a UserInterface

[front] Put game setting code in gameSetting component

Re-organizing the code of game setting, to avoid clutter in the parent component

Setup default user picture

Spectate end game

Pas de notif envoyee aux gens qui spectate une game
Envoyer une notif websocket comme quoi la game est terminee

Remove extra 'n' in 'optionnal' (channel password)

prod : White build frontend

Build frontend is broken, I guess there is a config issue
Related to the incomming pr about the production environnement

UserInterface Update

In order to make UserChannelList, and FriendList working, I'd need :

GetFriendList in Websocket
UserInterface to have a new element : status
|-> means to update a lot of code
|-> type : enum (offline, ingame, online

Challenge route

Need the route to be working in the back

Injection sql

Verifier si typeorm nous permet d'etre protégé par les injection sql

[front] Issue when selecting a channel to join

With wrong default value set in the choice list, there is issue when selecting a value that is the default value, or something like that. It's quite particular as an issue. Sorry if I don't explain it well haha. It need a bit of testing to figure out exactly the source of the issue.

pro : npm update

Must have latest on prod environnement, will get on it later

Change password Route

Need a route to change password :

CHANGE_PASSWORD_REQUEST

 {channelName, inputPassword}

[Game][challenge]

When we try to send a challenge to ourselve, then, it block our ability to challenge anyone.

psycokwet / pong Goto Github PK

pong's People

Stargazers

Watchers

Forkers

pong's Issues

Recommend Projects

Recommend Topics

Recommend Org