purplebricks/pat.sender

Pat Sender

pat.sender's Issues

Schedule commands - should use alternative method?

We are currently scheduling commands by setting Message.ScheduledEnqueueTimeUtc.
https://docs.microsoft.com/en-us/dotnet/api/microsoft.servicebus.messaging.brokeredmessage.scheduledenqueuetimeutc?view=azure-dotnet#Microsoft_ServiceBus_Messaging_BrokeredMessage_ScheduledEnqueueTimeUtc

I think we should be scheduling messages using the QueueClient.ScheduleMessageAsync(…)
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.servicebus.queueclient.schedulemessageasync?view=azure-dotnet

This means that we would be able to cancel the scheduled message:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.servicebus.queueclient.cancelscheduledmessageasync?view=azure-dotnet

Why is this helpful?

• I suspect there are multiple scenarios where we might wish to cancel something. E.g. a user schedules something and then changes their mind.
• Able to cancel a command, make some change, and re-schedule

Should Pat.Sender log when it publishes/sends a message

I don't think we are currently logging when messages are published.

Should we be? If so, Info or Debug?

I was just running through the example projects in the pat repo, and noticed a lack of output on Publisher project compared to Subscriber. This might be helpful when debugging a problem.
e.g. if my subscriber didn't receive a message can I be sure that publisher published anything?

Missing IoC helpers

Pat.Subscriber has IoC helpers for both structuremap and dotnet (see
https://github.com/purplebricks/Pat.Subscriber/tree/master/Pat.Subscriber.NetCoreDependencyResolution and https://github.com/purplebricks/Pat.Subscriber/tree/master/Pat.Subscriber.StructureMap4DependencyResolution).

Something comparable needs to be built to enable simple boot strapping of an event publisher.

Use ILogger<T> to match Pat.Subscriber

It would be good to bring Pat.Sender inline with Pat.Subscriber regarding logging
purplebricks/Pat.Subscriber#21

Ideally we will just use ILogger<T>.

This will

• Simplify IOC

• Be more standard/consistent

Use JsonSerialiser in MessageGenerator

Would you accept a PR to use JsonSerialiser in MessageGenerator.cs ?

I've got a simple benchmark that shows this results in almost 50% less allocations.

If this is something you'll accept I'll submit a PR