reblws / tab-search Goto Github PK
View Code? Open in Web Editor NEWWebExtension for keyboard-accessible tab management
Home Page: https://addons.mozilla.org/en-US/firefox/addon/tab_search/
License: MIT License
WebExtension for keyboard-accessible tab management
Home Page: https://addons.mozilla.org/en-US/firefox/addon/tab_search/
License: MIT License
Im going to look at doing a PR for this but I wanted to get my thoughts down before I forget:
It would be really handy to have a tabbed interface in the dialog to separate result types to separately show open-tabs, history, closed-tabs, and bookmarks.
I want to see history and bookmarks in my results but when I search for gmail to go to my email tab I get all the history and bookmark stuff first, selecting one of those opens a new tab instead of changing to the already open tab.
In TabSearch settings there is the "Show recently closed tabs - Limit (max. 25):" option. I'd really like to have more than 25.
Is this limit there for performance reasons or something else?
Per this review.
Ctrl + shift + F overlaps "Panorama view" extension own shortcut.
It should be possible to change it in the extension settings page, that also a good place to to learn it, since this info is only available on the extension web page.
This is a very nice add-on, I just wish a couple of keyboard actions could be improved:
These are just my improvement suggestions. The add-on itself is already very good, a bit of polishing of the keyboard navigation would make it perfect :)
The fix in #28 unfortunately causes jerky scrolling, because the default behavior for ArrowDown and ArrowUp is to scroll up or down. Instead, the list should only scroll when the focused tab is the first or last visible element in the viewport, as it does when pressing ArrowRight or ArrowLeft, without causing the extra input required to go down.
Requested feature
When using C-S-l or clicking the icon, the panel is not focused automatically, and therefore, https://github.com/reblws/tab-search/blob/master/src/index.js#L21 has no effect.
I checked in debugger that both DOMContentLoaded and the timeout fire, but I have to press Tab in both cases to focus the popup. I looked briefly in the MDN WebExt APIs (i.e. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction) but I didn't see a way to force-focus the popup. Any ideas?
Might be a FF bug.
updateTabInWindow/< moz-extension://524099ca-5e94-41a5-b1e4-d5611b684bd6/background_bundle.js:2696:49
promiseBadgeTextWindowUpdate moz-extension://524099ca-5e94-41a5-b1e4-d5611b684bd6/background_bundle.js:2707:54
Firefox 64.0
"the first time you press down or right arrow to focus the first item, it doesn't work - you need to press it twice"
Toggle the extension Press Tab
to switch selection, by pressing Shift+Tab
the selection goes to the next item, instead of to the previous one, as expected.
It would be nice if there were a setting for disabling search of pinned tabs (e.g. a checkbox at Settings > Results > Show Pinned Tabs
or something).
I have a lot of pinned tabs and almost never want to access them quickly.
If I do CMD+SHIFT+L, then type a search string, then press enter nothing happens. But if I press enter again the first tab in the results is opened. Can the behavior be changed to work with a single enter keypress?
Hello,
I'm using FF60 and because I don't need the option of displaying tab count, I disabled the option but the problem is that the setting is not persistent! i.e. when closing FF and re-opening it again, I find the tab count returned again!
I would like the ability to define a custom shortcut key to activate the extension. Perhaps this is something Firefox needs to implement, the same way that Chrome has a page to manage hotkeys for extensions.
Right now Mac users can't use Cmd
or Ctrl
keys to set different shortcuts -- they are treated as equivalent keys.
Need to push this fix together with #49 so the update doesn't break any previously set shortcuts involving Cmd
. After this is fixed, writing a migration to the new reducer structure is possible, so any previously set shortcuts involving Ctrl
can get split into two shortcuts: [Cmd+${key}, Ctrl+${key}]
after the extension updates.
Hi,
Awesome plugin!!! I'm having an issue though when searching... I would assume that my search text would be cleared out after the popup is dismissed however it seems to persist which makes repeated searches annoying as i have to remember to always first clear the search text.
Is there a way to reset it automatically?
Thanks
I'm a fan of Vivaldi's "Quick Commands" presentation where the dialog is vertically and horizontally centered over the current tab, as opposed to appearing in the top right corner. Something like that for TabSearch would be great.
I have 247 tabs open (so that might be the problem... it's definitely a problem). Also, i just installed the plugin. If it takes some time to index, i apologize for this report.
One of my open tabs is this one:
https://gitlab.com/drutopia-platform/sites/family-home/issues/12
Which has the title Site launch checklist (#12) · Issues · drutopia/platform / sites / family-home · Gitlab
When i bring up tab search (all settings default, fuzzy search on etc.) and type in:
gitlab drutopia family
I expect to get that tab. I do not. It's not merely not first in the list, it's not in the results at all. Instead, tab search seems to be using only the last word of several searched for its matches, and limiting the total results displayed somehow also.
(When starting a new tab, Firefox itself used to be infallible in suggesting tabs that matched the words in any order. It no longer is, which is why i'm looking for a separate tab search. So there may be an underlying Firefox issue here, but since tab search implements its own searching algorithm i'm hoping it can overcome Firefox's deficiencies.)
Thanks!
The search query and results is reset whenever clicking on toolbar button, which makes it inconvenient to view the matched tabs having to enter search query again.
Great extension, probably the best way to keep track of "too many" tabs right now! I understand that you're mostly concerned with searching, but I believe that keeping tabs organized helps a great deal in narrowing down search results as well as sometimes even making them superfluous.
I believe that making the headlines or groups you have listed in the options under Results to be collapsible would make it easier to search: do I want to search History? Collapse the others and make the search (the search should only affect expanded headlines - or should that be an option?). Did I close a tab prematurely, but a couple of tabs ago? Collapse all but Recently closed tabs and it should be easy to see. It would also probably be a good idea to allow the user to choose in the options which headlines should be expanded or collapsed by default when the pop up is opened.
I also propose that the user should be able to set headlines in the options for groups of tabs, and then should have the ability to drag-and-drop tabs to these groups or headlines - sort of a light version of tab groups. New tabs should then open under the current headline/group. These headlines or groups should probably all have the same colour as all tabs, so as to not add confusion. They should of course also be collapsible.
If this is implemented I suggest that the term Headlines are used for the base divisions (Tabs, History, Bookmarks and Recently closed tabs) and the term Groups are used for the user defined divisions of open tabs.
If the Groups are to much then I suggest allowing drag-and-drop to sort tabs in the list (assuming this isn't the reason why the above falls...).
It would probably be even easier to use if the Headlines were shown as 4 simple buttons between the search field and the list in the pop up, preferably underlined with their respective colour. Then you could quickly toggle which Headlines should be expanded or collapsed by just clicking their button, and easily see which were expanded by noting which buttons were marked.
EDIT: spelling
Could you add the option to select multiple tabs at one to close them
By request:
Should be able to customize navigation shortcuts, which are:
Should start by refactoring string literals in https://github.com/reblws/tab-search/blob/master/src/core/pages/popup/event-callbacks.js#L41
As soon as I remove the icon from the toolbar (because I only use the keyboard shortcut), the keyboard shortcut stops working.
(I'm aware this might be due to the Firefox API not allowing this. Opening the issue anyway to track the issue and maybe share possible workarounds etc.)
Just discovered this addon and it's awesome!! Thx!
One feature i would really love to see is the ability to order the tabs in the popup by most recently used. I usually have a ton of tabs open so listing tabs by MRU would allow me to quickly jump to a tab i was recently if i don't remember the name of it or don't feel like searching.
Check out https://github.com/babyman/quick-tabs-chrome-extension for a great Chrome plugin that does this.
No big deal, but none the less - when I click the close tab button nothing seems to happen, but if I close the pop up and opens it again the tab is deleted.
I'm on Ff Quantum 58.0.2 (64-bit) branded as Mozilla Firefox for Linux Mint mint-1.0, on a machine with Linux Mint 18.3 Cinnamon.
At least for the actions that take effect when the panel is open (e.g. this is unrelated to #2). There are a number of reasons someone might want to do this, but personally:
On macOS, in most menus (all/almost all native menus, at least), as well as almost all text boxes you can navigate up and down a line using either the arrow keys, or Ctrl+N
and Ctrl+P
. For clarity, I actually mean the control key, MacCtrl
, not Cmd
. (Strangely, macOS supports a number of other similar movement options inherited from emacs, of all places. Regardless, some people like myself come to use them heavily).
This is in addition to allowing arrow keys (which I also use).
In your extension I'd like to be able to navigate with either arrow keys or Ctrl+N
/Ctrl+P
, but as it is, I need to choose.
Instead of asking for your extension to code in this macOS quirk, it would probably be better to just support allowing multiple shortcuts for a single action.
When clicking a link the badge text resets to the loading text "...".
Temporary workaround is just focus another tab and then switch back before re-muting.
This should make it more obvious that you can press Enter from the search input to access the first result.
Apply .tab-object:selected
on the first child element of the tab list if activeElement is searchInput
Caused by opening wrong sessionId
, probably related to about:newtab
not opening a new session.
Should place the moving and re-painting logic in sessions.onChanged listener instead.
Related to #46
How do we popup the tabsearch ?
(for instance chrome tab search is "ctrl+i" and it's clearly shown in the addon page https://chrome.google.com/webstore/detail/tab-search/mgfejaiakfkkipbelelkcfbimnfjhebn )
I love this extension!
I would also love the see if the popup was bigger so I could fit more results on the screen. Maybe make it resizable? Or add an option where you can specify how many entries you want to see at once?
Add option to tweak tab title sizes by 1px
In the options it's stated that you have added "More tab management options". Am I right when I believe those are the ones mentioned in issue "Tab management #31"?
There these features where discussed:
Move tabs
Refresh tabs
Mute/Unmute tabs
Pin tabs
Copy the url of the selected tab(s)
Bookmark selected tab(s)
Close duplicated tabs
Move selected tab(s) to an existing window/new window
The issue was edited as Done for release 0.4 and I have 0.4.4, but I still can't find the features. Some of them would be very useful indeed!
I'm on Ff Quantum 58.0.2 (64-bit) branded as Mozilla Firefox for Linux Mint mint-1.0, on a machine with Linux Mint 18.3 Cinnamon.
I suggest that when the extension icon/button is clicked or the keyboard shortcut is pressed, the "Search for a tab..." input field should immediately be given focus. That way, the user can start typing their query right away.
It's particularly troublesome to have to click on something after using the keyboard shortcut. That defeats the purpose of having such a shortcut to begin with, in my opinion.
(This is aggravated by the fact that the current shortcut, Ctrl+Shift+L, is difficult to activate using only the left hand, so I move my right hand from the mouse to the keyboard to press it, then back to the mouse to move the cursor and click the "Search for a tab..." input, and then back to the keyboard to type. As is, it's often faster to not use the shortcut at all. As a side note, it'd be great to be able to set our own shortcuts. I'd also suggest a default shortcut of Ctrl+Shift+F since it can be done easily enough with just the left hand.)
Hello,
I'm M.Samuel who reported about the flashing cursor not focused in the search box. I'm on Firefox v57 (Quantum) which was released just yesterday and it's a fresh clean install in a Windows 7 x64. I started to believe it's not related to the extension because the "LastPass" extension doesn't have focus too. I think it may be related to a browser bug. I'm not sure though.
Many thanks for your efforts.
I know your addon now mainly focuses on finding tabs and getting to them but since I saw it's possible to close tabs I was wondering if you were planing to add features to be able to manage the tabs like re arrange them bookmark them reload them etc? I think taking that step forward would make this extension even greater and more useful than it's now.
If the tab I'm looking for isn't there, but I have bookmarked it, it would be great if that appeared in the TabSearch results. Similar to how recently closed tabs can appear.
As of v0.4.8, I think the favicons in the popup are way to big in comparison to the text (especially if one selected a smaller font size in the prefs for the link/titles).
As it's possible to change the font size of the tab links/titles, I think it would be nice to have a preference to hide / shrink the favicons of the tabs.
Feature Request:
Please make the delete gadget sensitive/fill the entire right-hand vertical space for the tab list. I often am running through hundreds of tabs, and closing them, but sometimes the vertical size of a tab listing varies and the centered delete gadget moves up/down from where my mouse is, and clicking there SELECTS the tab, rather than deletes it. (i guess this is from having 2-line title lists where some tab entries are single-line).
This would be easier to work with also if the WIDTH of the popup could be user-settable.
thanks,
--stephen
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.