Giter Site home page Giter Site logo

Comments (6)

BSVogler avatar BSVogler commented on August 18, 2024

I think Radix v4 is out of beta. I see no indication that v4 is in beta, but v3 is still the default branch.

from grafana-redis-datasource.

leandro-deveikis avatar leandro-deveikis commented on August 18, 2024

Hi! sorry to bump this old issue, but is there any plan on migrating to v4? and target version or date?

from grafana-redis-datasource.

slorello89 avatar slorello89 commented on August 18, 2024

Hi @leandro-deveikis no worries, I kept this issue open in case it became apparent that there was a compelling reason to upgrade from Radix 3->4. AFAIK there isn't. Looks like there are some quality-of-life bits and some things around the edges - but I don't see anything, as of this writing, that stands out to justify the effort/risk of revving a major version.

Just so you know, totally open to being wrong about this, I'm conversant in golang but not fluent - if there's a really compelling reason to do it please by all means lay it out for me and I can definitely consider moving forward with the upgrade.

Another possible path (if a change is necessary and if the upgrade is more than a simple version change) is to switch over to the official Redis golang client (go-redis).

Atm the client seems fine and as far as I know is still receiving some patches (though the current version is a year old at this point). So the old adage "if it ain't broke don't fix it" resonates with me a lot here - at least in the interim.

from grafana-redis-datasource.

leandro-deveikis avatar leandro-deveikis commented on August 18, 2024

Hi @slorello89 Sorry for the super late response.

For a little bit of more context, I am working on PDC (Private datasource connect - link to docs) on Grafana, and I would like to contribute to enabling PDC on the Redis Datasource, to allow grafana customers to securely connect to their remote Redis instances.

The problem is that RadixV3 doesn't allow configuring a custom dialer, making it impossible to implement PDC. However, if you move to RadixV4, it would be really easy to implement (setting NetDialer here).
I would happily pick up that task and open a PR once V4 is already implemented if you like to. What do you think?

Additional note: I also made successful test with go-redis, so it could be also an alternative.

from grafana-redis-datasource.

leandro-deveikis avatar leandro-deveikis commented on August 18, 2024

Hi! Any update on this?

from grafana-redis-datasource.

QuentinN42 avatar QuentinN42 commented on August 18, 2024

Hello, I'm interested to contribute to make this move forward :)

Can you confirm that if I open a MR, someone will be able to review it?

from grafana-redis-datasource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.