Giter Site home page Giter Site logo

Comments (11)

mikhail-vl avatar mikhail-vl commented on July 19, 2024 2

@dpipemazo Let me add additional Client type for socket connection and will send you branch to try. Give me 15 minutes.

from grafana-redis-datasource.

dpipemazo avatar dpipemazo commented on July 19, 2024 2

Works great! 🎉

Screenshot from 2020-08-27 20-34-15

Thank you!!

from grafana-redis-datasource.

mikhail-vl avatar mikhail-vl commented on July 19, 2024 1

@dpipemazo Redis Data Source based on Radix golang client (https://github.com/mediocregopher/radix). I don't see an option to connect using the Unix Socket at first sight. If it is supported by Radix, it would be ideal.

I can take a closer look later, but we can ask Radix developer if it's something he would be interested to implement. I see that some Redis clients support connecting using a Unix socket.

from grafana-redis-datasource.

dpipemazo avatar dpipemazo commented on July 19, 2024 1

Yes, I agree it should come from the client. We've been using redis-py and hiredis via the unix socket for a while with good success, makes sense this support isn't in all of the language clients, particularly a language like golang which is really geared at networked connections. I'll file an issue over there. Thanks!

from grafana-redis-datasource.

mikhail-vl avatar mikhail-vl commented on July 19, 2024 1

@dpipemazo Thank you for submitting the issue for radix. Looks like we found the way how we can add Socket connection as an additional client type.
I will test and let you know later tonight.

from grafana-redis-datasource.

mikhail-vl avatar mikhail-vl commented on July 19, 2024

@dpipemazo Thank you. Please put it here as well for tracking.

from grafana-redis-datasource.

dpipemazo avatar dpipemazo commented on July 19, 2024

Issue filed on radix

from grafana-redis-datasource.

dpipemazo avatar dpipemazo commented on July 19, 2024

@mikhailredis thank you! This is very quick and much appreciated.

from grafana-redis-datasource.

mikhail-vl avatar mikhail-vl commented on July 19, 2024

@dpipemazo Please verify and let me know if it works for you: https://github.com/RedisTimeSeries/grafana-redis-datasource/tree/feat/socket

from grafana-redis-datasource.

dpipemazo avatar dpipemazo commented on July 19, 2024

Thanks! Trying now 👍

from grafana-redis-datasource.

mikhail-vl avatar mikhail-vl commented on July 19, 2024

@dpipemazo Merged to master. Please let me know if there is anything else!

from grafana-redis-datasource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.