roblox/core-scripts

All of ROBLOX's core client scripts.

Core-Scripts

All of ROBLOX's core client scripts.

These scripts are responsible for character & camera control, as well as in-game UI and other things.

core-scripts's Issues

Invalid value for enum KeyCode | CoreGui.RobloxGui.CoreScripts/ChatScript, line 1178

I'm seeing this frequently in Google Analytics

Invalid value for enum KeyCode | CoreGui.RobloxGui.CoreScripts/ChatScript, line 1178

Argument 1 missing or nil in PurchasePromptScript

This bug may be related to #18. It often occurs in conjunction with that error.

Argument 1 missing or nil | CoreGui.RobloxGui.CoreScripts/PurchasePromptScript, line 601 - global canPurchaseItem CoreGui.RobloxGui.CoreScripts/PurchasePromptScript, line 180

New PlayerList: Selecting a player to friend or report should block input.

After selecting a player entry, scroll, expand and drag input should be locked.

Unable to expand the leaderboard

You used to be able to expand the leaderboard by pressing the TAB key, but with the new Core GUI, you can't. (According to SchnitzelSandwich)

PromptPurchase: Able to buy model that you already own

If you prompt purchase a free model and you already own it, you are able to take it again. It doesn't do anything, but the behavior is just weird.

Example:

Tiny backpack when player is initially minimized

If you click to join a game and then minimize your player for a few seconds, your backpack will be miniature:

This is caused by line 24 of BackpackBuilder.lua:

local function IsPhone()        
    if gui.AbsoluteSize.Y <= 320 then       
        return true     
    end         
    return false        
end

Dev console and PromptPurchase windows overlap

http://i.imgur.com/yygd39D.png

This shows how the developer console overlaps with parts of the PromptPurchase/PromptProductPurchase window.

I'll probably fix it later, I'm just reporting because I just noticed it.

In the new player list, entries not sorting correctly

Currently only sorting by player name, not by the primary leader stat.

New PlayerList: Send Request/Report Abuse pop out not hiding when that player leaves.

After selecting a player entry, if that player leaves the game, the pop out frame is not removed. Reported by QA team.

ROBLOX's scripts output "attempt to call a nil value"

see original issue by @Quenty

---

One of ROBLOX's core scripts will output "attempt to call a nil value" in solo test mode If certain conditions are met.

It appears when you load a character, and you have set the Players.ChracterAutoloads to false, then you will break some unknown script.

Repro

1. Make a new place in studio
2. Set Players.CharacterAutoLoads to false
3. Test in SoloTestMode or the new Character Play Mode
4. Run this code whenever you want, in that test mode.

game.Players.Player1:LoadCharacter()

Tadah. Error.

HealthScript:170: attempt to index upvalue 'humanoidDiedConnection' (a nil value)

I'm seeing this in studio when I start a server/client:

21:52:48.395 - CoreGui.RobloxGui.CoreScripts/HealthScript:170: attempt to index upvalue 'humanoidDiedConnection' (a nil value)
21:52:48.396 - Stack Begin
21:52:48.396 - Script 'CoreGui.RobloxGui.CoreScripts/HealthScript', Line 170 - global disconnectPlayerConnections
21:52:48.396 - Script 'CoreGui.RobloxGui.CoreScripts/HealthScript', Line 220
21:52:48.397 - Stack End

CoreGuis Report Abuse GUIs overlap

http://prntscr.com/3ry4ak

When you click on someones name in the leaderboard and click report abuse.
then you open the main menu by pressing ESC and click report abuse there,
the 2 guis overlap like shown in the above screenshot

CoreGui.RobloxGui.CoreScripts/ChatScript2:1628: attempt to compare number with nil

CoreGui.RobloxGui.CoreScripts/ChatScript2:1628: attempt to compare number with nil 

Stack trace:

CoreGui.RobloxGui.CoreScripts/ChatScript2, line 1628

Invalid value for enum KeyCode

This occurs in the following places:

• ChatScript2
  • line 993
  • line 1162
  • line 1379

IsScrolledDown not working

Everytime I am scrolling up in the chatlog and someone talks, it scrolls down again.
I can't find out why, though, but I thought I should at least post it here.

New player list won't hide

I am unable to hide the new player list using the SetCoreGuiEnabled method in StarterGui.

Reproduction steps:

1. Open Studio with a new place.
2. Insert a local script into StarterGui with the following code:

game.StarterGui:SetCoreGuiEnabled("PlayerList",false)

1. Play solo or use test servers. The player list doesn't hide.

Improper way to detect device type

https://github.com/ROBLOX/Core-Scripts/blob/master/CoreScriptsRoot/CoreScripts/Topbar.lua#L969-L982

Using the screen resolution this way is not the proper way of detecting device type. For example, many phones would be detected as "Desktop" by this function. Example: The iPhone 6 Plus has a screen resolution of "1920 x 1080".

Also, this code does nothing. Why's it in full release?

PurchasePromptScript - attempt to index upvalue 'currentProductInfo'

CoreGui.RobloxGui.CoreScripts/PurchasePromptScript:665: attempt to index upvalue 'currentProductInfo' (a nil value)

New playerlist: Issue with checking CreatorId.

Reported on dev forums by Ethan. Need to check CreatorType enum when checking creatorId.

BlackFrame is not a valid member of ScreenGui

LoadingScript, line 453

Seen March 21, 2015

ToolTip is not a valid member of HopperBin

ToolTip is not a valid member of HopperBin | CoreGui.RobloxGui.CurrentLoadout.CoreScripts/BackpackScript, line 606

and

ToolTip is not a valid member of HopperBin | CoreGui.RobloxGui.CurrentLoadout.CoreScripts/BackpackScript, line 612

Library failed to load | CoreGui.RobloxGui.CoreScripts/DeveloperConsole, line 4

CoreGui.RobloxGui.CoreScripts/DeveloperConsole:4: Library failed to load | CoreGui.RobloxGui.CoreScripts/DeveloperConsole, line 4

attempt to compare number with nil

This occurs when trying to set the Chat CoreGUI to disabled. I am using SetCoreGuiEnabled("All"), in this screenshot, you can see that no CoreGUI is hidden.

This seems to only happen to me while using the ROBLOX Developer app for iOS.

Using disabled API

http://api.roblox.com/users/{userId}/canmanage/{assetId}

The FFlag UseCanManageApiToDetermineConsoleAccess got enabled very recently.
The new API that the FFlag forces the client to use, however, is still enabled.
F9 serverside console won't load for anyone. (Not even game creator)

I also heard of an issue of a place's stats page not loading, could be related to this.

a.lua: attempt to call nil value

Several errors as reported by Google Analytics via the GA script module:

...blox\Versions\version-23a4f309f57a496c\content/a.lua:11: attempt to call a nil value | ...blox\Versions\version-23a4f309f57a496c\content/a.lua, line 11

.

...blox\Versions\version-187659e292024b9d\content/a.lua:11: attempt to call a nil value | ...blox\Versions\version-187659e292024b9d\content/a.lua, line 11

.

...blox\Versions\version-23a4f309f57a496c\content/a.lua:1188: attempt to index a nil value | ...blox\Versions\version-23a4f309f57a496c\content/a.lua, line 1188

.

...blox\Versions\version-23a4f309f57a496c\content/a.lua:1412: attempt to index global 's' (a nil value) | ...blox\Versions\version-23a4f309f57a496c\content/a.lua, line 1412

.

[string "for i,v in next,game:children()do..."]:286: attempt to index global 'script' (a nil value) | [string "for i,v in next,game:children()do..."], line 286 ...blox\Versions\version-187659e292024b9d\content/a.lua, line 2845

BlackFrame is not a valid member of ScreenGui

BlackFrame is not a valid member of ScreenGui

I'm seeing this error message. Following is the stack trace:

LoadingScript, line 451 - global fadeBackground
LoadingScript, line 519

new ROBLOX chat bug.

Recently while playing a roblox game, I've came across a bug with the new chat and decided to report this bug to you guys.
There are 2 bugs in this report so I'll report the first one.

Number One:

What-ever you type in will merge with the "To chat click here or press "/" key"

I have video on this bug and how to re-occur it.
VIDEO - https://www.youtube.com/watch?v=56vdFPkx7Ig&feature=youtu.be

Steps: Create a game.
Go to the game
Type anything in the chat then click the screen.
The things you've typed will merge with the "To chat click here or press "/" key"

Second Bug with the new Chat.

The chat disappears once you minimize game.

I have video on how to re-occur this bug.
VIDEO - https://www.youtube.com/watch?v=rIWDxCvSIdQ&feature=youtu.be

Steps: Create a game, or play a game with anyone and tell them to chat.
Minimize the game, then open the game back up.
The chat and words will be gone on the screen, but are in the logs. They're really high up in the scroll thing.
This can cause problems.

Thanks,
manofarmy12.

MarketplaceService:getProductInfo() failed because mc

This error occurs from time to time on line 89 of LoadingScript

coroutine.resume(coroutine.create(function() GameAssetInfo = MPS:GetProductInfo(PLACEID) end))

The following errors also occurs at the same place:

MarketplaceService:getProductInfo() failed because HTTP -1200
MarketplaceService:getProductInfo() failed because HTTP 404 (HTTP/1.1 302 Found)
MarketplaceService:getProductInfo() failed because https://api.roblox.com/marketplace/productinfo?assetId=<PlaceID>: HttpSendRequest, err=0x2EFF

leaderstats is not a valid member of Player

leaderstats is not a valid member of Player
Script 'CoreGui.RobloxGui.CoreScripts/PlayerListScript', Line 2137 - global LeaderstatsAdded
Script 'CoreGui.RobloxGui.CoreScripts/PlayerListScript', Line 2393 - global InsertPlayerFrame
Script 'CoreGui.RobloxGui.CoreScripts/PlayerListScript', Line 3010 - global debugPlayerAdd
Script 'CoreGui.RobloxGui.CoreScripts/PlayerListScript', Line 2978

I believe 2137 to be the culprit, because it uses nplayer.leaderstats, instead of something like nplayer:WaitForChild("leaderstats")

Backpack

CoreGui.RobloxGui.CurrentLoadout.CoreScripts/BackpackScript:995: attempt to index field '?' (a nil value)

BlackFrame is not a valid member of ScreenGui

The following line (370) in LoadingScript causes the error "BlackFrame is not a valid member of ScreenGui "

if currScreenGui.BlackFrame.CountFrame.PlaceLabel.Text == "" then

When teleporting from studio, dialog does not respect CustomizedTeleportUI

See original issue by @Anaminus

---

Currently, when you attempt to teleport from the studio, a dialog pops up indicating that you can't do that. This dialog is displayed even when TeleportService.CustomizedTeleportUI is true.

PlayerListScript doesn't release the TAB key when disabled

I believe most of the other Core Scripts do this, so the 'coreGuiChanged' function in the PlayerListScript should be changed to respect this.

ServerScriptService.SinglePlayerScript:670: attempt to index field 'Character' (a nil value)

This error has occurred 2900 times on my not-especially-popular place since 12-14-2014. Pretty frequent. Most recently, this occurred yesterday with instances of the error occurring each day.

ServerScriptService.SinglePlayerScript:670: attempt to index field 'Character' (a nil value)

I do not have a script named SinglePlayerScript in my place. There isn't a script in the Core-Scripts repo with this name. Should this issue be moved to Anaminus/roblox-bug-tracker?

Spam instancing Hopperbins/Tools in the Backpack causes the client to use excessive memory

If you loop instance Hopperbins or Tools into a Player's Backpack, it causes their client to excessively use memory and can cause the users client and/or computer to crash.

I tried this on my netbook and got a BSoD after 2 minutes, and it slowed down my laptop to the point I had to manually restart.

User created GUIs on Topbar

I want to be able to put other GUIs on the topbar, such as user created GUI buttons to open up GUIs, but the top bar is in the way of clicking them. Please fix

AddCoreScriptLocal is not a valid member of ScriptContext

22:56:34.014 - AddCoreScriptLocal is not a valid member of ScriptContext
22:56:34.020 - Script 'Script Context.StarterScript', Line 11
22:56:34.021 - Stack End

This seems to happen in studio. I just updated to the latest version of the Core Scripts and this seems to be happening.

Clearing leaderstats does not clear player's score

Reproduction steps:

1. Add a leaderboard
2. Kill a couple other players and observe that your score is now 3
3. Destroy your player's leaderstats object
4. Observe that the score is still 3

RequestFriendship should be passed a Player

Source: CoreGui.RobloxGui.CoreScripts/PlayerListScript2

Most recently this error occurs on line 1047.

Mac core script settings issue

http://prntscr.com/3t6xf3
"Font = Enum.Font.Arial;" Line: 400
"gameMainMenuTitle.ZIndex = baseZIndex + 4" Line: 577
"if player == game.Players.LocalPlayer and inStudioMode then" Line: 1325

Joining and leaving quickly can bug out the playerlist

It seems that joining and leaving a game very quickly can bug out the playerlist coregui.

This bug causes the person who joined and left quickly to overwrite your username on the playerlist if you are the only person in the server. Once overwritten, you can expand the playerlist and it will still stay as the overwritten text. You can also click on the overwritten name and you can report the user by clicking the "Report user" button next to it. This will strangely not report yourself but the user who joined and left. If the user who quickly joined and left joins back normally, there will be 2 of them on the other client's screen.

From personal testing, it doesn't seem to work unless you are the only person in the server and the 2nd person joining your server quickly joins and leaves.

To reproduce:

1. Person1 joins a game and stays in a server alone
2. Person2 joins the game and closes out the game as soon as "Bricks: number Connectors: number" or "Waiting for character" is visible
3. Person1 should see Person2 glitched onto the playerlist

dubs, check em

BlackFrame is not a valid member of ScreenGui

Call stack:
LoadingScript, line 508 - global fadeBackground
LoadingScript, line 576

Error in PurchasePromptScript

See original issue by @TheSneak

---

I am seeing this error in Google Analytics using the new GA module:

CoreGui.RobloxGui.CoreScripts/PurchasePromptScript:665: attempt to index upvalue 'currentProductInfo' (a nil value) | CoreGui.RobloxGui.CoreScripts/PurchasePromptScript, line 665 - global canPurchaseItem CoreGui.RobloxGui.CoreScripts/PurchasePromptScript, line 180

Library failed to load | CoreGui.RobloxGui.CoreScripts/Settings, line 16

Perhaps related to #22

CoreGui.RobloxGui.CoreScripts/Settings:16: Library failed to load | CoreGui.RobloxGui.CoreScripts/Settings, line 16

"return" keyword missing

Core-Scripts / CoreScripts / PurchasePromptScript.lua
line 416, in the pcall anonymous function we call settings():GetFFlag(), but the value is never returned. The line should be:

local flagExists, flagValue = pcall(function() return settings():GetFFlag("AddRequestIdToDeveloperProductPurchases") end)

leaderstats is not a valid member of Player

Call stack:

CoreGui.RobloxGui.CoreScripts/PlayerListScript, line 2143 - global LeaderstatsAdded
CoreGui.RobloxGui.CoreScripts/PlayerListScript, line 2391 - global InsertPlayerFrame
CoreGui.RobloxGui.CoreScripts/PlayerListScript, line 3009 - global debugPlayerAdd
CoreGui.RobloxGui.CoreScripts/PlayerListScript, line 3019

New PlayerList: Friending is broken.

When trying to friend a player, icons are not updated properly. Removing a friend does not remove the icon. Reported by QA team.

disabling and re-enabling the backpack bar GUI causes it to bug out

On startup in a LocalScript, I have a function that disables the backpack GUI:

game.StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack,false)

and then, later, re-enables the backpack bar via this:

game.StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack,true)

However, when I re-enable the GUI, it does not function correctly. The tool buttons in the GUI do not automatically relocate themselves. They are not clickable in this state, but they are draggable. Pressing ~ fixes the GUI.

For an example of the bug in action, here's a game of mine that is affected by it: http://www.roblox.com/Testing-Landforge-place?id=7209708

MarketplaceService:getProductInfo() failed because

MarketplaceService:getProductInfo() failed because https://api.roblox.com/marketplace/productinfo?assetId=117931593: HttpSendRequest, err=0x2EE7

Issue with Inventory

When disabling the Inventory CoreGui, if you add a Tool to the player's Character, it will occasionally bug the inventory and cause it to come up again. The new inventory is unusable unless you click on one of the hotkeys and is a problem both technically and graphically.