Giter Site home page Giter Site logo

Comments (5)

destogl avatar destogl commented on May 23, 2024 1

It is working already as it is! I cannot approve the PR in the github workflow unless I'm assigned as a reviewer by a maintainer I guess.

you can always review/approve review. It will just not be green as if a maintainer does it. Nevertheless, it is valuable input fro maintainers knowing that somebody else tested the code and is happy with it 😄

from gazebo_ros2_control.

destogl avatar destogl commented on May 23, 2024

@christophfroehlich can you please test #110 if it fixes your issue?

from gazebo_ros2_control.

christophfroehlich avatar christophfroehlich commented on May 23, 2024

@destogl yes, thanks!
I already implemented something similar like you did last week, but realized that my version sets the initial values at the first simulation step, not before it. (I added a command in the ::write method and not within the ::registerJoints method like you did.)
For my robot this makes a difference, because with the chosen coordinate system it has a self collision with all joint positions being zero. By setting them to an "initial value" at the first simulation iteration, the robot crashes obviously.

from gazebo_ros2_control.

destogl avatar destogl commented on May 23, 2024

@christophfroehlich can you please comment for required changes on #110 or approve PR there?

from gazebo_ros2_control.

christophfroehlich avatar christophfroehlich commented on May 23, 2024

It is working already as it is! I cannot approve the PR in the github workflow unless I'm assigned as a reviewer by a maintainer I guess.

from gazebo_ros2_control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.