ros2/spdlog_vendor

Vendor package for spdlog

Documentation is at https://docs.ros.org

spdlog_vendor's Issues

Progress toward Quality Level 1

This issue tracks the progression of rclcpp to Quality Level 1 and a 1.0 version level. It follows the outline described in REP 2004.

• Version Policy
  • Follows ROS Core Quality Declaration
• Version >= 1.0.0
• Change Control Process
  • Follows ROS Core
• PRs automatically tested on Jenkins

Documentation

• Per-feature documentation.
  • Many features described in different places, but I couldn't find a single unified location.
• Per-item documentation in public API.
  • Doxygen documentation is generated
  • Many API components are undocumented
• Declared set of licenses
• Copyright statement in each source file
• Quality Declaration document

Testing:

• System tests, which cover "features"
  • (Does not apply for vendored packages)
• Tests covering public API
  • (Does not apply for vendored packages)
• Code coverage
  • (Does not apply for vendored packages)
• Performance tests
  • (Does not apply for vendored packages)

• Linters and Static Analysis:
  • Must have a code style and enforce it.
  • Must use static analysis tools where applicable:
    • Linters applied to package.xml and CmakeLists.txt files. See Linters ROS 2 Developer Guide

Dependencies:

• Runtime "ROS" dependencies are level 1
  • None
• non-ROS dependencies are equivalent level 1
  • spdlog (QL 3)

Platform Support

• Supports all tier 1 platforms

Security

• Vulnerability Disclosure Policy

CMake warning on Windows

First appearance in this packaging job https://ci.ros2.org/view/packaging/job/packaging_windows/1700/

  Performing configure step for 'spdlog-1.5.0'

  CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.17/Modules/GNUInstallDirs.cmake:225 (message):

    Unable to determine default CMAKE_INSTALL_LIBDIR directory because no

    target architecture is known.  Please enable at least one language before

    including GNUInstallDirs.

  Call Stack (most recent call first):

    CMakeLists.txt:9 (include)

Build warnings (-Wsign-conversion) under Clang

MacOS Catalina 10.15.4 Beta
Apple clang version 11.0.0 (clang-1100.0.33.17)

--- stderr: spdlog_vendor                                                                                                
In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:484:48: warning: implicit conversion changes signedness: 'int' to 'unsigned long long' [-Wsign-conversion]
          (min_exponent + fp::significand_size - 1) * one_over_log2_10 +
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~  ~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:534:53: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    auto result = static_cast<double_bigit>(bigits_[index]) - other - borrow;
                                            ~~~~~~~ ^~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:535:13: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    bigits_[index] = static_cast<bigit>(result);
    ~~~~~~~ ^~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:541:38: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    while (num_bigits > 0 && bigits_[num_bigits] == 0) --num_bigits;
                             ~~~~~~~ ^~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:542:31: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    bigits_.resize(num_bigits + 1);
            ~~~~~~ ~~~~~~~~~~~^~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:553:40: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      subtract_bigits(i, other.bigits_[j], borrow);
                         ~~~~~         ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:605:25: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigits_[num_bigits++] = n & ~bigit(0);
      ~~~~~~~ ~~~~~~~~~~^~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:608:20: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    bigits_.resize(num_bigits);
            ~~~~~~ ^~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:644:37: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigit lhs_bigit = lhs.bigits_[i], rhs_bigit = rhs.bigits_[j];
                        ~~~         ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:644:65: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigit lhs_bigit = lhs.bigits_[i], rhs_bigit = rhs.bigits_[j];
                                                    ~~~         ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:659:62: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      return i >= n.exp_ && i < n.num_bigits() ? n.bigits_[i - n.exp_] : 0;
                                                 ~         ~~^~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:699:20: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
    bigits_.resize(num_result_bigits);
            ~~~~~~ ^~~~~~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:707:44: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        sum += static_cast<double_bigit>(n[i]) * n[j];
                                         ~ ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:707:52: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        sum += static_cast<double_bigit>(n[i]) * n[j];
                                                 ~ ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:709:15: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigits_[bigit_index] = static_cast<bigit>(sum);
      ~~~~~~~ ^~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:716:45: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        sum += static_cast<double_bigit>(n[i++]) * n[j--];
                                         ~ ~^~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:716:55: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        sum += static_cast<double_bigit>(n[i++]) * n[j--];
                                                   ~ ~^~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:717:15: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigits_[bigit_index] = static_cast<bigit>(sum);
      ~~~~~~~ ^~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:735:33: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      bigits_.resize(num_bigits + exp_difference);
              ~~~~~~ ~~~~~~~~~~~^~~~~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:737:17: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        bigits_[j] = bigits_[i];
        ~~~~~~~ ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:737:30: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
        bigits_[j] = bigits_[i];
                     ~~~~~~~ ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1031:18: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      buf.resize(num_digits);
          ~~~~~~ ^~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1077:47: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      while (num_digits > 0 && buf[num_digits - 1] == '0') {
                               ~~~ ~~~~~~~~~~~^~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1182:30: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(p, p + 1, fraction_size);
      ~~~                    ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1211:42: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(begin + 1, begin + 2, fraction_size);
      ~~~                                ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1213:16: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
    buf.resize(fraction_size + offset + 1);
               ^~~~~~~~~~~~~ ~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1182:30: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(p, p + 1, fraction_size);
      ~~~                    ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:156:40: note: in instantiation of function template specialization 'fmt::v6::internal::snprintf_float<double>' requested here
        template FMT_API int internal::snprintf_float(double, int,
                                       ^
In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1211:42: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(begin + 1, begin + 2, fraction_size);
      ~~~                                ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1213:16: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
    buf.resize(fraction_size + offset + 1);
               ^~~~~~~~~~~~~ ~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1182:30: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(p, p + 1, fraction_size);
      ~~~                    ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:159:40: note: in instantiation of function template specialization 'fmt::v6::internal::snprintf_float<long double>' requested here
        template FMT_API int internal::snprintf_float(long double, int,
                                       ^
In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1211:42: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
      std::memmove(begin + 1, begin + 2, fraction_size);
      ~~~                                ^~~~~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1213:16: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
    buf.resize(fraction_size + offset + 1);
               ^~~~~~~~~~~~~ ~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1077:47: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      while (num_digits > 0 && buf[num_digits - 1] == '0') {
                               ~~~ ~~~~~~~~~~~^~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:162:40: note: in instantiation of function template specialization 'fmt::v6::internal::format_float<double>' requested here
        template FMT_API int internal::format_float(double, int, internal::float_specs,
                                       ^
In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1077:47: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      while (num_digits > 0 && buf[num_digits - 1] == '0') {
                               ~~~ ~~~~~~~~~~~^~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:164:40: note: in instantiation of function template specialization 'fmt::v6::internal::format_float<long double>' requested here
        template FMT_API int internal::format_float(long double, int,
                                       ^
In file included from /opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/src/fmt.cpp:10:
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1031:18: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      buf.resize(num_digits);
          ~~~~~~ ^~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1108:7: note: in instantiation of function template specialization 'fmt::v6::internal::fallback_format<double>' requested here
      fallback_format(value, buf, exp);
      ^
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1031:18: warning: implicit conversion changes signedness: 'int' to 'std::size_t' (aka 'unsigned long') [-Wsign-conversion]
      buf.resize(num_digits);
          ~~~~~~ ^~~~~~~~~~
/opt/ros/master/build/spdlog_vendor/spdlog-1.5.0-prefix/src/spdlog-1.5.0/include/spdlog/fmt/bundled/format-inl.h:1108:7: note: in instantiation of function template specialization 'fmt::v6::internal::fallback_format<long double>' requested here
      fallback_format(value, buf, exp);
      ^
36 warnings generated.
---
Finished <<< spdlog_vendor [6min 45s]