roynalnaruto/eth-keystore-rs

A minimalist library to interact with encrypted JSON keystores

eth-keystore-rs's Issues

the dependency of many crypto related crates are outdated.

and their interfaces have changed a lot...

Fine grained control of file names when writing keystore files

Currently files are written by convention using the UUID as the file name but I would prefer to follow the newer convention that geth uses which is UTC date concatenated with the public address of the key.

Also I have a use case for the keystore where I am storing other private secrets (for TOTP authentication) which I would like to write using a fixed file name, eg: totp.json.

If I do the work to allow callers to set the file name will you be willing to land the changes?

Thanks 🙏

feature request: add non standard `address` field to `EthKeyStore`

While it is not defined as part of the spec and could be interpreted as bad for privacy, geth serializes the address that corresponds to the key as part of the keystore JSON. What do you think about adding an Option<[u8; 20]> or Option<String> that represents the address field to the EthKeyStore?

Example of a key created by geth:

{
  "address": "00000398232e2064f896018496b4b44b3d62751f",
  "crypto": {
    "cipher": "aes-128-ctr",
    "ciphertext": "4f784cd629a7caf34b488e36fb96aad8a8f943a6ce31c7deab950c5e3a5b1c43",
    "cipherparams": {
      "iv": "76f07196b3c94f25b8f34d869493f640"
    },
    "kdf": "scrypt",
    "kdfparams": {
      "dklen": 32,
      "n": 262144,
      "p": 1,
      "r": 8,
      "salt": "1e7be4ce8351dd1710b0885438414b1748a81f1af510eda11e4d1f99c8d43975"
    },
    "mac": "5b5433575a2418c1c813337a88b4099baa2f534e5dabeba86979d538c1f594d8"
  },
  "id": "6c4485f3-3cc0-4081-848e-8bf489f2c262",
  "version": 3
}

Relevant struct in geth: https://github.com/ethereum/go-ethereum/blob/fb3a6528cfa49f623570575c4fe9e8a716cfcdf7/accounts/keystore/key.go#L67