Giter Site home page Giter Site logo

adventurebackpack2's Issues

Add checks for valid block data in Block#getEnchantPowerBonus

This issue is related to the conflict between AdventureBackpack2 and Wawla. The issue is caused by Wawla making a call to Block#getEnchantPowerBonus while hovering over a block in the inventory. The goal of this is to add the enchanting bonus to the tooltip of the block. Since the Inventory does not have access to XYZ coords some devs will use Origin (0,0,0) or the players position for this.

I patched this issue on Wawla's end by swallowing the exception, however to improve performance and to futureproof AdventureBackpack you should look into adding some safety checks on your end. After looking into your mod source, adding a check to see if the TileEntity is null in BlockAdventureBackpack#getAssociatedTileColorName and return an empty or error name would completely resolve this issue.

    private String getAssociatedTileColorName(IBlockAccess world, int x, int y, int z)
    {
        final TileEntity tile = world.getTileEntity(x, y, z);
        return (tile instanceof TileAdventureBackpack) ? ((TileAdventureBackpack) tile).getColorName() : "error";
    }

Item duplication bug

Whilst wearing an adventure backpack with one non tool item on the hotbar and the rest filled with tools like wooden shovels I am able to quickly scroll through them while quickly tapping shift and this allows you to dupe the non tool item. The tools get replaced by whatever item you had on the hotbar. I tested this in both singleplayer and multiplayer and both had the same results.

Client-Server inventory sync

Something wrong with visual updating backpack inventory on content changing.
As sample: Pick up stack of dirt from main inventory by lclick; put just 1 dirt to backpack by rclick; lclick 63 remaining units to same slot; backpack shows only one piece of dirt.
Or shift-click 1 dirt from main inventory to backpack; then shift-click some more (but less then 64); again shows only one piece of dirt. And so on.
Its only visual mess. After reopening backpack shows all stacks as intended.

Milk Render Issues

I am currently under the impression that the issue persists within world save data, given that the issue doesn't present itself on a new world with the same mods and configs yet also does persist on the "corrupt" world with a new character. I do not know if this issue will always eventually present itself within my modpack or if it is a result of upgrading from adventure backpacks 0.8c to 0.9g within this same world.

I am currently planning on migrating to a new world.

Quoted from Minecraft Forum:

Hi Runescapejon,

thank you for continuing to update the mod, it's one of my favorites.

I am hosting a server for me and my nephew running a custom modpack and I'm running into some rendering issues. I think I've tracked it down to when adding milk to the standard backpack tank (possibly other things).

In multiplayer run on a dedicated server(singleplayer appears to work perfect), after using the hose or a bucket (buckets sometimes get eaten) to fill a tank with milk there will be significant render issues

the effect when wearing is:

water doesn't render in world
the toolbar is darkened
techguns chemical laboritory (highly dynamic /w tanks and moving parts) renders the clear glass tank effect above the machine
the tanks and tools on the backpack render above and to the right of the player
atleast the adventure backpacks items in NEI render as if on fire
NEI is not offset like it is when just holding and viewing a backpack
drinking from the hose does not work for water or milk

when simply viewing the backpack:

the NEI gui renders as if it's top and left sides are lined up with the backpack gui

NOTE:

setting in the config to have the tank overlay not render on the hud will stop some of the issues in world
before messing around with milk I also noticed that when putting items into the backpack the item counts would not update unless the backpack was closed and opened
Singleplayer appears to work correctly allowing the picking up, rendering in overlay, and drinking of milk and other liquids.
there have been crashes, most notably when I switch the tank render type to 1 or 2 and try viewing a backpack, but overall it hasn't crashed it just renders wrong and breaks some of the mods mechanics.

I am running:

codechickencore 1.0.7.47
adventurebackpacks 0.9g beta 1
forge 10.13.4.1614

I will try a new server with just adventure backpacks to see if it isn't another mod and post my findings

any help would be appreciated, let me know if you need more info.

Thank you

EDIT:

I created a basic server with adventure backpacks and codechickencore and the mod worked perfectly which would mean it's a mod conflict, I'm going to try getting the mod to work by process of elimination and see which mod is conflicting.

EDIT AGAIN:

I copied all my mods and configs to the new server and it worked flawless, could not get it to fail. I then shutdown and copied the contents of the level save folder including the level.dat and all other folders and files in there (but I didn't copy over the usercache/usernamecache so it was a new player save), loaded it up and it failed. I went into creative and started breaking everything that I could think of that does any unique rendering to no avail. I tried a bunch of other liquids and it looks like it's only milk. I'm thinking the level is corrupt somehow since the player was brand new, it might have to do with having the older 0.8b version of adventure packs installed and then updating.

Question: How to switch tools?

I just updated to the latest version (f-beta-12) and shift+scroll doesn't switch my tools anymore. How do I do that now?

want a fix

I request a fix:
If backpack in hand, and it's stack of backpack (>1) then
I offer to make it so that it does not open.

There is another way to dup:
Make stack of backpack, then open it, put item, close it.
Then unstack backpacks, and get items back.

1.7.10-h1 Server Crash (Thaumcraft?)

Server crash occurs when wand is placed in tool slot. (Client not affected except for loss of wand)
Server crash when Thaumcraft item put into backpack inventory. (Client not affected except server closing)
Client exception and server disconnect when shift+scroll wheel wand.

Server Crash Report
https://pastebin.com/ZQj5LPWy

Texture Error's

When i updated my modpack, and with it Adventure Backpacks to the latest version from releases, i get this error when joining a world/server:

[21:34:58] [Client thread/WARN]: Failed to load texture: adventurebackpack:textures/models/adventurepants_texture.png
java.io.FileNotFoundException: adventurebackpack:textures/models/adventurepants_texture.png
    at net.minecraft.client.resources.FallbackResourceManager.func_110536_a(SourceFile:51) ~[bqq.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.func_110536_a(SimpleReloadableResourceManager.java:67) ~[brg.class:?]
    at net.minecraft.client.renderer.texture.SimpleTexture.func_110551_a(SourceFile:29) ~[bpu.class:?]
    at net.minecraft.client.renderer.texture.TextureManager.func_110579_a(TextureManager.java:94) [bqf.class:?]
    at net.minecraft.client.renderer.texture.TextureManager.func_110577_a(TextureManager.java:50) [bqf.class:?]
    at net.minecraft.client.renderer.entity.Render.func_110776_a(SourceFile:51) [bno.class:?]
    at net.minecraft.client.renderer.entity.RenderPlayer.func_77032_a(RenderPlayer.java:67) [bop.class:?]
    at net.minecraft.client.renderer.entity.RenderPlayer.func_77032_a(RenderPlayer.java:491) [bop.class:?]
    at net.minecraft.client.renderer.entity.RendererLivingEntity.func_76986_a(RendererLivingEntity.java:157) [boh.class:?]
    at net.minecraft.client.renderer.entity.RenderPlayer.func_76986_a(RenderPlayer.java:158) [bop.class:?]
    at net.minecraft.client.renderer.entity.RenderPlayer.func_76986_a(RenderPlayer.java:521) [bop.class:?]
    at net.minecraft.client.renderer.entity.RenderManager.func_147939_a(RenderManager.java:293) [bnn.class:?]
    at net.minecraft.client.renderer.entity.RenderManager.func_147940_a(RenderManager.java:276) [bnn.class:?]
    at net.minecraft.client.gui.inventory.GuiInventory.func_147046_a(SourceFile:91) [bfu.class:?]
    at net.minecraft.client.gui.inventory.GuiInventory.func_146976_a(SourceFile:60) [bfu.class:?]
    at net.minecraft.client.gui.inventory.GuiContainer.func_73863_a(GuiContainer.java:78) [bex.class:?]
    at net.minecraft.client.renderer.InventoryEffectRenderer.func_73863_a(InventoryEffectRenderer.java:38) [bfo.class:?]
    at net.minecraft.client.gui.inventory.GuiInventory.func_73863_a(SourceFile:47) [bfu.class:?]
    at net.minecraft.client.renderer.EntityRenderer.func_78480_b(EntityRenderer.java:1400) [blt.class:?]
    at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1001) [bao.class:?]
    at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898) [bao.class:?]
    at net.minecraft.client.main.Main.main(SourceFile:148) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]

And my skin is glitched: http://prntscr.com/cmcrg9

Somehow disabled Tool Cycling

Tools were cycling properly at first but for some reason when using command line to switch game modes it disabled (even checking command history showed no wrong commands). Now sneak+mouse wheel does nothing. Please help.

Transferring inventory from the ingredient backpack to the crafted backpack

Здравствуйте, я недавно столкнулся с небольшой проблемой.
Она заключается в том что игрок по собственной невнимательности использует рюкзак содержащий предметы в рецептах крафтов, в результате чего теряет первоначальное содержимое своего рюкзака.

Я прошу сделать так, чтобы рюкзак содержащий в себе предметы не мог быть использован в рецептах крафтов.

Performance issue (Adventure Backpacks taking 60% on player tick)

Hey,

currently the entire backpack data including all its contents is being sent to the client on every tick. This is a major overhead causing the backpack mod to eat up 60-80% of a servers resources when used a lot and filled up.


My suggestion is to 1. only sent the required data, 2. reduce the frequency (e.g. every 20th tick).

Crash when filling water bottle from backpack on a multiplayer server

Crash log here https://pastebin.com/gaWL6NbQ

Tried just placing one empty bottle in the slot, shift clicking, etc. Anything that puts a bottle in that slot crashes the game. Can't get the issue to pop up in singleplayer unfortunately. Tried both the latest Darkona version and the latest RunescapeJon version and it crashes on both. I've also had it happen once or twice with buckets but I've been testing further with buckets and I can't reproduce the issue.

Dupe :>

GIF

As you can see, if you drop the backpack and open it's GUI quick, you will be able to interact with the items, and drop them. I suggest cancelling the item move event instead just blocking all the slots.

Visual bug scrolling with a Robit

Same as #15 , but with a Robit instead. I can't test the rest of the items ATM, but the problem seems to be with all electric items with a special model/render.

Dragon backpack dissapeared on death

I recently died with a dragon backpack enchanted with Soul Bound. Ive died many many times with it, but for some reason this morning the backpack was gone. We're using the latest rev of the mod, on GTNH. Extra Utilities is installed but the packs never been in the grave. There was some slabs nearby but, I died about 5 blocks below them. Do bags share inventories per player? Can I get my stuff back via recrafting?

Using adventurebackpack-1.7.10-0.9gbeta18

[Request]First time spawn with loot

Hey, I saw on the forum you said to post it here, so here it is. I'm a bit lazy so I'm basically copy pasting from the forum post.

Hey. Nice to see someone is keeping this mod updated, there is one feature I'd like to suggest, though. The ability to give the player a backpack with certain items in it when they spawn in the world for the first time. It would be really useful for modpack creation so that the player is surprised when opening the backpack for the first time. I'm not sure how hard this would be to implement, as I don't really have experience with programming. But, no harm in suggesting it right? :)

Shift key not working as intended

Whenever you try to use the shift key with AdventureBackpack2 items, be it the hose which can be used to interact with the backpack's tanks, or an(y) item that is placed in the green tool slots within the backpack in order to swap between the tools by scrolling as it was working before, that shift key doesn't seem to have any function anymore.
EDIT: Seems as if this issue has been existing since beta10.
EDIT2: Just built the current AdventureBackpack2-master (Version 0.8d) and found out that the bug does not exist there.

[Request] Expanding the mod to versions beyond 1.7.10

Hey, I saw from this issue where you stated that you were only going to make the mod available to only 1.7.10.. my question is why cut it to only 1.7.10? Doing that cuts out many people who are using 1.8+ (including myself). Even advanced mods like Dr.Zhark's Mo Creatures are at least on 1.10.2, giving a possible future for 1.11.2 updates. I understand updating mods takes a very long time (I used to develop a mod myself, but I got extremely busy with school so I don't have free time anymore), but at least make an effort on going for versions beyond 1.7.10. You could even skip some versions and go straight to 1.11.2 if you need to. Indeed, I did try updating my mod to major updates (I had an especially hard time with 1.8 since it changed numerous components with block positioning), so I do understand why you might want to stick to 1.7.10. However, realistically (and practically), it would make more sense to move on to 1.8 and beyond as it would allow more people to get their hands on the mod without having to clone worlds just to run one mod on a different Minecraft version, while at the same time sacrificing several other mods that only supports versions 1.8 and beyond. Sorry for this really long sort of 'speech', but I just wanted to clarify my reasoning on suggesting this.

Integration with HungerOverhaul

Hey, add please integration with HungerOverhaul.
That will add this integration?
This integration can add the weight of the backpack, for example if a player wears a full backpack, the faster it will be spent the level of food, and if empty a bit slower.

I hope this is possible)

Losing backpack if BlockPlaceEvent is cancelled

Steps to reproduce:

  1. Have a plugin/mod (such as MyTown2 or GriefPrevention) that cancel BlockPlaceEvent
  2. Give yourself a backpack, and try to place it on the ground. The event will be cancelled, the block removed from world and you won't get your backpack again.

Add Backpack to the Gravestone instead dropping it as item

In my server, I disabled the feature that places the backpack in the ground because it was causing some issues. Then, every time a player die, the Backpack is dropped as item, different from the other items that are stored in the Gravestone from OpenBlocks. The result is, the players get again their items from the grave, but the backpack sometimes despawn or is cleared...

Enforce the server config on client

Even disabling effects in the client, players can just enable them and get the effects back again. A suggestion would be enforce the use of the server config on connect.

Small visual bug & question

firstly with the new coal jetpack, when hovering over the item looking at the recipe in NEI, the name doesn't appear. (See below)
2017-04-16_08 59 11

And now for the question. With the new changes to the register method for the 2 jetpacks, when I changed my CraftTweaker script to follow the new format, it doesn't change the recipe and keeps giving errors
My script:
recipes.remove(adventurebackpack:copterPack.withTag({}));
The error received is Error parsing test.zs:2 -- ) expected

Any help is appreciated and thanks for keeping a great mod going.

Temporary loss of a bag

If have 2 bags in inventory and place one on the any block, then the second bag (which didn't placed) vanishes from inventory. When recalling a game, the bag comes back to stock.
You will fix this unpleasant bug?
Version of mod - Beta-0.8eb28.
There is a similar bug, on servers. If to place a bag to others region (WorldGuard), then it vanished from inventory and returns when rejoining.

Is it possible to bridge with BungeeCord?

This mod is nice, but I have a bungee network, and the players can't use/see/wear backpacks when they connect a server trough the lobby, and I can't use Forced Hosts by a while... Is there a workaround, or?

Dimension Blacklist

Would be nice a config that don't let players open/access a backpack in certain dimensions. This is usefull because some players are using backpacks to transport items between overworld and witchery dream dimension...

Backpacks disappear after death using OpenBlocks

I have a server and i have OpenBlocks and Adventure Backpacks, both installed. When a player dies in a dimension with keepInventory = false, OpenBlocks place a grave on the ground, and save player's items.

But i remember that Adventure Backpacks have also a feature that place the backpack from the dead owner on the ground. I think they are spawning in the SAME place.
When i die, a OpenBlocks grave spawns, and my backpack not. Then, i lose everything inside. Is it designed to be, or this is a bug?

Shuffle Disable

Add a way to disable the item shuffle when you shift scroll on a tool

bug with backpack

open backpack
move in item
close backpack
put backpack in first hotbar slot
open backpack
mouseover item press 1 key
close backpack
open backpack
and item stay in backpack too

Drinking a water bottle gives regeneration effect

Hey, just thought i better let you know that for some when you drink a normal water bottle it gives you a regen effect. I'm not sure if this a bug or not, but i thought it best to let you know anyways.

Thanks, SC.

Tested in the latest version (beta-24)

2016-06-11_10 20 17

Bag despawned on server reconnect

Version: 0.9gbeta9
Reconnecting to the server caused the backpack to disappear, even though it still called the lines of "Joined EntityPlayer and Stored properties retrieved".
This has only happened once and I can't reproduce it.
Video: https://youtu.be/xuD0qR4GiGk

RIP tinkers tools in backpack.

Turn the GUIs server-side

When you open a backpack, the GUI shows up fast, like if it wouldn't asking the server for opening the container. If the PlayerInteractEvent is cancelled, the GUI still open, and cause some issues, like players being kicked for bad packet, etc...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.