Comments (3)
This is more challenging than required arguments; as we don't necessarily have a value, we can't just set a variable in the caller. So there are a few options:
- convert all parsed arguments to
Option
s - only make optional arguments
Option
s - put optional arguments in to some sort of container (like a
HashMap
), that could also capture their optionality
The first option would make required arguments more verbose, without any real gain; so I'd prefer not to do that.
The other two options are both pretty good; using an Option
feels like a better model, but might be harder to implement. In particular, specifying the macro pattern in a way that distinguishes between the Option and non-Option argument variables proved challenging when I was playing around with this locally. Even with the HashMap option, we would still have to work out how to specify the optional arguments in a good way.
A separate macro might make either of them much easier, but then the caller would be responsible for hooking up the macros (as the second would depend on how many arguments the first had consumed), which is best avoided, I think.
from rustpython.
Option 2 sounds best to me too.
At some point we have to deal with keyword arguments too, and the fact that the caller can pass positional arguments as keyword arguments.
from rustpython.
Oh, oops, didn't mention this in the PR, I guess; I fixed this with #96 (using option 2!).
from rustpython.
Related Issues (20)
- Crash about overflowing max_stackdepth
- how to run python module
- Extremely high memory consumption HOT 2
- zlib not found after install with `--features ssl`
- Trying to jit fibonacci function results in JitError: function can't be jitted
- Fix Windows CI HOT 3
- Investigate test_set.TestFrozenSet.test_hash_effectiveness performance
- Make vm.import_from_str() so we can import string python programs as modules HOT 1
- RustPython Slow to Normal Python HOT 2
- Add `__buffer__` and `__release_buffer__` methods to builtin types
- `format()` does not support locales for 'n' presentation type HOT 1
- Failed cargo install with SSL feature under linux (RustPython 0.3.0) HOT 4
- Dictionary order influences parseability HOT 3
- AttributeError: module 'typing' has no attribute 'Unpack'
- Compile error: cannot transmute between types of different sizes, or dependently-sized types [E0512] HOT 2
- Fix failing unit tests HOT 7
- UTF8 encoding messy code HOT 2
- "static type has not been initialized" when type lives in another module HOT 3
- error[E0635]: unknown feature stdsimd
- Using underline in an interactive environment cannot obtain the value of the last input expression. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rustpython.