Giter Site home page Giter Site logo

Comments (3)

OddBloke avatar OddBloke commented on May 13, 2024

This is more challenging than required arguments; as we don't necessarily have a value, we can't just set a variable in the caller. So there are a few options:

  • convert all parsed arguments to Options
  • only make optional arguments Options
  • put optional arguments in to some sort of container (like a HashMap), that could also capture their optionality

The first option would make required arguments more verbose, without any real gain; so I'd prefer not to do that.

The other two options are both pretty good; using an Option feels like a better model, but might be harder to implement. In particular, specifying the macro pattern in a way that distinguishes between the Option and non-Option argument variables proved challenging when I was playing around with this locally. Even with the HashMap option, we would still have to work out how to specify the optional arguments in a good way.

A separate macro might make either of them much easier, but then the caller would be responsible for hooking up the macros (as the second would depend on how many arguments the first had consumed), which is best avoided, I think.

from rustpython.

cthulahoops avatar cthulahoops commented on May 13, 2024

Option 2 sounds best to me too.

At some point we have to deal with keyword arguments too, and the fact that the caller can pass positional arguments as keyword arguments.

from rustpython.

OddBloke avatar OddBloke commented on May 13, 2024

Oh, oops, didn't mention this in the PR, I guess; I fixed this with #96 (using option 2!).

from rustpython.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.