Comments (9)
Awesome!
from johnny-five.
I've been able to use the list method to get detection/connection working on my Windows and Ubuntu machines. I don't have an OSX machine around to ensure it is working properly there, however. Not sure if it's an acceptable change, but take a look and let me know if everything looks good:
https://github.com/randallagordon/johnny-five/tree/windows
from johnny-five.
@randallagordon can you make a PR :D
from johnny-five.
Will do!
from johnny-five.
YES! Exciting :)
I don't have any way of testing windows, so we're going to have to work together on ironing this out, I hope you have you're ready to be super patient ahah
from johnny-five.
@randallagordon I had to make an executive decision between landing this or #111 first. Based on how minimal your changes are, I decided that you might not mind if I did #111 first and then you could re-apply these changes? (sorry if that's a total pain in the ass)
from johnny-five.
Ok, I just tried merging this myself and I think we're better off letting you do it. Be warned, there is a lot of whitespace and large code movement changes, but I think your patch can still be easily written in. (sorry for messing this up)
from johnny-five.
No prob, that's the way I would have gone! However, it will be week or two before I can get around to it as I'm in the middle of moving at the moment.
I believe that #111 will allow for us Windows folks to specify a COM port and be good to go, too. Not quite as nice as auto detection, but I think it should work. Now that it has been merged, I'll give it a shot as soon as I get back to an Arduino.
from johnny-five.
No prob, that's the way I would have gone! However, it will be week or two before I can get around to it as I'm in the middle of moving at the moment.
I'm patient :)
I believe that #111 will allow for us Windows folks to specify a COM port and be good to go, too. Not quite as nice as auto detection, but I think it should work. Now that it has been merged, I'll give it a shot as soon as I get back to an Arduino.
Indeed—this is actually why I decided to land that one first, but you're right: windows needs the auto-detection! I'll keep my mits out of Board until you wrap this up :)
Thanks again for this!
from johnny-five.
Related Issues (20)
- Novice ask next how to upload js to hardware HOT 7
- Using PWM and AC DImmer RobotDyn
- Cannot Input Mode Pin 12, 14, 15. ESP8266 HOT 4
- Refactor DS18B20 Temperature Conversion Time Handling
- Usage with Electron of latest J5 versions? HOT 6
- Status of Release?
- Using a Coin selector
- CAN bus with mcp2515 support, and other libraries
- MKR 1010 board HOT 1
- INPUT_PULLUP on digital input pin HOT 12
- I2C Scanner?
- Input pull-up doesn't work on expanders HOT 1
- Unable to use Led.Digits with Multple Boards HOT 4
- Stop stepper while running HOT 2
- Servo animation enqueue is buggy HOT 6
- Calling animation.next inside onloop callback is not working.
- Sensor disable only works once. HOT 3
- Is there a way to use multiple I2C LCD's HOT 2
- RaspberryPi issue HOT 3
- Intermittent Error Code 31 in GetOverlappedResult
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from johnny-five.