saltnpixels/ignition

The Starter Theme that Could

ignition's Issues

4.0 source mapping?

Notice that when inspecting styles i'm not seeing any source mapping - is there a way to enable sourcemap output by default?

Mobile menu pushing content in Safari

Spotted an issue with the mobile navigation in Safari, it moves the whole site across instead of over the top

Ignition expects you to have ACF Pro installed so you can utilize all of its goodness. So go buy and install ACF Pro!

What happens/breaks if you don't have ACF pro?

Issues creating a new page template

Hi!
I started working with your theme a few days ago. I read the documentation, but it seems I can't make WP recognize my homepage template.
I created _homepage.php into the parts folder, but Ignition doesn't seem to notice it. When I go into the new page's backend and try to select my template in the "page attributes" section, I don't find it there. All I can see is Default, Sidebar Left and Sidebar Right.
Same thing happens for mi sccs file which I named _homepage.scss (in parts folder). It's like Ignition doesn't see it.

I really appreciate your help in solving this issue, I'm sure there must be something stupid I'm missing!

Many thanks,

Eleonora

Logo not centered in logo-in-middle position/display bug

When selecting logo-in-middle option the logo is not centered on the page. I had 3 top level menu items, which means the extra item to the left pushes the logo off center. When I add another top level menu item, the logo no longer displays until removing the new item and selecting another logo position.

Degiterror: could not find commit hash for HEAD

Any idea why npx command isnt working?

Error in Mixin

When Compiling sass It throws error here
Running "sass:dist" (sass) task Error: Invalid CSS after " @if($sizeValue ": expected ")", was "= 16){" on line 6 of assets/sass/site/_mixin.scss
Changing to @if($sizeValue : 16) fixes it

I am using grunt btw if that makes a difference

localhost times out

Hello! Sorry for the frank title of this issue. 😐 I've just started to try out Ignition, but when running npm start a https://localhost:3000 window opens up and then stalls out with the message "localhost didn’t send any data.
ERR_EMPTY_RESPONSE."

I see that Browsersync is running as expected on port : 3001, so I'm not sure where the issue lies:

[Browsersync] Proxying: http://flps.local
[Browsersync] Access URLs:
 ------------------------------------
       Local: https://localhost:3000
    External: https://flps.local:3000
 ------------------------------------
          UI: http://localhost:3001
 UI External: http://localhost:3001
 ------------------------------------
[Browsersync] Watching files...

Let me know what information I should provide and I'll post it.

Thank you~~

WP-SCSS compatibility with 4.0

I'm about to start my first build using Ignition after abandoning my own bones / flexbox based starter and while i know the previous version of ignition worked with wp-scss (useful for compiling changes after launch say.) i'm curious if v4 continues that compatibility and if so - what output settings show be used?

Thanks and much appreciate the work you've done here - i've been scouring the web for a starter theme with the right combination of technology / workflow / and approachability. So many are great but over engineered to the point of not really being "WordPress" anymore, yours feels WordPressy while making a number of workflow improvements. Kudos!

s github

Issue with Webpack and Docker

Hi!
I've installed Ignition theme a couple of times.
Everything seems to be ok, but when I run Webpack my browser opens a new tab (localhost:3001) which keeps on loading forever.
I'm starting to think the problem is with Docker and Webpack.

Here's my docker-compose.yml file:

version: '3'

services:
  # Database
  db:
    image: mysql:5.7
    volumes:
      - db_data:/var/lib/mysql
    restart: always
    environment:
      MYSQL_ROOT_PASSWORD: root
      MYSQL_DATABASE: ellietest
      MYSQL_USER: root
      MYSQL_PASSWORD: root
    networks:
      - wpsite
  # phpmyadmin
  phpmyadmin:
    depends_on:
      - db
    image: phpmyadmin/phpmyadmin
    restart: always
    ports:
      - '8080:80'
    environment:
      PMA_HOST: db
      MYSQL_ROOT_PASSWORD: root 
    networks:
      - wpsite
  # Wordpress
  wordpress:
    depends_on:
      - db
    image: wordpress:latest
    ports:
      - '3000:80'
    restart: always
    volumes: ['./wp-content:/var/www/html/wp-content']
    environment:
      WORDPRESS_DB_HOST: db:3306
      WORDPRESS_DB_NAME: ellietest
      WORDPRESS_DB_USER: root
      WORDPRESS_DB_PASSWORD: root
    networks:
      - wpsite
networks:
  wpsite:
volumes:
  db_data:

...and my theme.config.json:

{
  "name": "Ellie",
  "slug": "ellie",
  "server": "localhost:3000",
  "google_fonts": [
    "Roboto:400,400i,700,700i",
    "Roboto Slab:400,700"
  ],
  "menu_icon": "",
  "sidebar_icon": "",
  "submenu_arrow_icon": "",
  "comment_icon": "",
  "search_menu_item": false,
  "dev_admin_bar_color": "#156288",
  "admin_access_capability": "manage_options",
  "load_custom_icons": false,
  "mobile_menu_type": "app-menu",
  "logo_position": "logo-left",
  "site_top_container": "container",
  "default_acf_header_block" : ["post", "page"]
}

If I go to localhost:3000 I'm able to see new templates and html additions, but none of the css I add.
is there something I'm missing?
Sorry, I'm new to Webpack and I don't know how to configure it in order to make it work.

I really like your theme and I'm looking forward to starting develop with it!

Thanks for your help!

Eleonora

Possible CSS incompatibility with WP5.4 post admin area

After upgrading on a fresh install of ignition i've noticed strange resizing issues with the sidebar in the page/post editor - where the sidebar when visible, causes the editor area to reduce in size by half and only occupy half of the visible screen.

Digging into the CSS i saw this bit of CSS in the Gutenberg SASS

@media (min-width: 768px) #wpwrap .edit-post-layout.is-sidebar-opened .edit-post-sidebar { width: 30%; }

disabling that bit of CSS in the gutenberg-editor-styles.scss seems to fix the issue.

Right sidebar for mobile

Hi!

First of all, thanks for the development of this theme. It really is a powerful tool when a blank template is needed.

But I found myself quite lost when I "just" needed to have my mobile hamburger menu moved to the right. That's because of the whole sidebar left / right behavior. I guess the theme wasn't intended to have the mobile menu in the right sidebar.

Would it be something worth adding to the theme ? Maybe in the theme config file ? Or just to simplify the sidebar left / right handling so that it is easier to move content between one and the other.

Regards,

Questions || Ignition deployment

As I don't find a contact or question of FAQ on the website. I'm going to ask my questions here.

I find the gap in knowing basic coding for web and the jump it makes to deploying or managing WordPress based systems is a big jump.

Is it possible to host ignition on a shared hosting where there is no possibility to enter a command line or install node.js.

What kind of hosting should I have when I'm unable to do the former.

And is this platform thus made for making websites for simple portfolio's.

To you, they must look like obvious simple questions. But to me they would be a great help in finding the correct tool and or host in the maze of a zillion possibilities.

Prev/Next Pagination on index.php is missing their icons

Index.php is trying to grab the angle-left/right icon from the "old" removed icon folder. I've updated my dev copy to use chevron-left/right from iconify, but I don't currently have it on GitHub to submit a PR.

Gutenberg insert image "full width" not 100% width

I've noticed that when inserting an image via Gutenberg and then selecting its alignment as "full width" the image doesn't stretch all the way across the page:

I've been trying to work out why, seems to be something to do with max-width of the wp-block-image

.wp-block-image { max-width: 100%; }

'Set Value as Class' not in consistent position

Hello,

I noticed the 'Set Value as Class' field has a different position when editing a Text Field and a Email Field. For the Text Field it's after the Character Limit before the Conditional Logic. On the Email Field it's right after the Admin Only? field before the Default Value.

Text Field;

Email Field;

Would be nice to have this consistent across fields.

Thanks

Skipping terminal and installing directly through the Themes "Add New" button?

Hey

I happen to not use terminal first and went straight to installing the theme. It seems that all styles were stripped.
What about having a way to just installing the theme through the "Add New" button in the themes panel?

Btw
I am checking to also see that the theme is updated on occasion.

best way to have an ignition version of front-page.php?

One thing that isn't immediately clear to me from the docs is how to achieve a completely different home page where a page is specified as a static home page.

Usually, I'd have a front-page.php template. But that doesn't seem like it is the Ignition way of doing things? I'd guessed at using the parts approach but that seems to work only with post types?

Is there an easy way of doing this or do I just use a front-page.php file, like I normally would and create that from a copy of page.php?

Catalina, node-gyp error, can't run create-ignition-theme

Hello,

I'm trying to try ignition, but I can't get it up and running. I've been trying to run create-ignition-theme via npx for a couple days. I keep running into an error that seems to be related to fsevents package being out of date, and not compatible with node-gyp.

I've gone down a rabbit hole of re-installing xcode and xcode command tools several times (which as you probably know is pretty time consuming). I've tried other solutions found in about 12 different Stackoverflow discussions. I keep running into the same exact issue. If there's a workaround for this, I'll keep trying but otherwise I'm throwing in the proverbial towel... This is what happens when I try to run npx create-ignition-theme, which I have to cancel out of because it just keeps looping. any help would be greatly appreciated:

npx: installed 10 in 2.725s
Downloading Ignition Starter Theme into theme-name
Ignition Theme Downloaded from git.
Running npm install...
npm WARN package.json [email protected] No repository field.
npm WARN peerDependencies The peer dependency node-sass@^4.0.0 included from sass-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency fibers@>= 3.1.0 included from sass-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

[email protected] install /Users/pete/WebServer/leafnation-litespeed/sites/leafnation.com/html/front-end/themes/theme-name/node_modules/sass/node_modules/chokidar/node_modules/fsevents
node-gyp rebuild

gyp: binding.gyp not found (cwd: /Users/pete/WebServer/leafnation-litespeed/sites/leafnation.com/html/front-end/themes/theme-name/node_modules/sass/node_modules/chokidar/node_modules/fsevents) while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/usr/local/lib/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack at ChildProcess.emit (events.js:311:20)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.6.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/pete/WebServer/leafnation-litespeed/sites/leafnation.com/html/front-end/themes/theme-name/node_modules/sass/node_modules/chokidar/node_modules/fsevents
gyp ERR! node -v v12.16.1
gyp ERR! node-gyp -v v7.1.2
gyp ERR! not ok`

Source map not being output correctly

CSS sourcemaps aren't being output correctly. Chrome only reports main.css from the css sourcemap (ommiting all the .scss files) and no JS sourcemap. I'm not sure if this is a Ignition-specific issue or something to do with WP-Gulp.