schneefux/node-taglib3

taglib binding for Node 12

node-taglib3's Issues

taglib version

You are using taglib master while branch taglib2 is the one you should be using.
In CMakeLists.txt you should put
set(REVISION "65a6a4e225fff1288148de92721418e1c634713b")
instead of
set(REVISION "v1.11.1")

Branch taglib 2 is more advanced with more features. For example it supports pictures tag for obtaining album art that is often part of the song file..

samplerate and pictures tag missing

It would be very useful if you could add samplerate audio property in ReadAudioProperties method.
You just need to add one line:

map.insert(TagLib::String("samplerate"), TagLib::String(std::to_string(f.audioProperties()->sampleRate())));

pictures tag will also help a lot but this one is not so simple. Here is the code snippet from node-taglib2:

   size_t arraySize = tag->pictures().size();
    v8::Local<v8::Array> pictures = Nan::New<v8::Array>(arraySize);
    int picIndex = 0;

    for (auto& p : tag->pictures()) {

        v8::Local<v8::Object> imgObj = Nan::New<v8::Object>();

        auto data = p.second[0].data();
        auto datasize = data.size();
        const char* rawdata = data.data();

        v8::Local<v8::Object> buf = Nan::NewBuffer(datasize).ToLocalChecked();
        memcpy(node::Buffer::Data(buf), rawdata, datasize);

        imgObj->Set(
            Nan::New("mimetype").ToLocalChecked(),
            TagLibStringToString(p.second[0].mime()));

        imgObj->Set(
            Nan::New("picture").ToLocalChecked(),
            buf);

        pictures->Set(picIndex++, imgObj);
    }

    obj->Set(Nan::New("pictures").ToLocalChecked(), pictures);

where tag is TagLib::FileRef ('f' in your code) and obj is declared with:
v8::Local<v8::Object> obj = Nan::New<v8::Object>();
same as the return type of your method: MapToObject

I hope these are reasonable suggestions and you have enough to implement them without serious problems.