"DSSE Multi-signature Verification" protocol lacks detail about threshold verification

[secure-systems-lab]

"DSSE Multi-signature Verification" protocol lacks detail about threshold verification

[MarkLodato]

The specification says (emphasis added):

Add the accepted public key to the set ACCEPTED_KEYS.

"Set" implies no duplicates, but I understand how that is easily overlooked. What about adding "ignoring duplicates" to the cardinality lines?

Or am I misunderstanding your point?

[lukpueh]

Thanks for the quick reply, @MarkLodato. You do understand my point, and I indeed missed that ACCEPTED_KEYS is defined as set, probably coming from a code review where this was implemented as list.

Adding "ignoring duplicates" might confuse someone who does understand that a set can't have duplicates in the first place.

What about a (warning) sentence after the pseudo-code that underlines how the passed keys need to be distinct, and each key can only be used once? Or does that clutter the protocol? I do generally appreciate the conciseness of the spec. So I am also fine with leaving it as is. Feel free to close this issue without further action!

[MarkLodato]

Sent out #52 as a possible suggestion to replace "cardinality of" with "unique keys in". I suspect that will avoid any ambiguity?