Giter Site home page Giter Site logo

Comments (4)

MarkLodato avatar MarkLodato commented on July 19, 2024

Sounds good to me. Why is it a breaking change?

from dsse.

kommendorkapten avatar kommendorkapten commented on July 19, 2024

Hm I think I hear what you are saying, you would like for the protobuf generated code to be put in the same package as the dsse code is today? Then yes, it would not be a breaking change!

from dsse.

MarkLodato avatar MarkLodato commented on July 19, 2024

Ah, I think there is some confusion about versions. There is the version of the spec itself, and the version of any libraries that implement the spec.

The spec itself is unaffected by this change. The protobuf describes the existing design.

Libraries that switch to protobuf-generated code from a custom interface might need to change.

from dsse.

kommendorkapten avatar kommendorkapten commented on July 19, 2024

Ah, I think there is some confusion about versions. There is the version of the spec itself, and the version of any libraries that implement the spec.

Correct, but if the build job that generates the code always pulls the protobuf from this repository we can manage that, by being explicit by the version we use.

Libraries that switch to protobuf-generated code from a custom interface might need to change.

I think this can actually be avoided. So if we instead update the go-securesystemslib package, to generate the code on build, and publish that code into the go-securesystemslib package, we won't get a breaking change, as the generated code will end up in the same package as the definitions is today.

This is not something I have done before (generate structs into an existing package), so I can't determine if it's a hack, or if it's a good solution :)

from dsse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.