seebk/gimp-lensfun

GIMP plugin for correcting lens distortion using the lensfun library and database

gimp-lensfun's Issues

Doesn't compile after changes in Exiv2

On Archlinux, with Exiv2 0.28.0, it will not compile:

src/gimplensfun.cpp: In function ‘int read_opts_from_exif(const char*)’:
src/gimplensfun.cpp:1037:19: error: ‘AutoPtr’ is not a member of ‘Exiv2::Image’
 1037 |     Exiv2::Image::AutoPtr Exiv2image;

0.24 compilation failure - lfDatabase() is protected

Hello

Compilation of 0.24 fails with:
In file included from src/gimplensfun.cpp:30:0: /usr/include/lensfun/lensfun.h:1603:5: error: ‘lfDatabase::lfDatabase()’ is protected

Full log here:
https://dpaste.de/RpJ6

GCC-4.9.3, GIMP-master.

Lensfun won't install properly on Gimp 2.8 with Windows 10

I'm using Gimp 2.8 with Windows 10. I could REALLY use lensfun, but it doesn't install properly. Every time I open Gimp I get a popup dialogue box saying that it couldn't load, and I have to click ok for Gimp to finish opening. Then it's not available in any of the menu selections. I've copied the error message below. I very much hope someone can fix this - or at least tell me what files lensfun loads and where each ought to be on my computer so I can check each and move them where they belong so lensfun will work.

Is there an updated Gimp-lensfun for Gimp 2.10.9 or newer versions, if so where is it?

Hi seebk,

Thank you for providing the "gimp-lensfun" plugin.

Is there an updated Gimp-lensfun for Gimp 2.10.9 or newer versions, if so where is it? If I try to use the gimp-lensfun plugin from 04-27-2018 that I found with any version of Gimp 2.10.9 beyond November of 2018, it will not work and I get a message stating that the lensfun plugin is outdated.

Is there any way to use the lensfun packages that are available in Linux repositories or by compiling and installing lensfun in Gimp v2.10.9 or newer versions? Perhaps you have a script or wrapper or something else that could compile or allow Gimp 2.10.9 and newer users to use the installed lensfun packages instead of or as the "gimp-lensfun" plugin?

FYI: My post to Gimp developers
Request or bugfix - Gimp v2.10 please use lensfun packages already available rather than gimp-lensfun (#2876) · Issues · GNOME / GIMP · GitLab
https://gitlab.gnome.org/GNOME/gimp/issues/2876#note_421444

Best regards,
Phil (phd21)

Lensfun not installing - windows 7 Gimp 2.8

I know that lensfun isn't supporting Windows. I just want the issue documented.

When I tried to install with the various installers (I tried the newest first) none of them would work.
The newest installer caused the error and none of the others seemed to install something that helped to fix it. So, the error is from the newest installer.

When Gimp Startup opens an error comes up
gimp-lensfun.exe - Application Error. The application was unable to start correctly (0xc000007b). Click OK to close the application.

used installer now gimp gives me error code on opening

gimp says "unable to open application blah blah error code blah blah" Please advise... I can't even find the program files to delete them

Loading error

Hi, I installed the latest release as described and got the following error:

I'm using GIMP 2.8.18, Windows 10 Home (x64).

Use higher bit depths in GIMP 2.10

GIMP 2.10 supports higher bit depths, but GIMP Lensfun still uses 8bit per pixel all the time.

Wrong correction

Using lensfun with pictures from Canon Powershot S95 to correct the distorsion - the result is worse then the original, the correction is far to much.

Wenn man mit Lensfun versucht die Tonnenverzeichnung in Bildern einer Canon Powershot S95 zu korrigieren, ist das Ergebnis schlimmer als das Original. Die Korrektur ist viel zu heftig. Aus konkaven Linien werden konvexe.
Probiert mit dem aktuellsten Gimp-PlugIn unter Lubuntu 17.04.
Wenn ich die Informationen aus der Data-Datei für lensfun richtig interpretiere, werden auch Parameter von PTLens verwendet - kann das sein? Mit PTLens klappt die Korrektur.

segfault when correcting gopro lens

Problem with Gopro© lens correction:
No problem building, or copying to right gimp folder.
but when i open the window, and choose the gopro maker, there's no camera, or lens.
But there's a focal length and aperture, so i click OK. then i can see on the command line that gimp-lensfun has segfaulted.

i'm on debian wheezy, gnome3. all versions standard wheezy versions.
i'll try and start gdb to explore a little.

at commit a898ecd:
make:
g++ -DDEBUG=0 -O3 -Wall -fopenmp -pthread -I/usr/include/gtk-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/gimp-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/ -c -o src/gimplensfun.o src/gimplensfun.cpp
src/gimplensfun.cpp: In function ‘void query()’:
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar* {aka char_}’ [-Wwrite-strings]
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char_}’ [-Wwrite-strings]
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char_}’ [-Wwrite-strings]
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char_}’ [-Wwrite-strings]
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char_}’ [-Wwrite-strings]
src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char*}’ [-Wwrite-strings]
g++ -o gimp-lensfun src/gimplensfun.o -lgimpui-2.0 -lgimpwidgets-2.0 -lgimpmodule-2.0 -lgimp-2.0 -lgimpmath-2.0 -lgimpconfig-2.0 -lgimpcolor-2.0 -lgimpbase-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lglib-2.0 -L/usr/lib/ -llensfun -lglib-2.0 -lexiv2 -lstdc++ -fopenmp

GoPro support

I do not see GoPro on the list of camera producers. We need GoPro!

http://askubuntu.com/questions/797966/gopro-fisheye-lens-correction-free-software

Cannot compile - GCC-4.8.2 and Gimp-git

Hi

I don't know whether the problem is that I'm using Gimp from git (self-compiled), or GCC-4.8.2 is not supported, or whether your code is faulty.
I tried 0.2.2 and 0.2.3, both fail with the same reason.
Please help out.

ccache version 3.1.9 [disabled]
app-shells/bash: 4.2_p45
dev-java/java-config: 2.2.0
dev-lang/python: 2.7.5-r3, 3.3.3
dev-util/ccache: 3.1.9-r3
dev-util/cmake: 2.8.11.2
dev-util/pkgconfig: 0.28
sys-apps/baselayout: 2.2
sys-apps/openrc: 0.12.4::pentoo
sys-apps/sandbox: 2.6-r1
sys-devel/autoconf: 2.13, 2.69
sys-devel/automake: 1.10.3, 1.11.6, 1.12.6, 1.13.4
sys-devel/binutils: 2.23.2
sys-devel/gcc: 4.8.2
sys-devel/gcc-config: 1.7.3
sys-devel/libtool: 2.4.2
sys-devel/make: 3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc: 2.17

CFLAGS="-march=native -O2 -pipe"

Build log:
http://filebin.net/d70po5nmu8/build.log

Wrong lens detected for Fujifilm X-E2

For a picture shot with a Fujifilm X-E2 the GIMP-Lensfun dialog shows the wrong lens. Especially instead of the XF 18-55mm f/2.8-4 R LM OIS the XC 16-50mm f/3.5-5.6 OIS is shown.

It seems that the code doesn't read the lens model from Exif data for Fujifilm cameras (and others without special maker handling) and selects the first lens it finds instead.

As the X-E2 stores lens model in "Exif.Photo.LensModel" and this is a Exif 2.3 standard tag for the lens model, I created a patch to use this tag for all makers without a special handling. The attached default_lens_patch.zip contains the patch and a little image file with necessary Exif data to test the patch for Fujifilm X-E2 and XF 18-55mm f/2.8-4 R LM OIS.

gimplensfun.cpp:757: bad if test ?

[src/gimplensfun.cpp:757]: (warning) Logical conjunction always evaluates to false: x >= 2 && x <= -2.

if ( (x >= cLanczosWidth) && (x <= (-1)*cLanczosWidth) )

Maybe

if ( (x >= cLanczosWidth) || (x <= (-1)*cLanczosWidth) )

Shipping AppStream metadata file

I'd like to ask you if you could ship a small xml file that contains AppStream metadata. It's a distro-agnostic format for AppStore-like catalogs for Linux distributions: http://www.freedesktop.org/software/appstream/docs/sect-Quickstart-Addons.html AppStream-based catalogs are currently included in all major Linux distributions: Fedora, Ubuntu, Debian, Arch,... If the xml file is copied to %{datadir}/appdata/ (typically /usr/share/appdata) the plugin appears in the profile of the app (GIMP) and is easily discoverable and installable for users. I've created the file for you. See the attachment.
gimp-lensfun.metainfo.xml.zip

Plugin doesn't work on GIMP 2.10

When I install the plugin into GIMP 2.10, GIMP can't open. It says that the application didn't open correctly.

Plugin aborts when used on unsaved file

Steps to reproduce:

1. Open gimp
2. File/New..., select the defaults
3. Filters/Enhance/GimpLensFun...
4. Dialog pops up saying that "plugin gimplensfun crashed"

There is output in the terminal:
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_S_construct null not valid

I noticed that if I just use a generic catch (...) in the try/catch block in read_opts_from_exif, it will catch the exception and avoid the abort.

gimp startap error

gimp 2.8.22 on windows 10.0.16299.125 x64