sevenwestmedia-labs/nx-plugins

Plugins for nx.dev

nx-plugins's Issues

Allow CLI flags thru the cmd

Problem

I need to add --flags and args to my process, but no such provision exists.

Discussion

nx-plugins/libs/nx-esbuild/src/executors/serve/executor.ts

Line 89 in 980cdc1

],

Can we add ...(options.args || []) to the final bit? Or however we get args thru with nodemon. For instance, my node build via esbuild needs --port=xyz and --hostname=xyz etc. Some i can pass thru the env, but not all

Why not add @wanews/nx-pulumi:preview

The best feature I like about this project is the stack auto discovery.
Why not add @wanews/nx-pulumi:preview, so I can just run
nx affected --target=preview --env=prod --all
to see all preview of my stacks.
Thanks!

vite for vue (with library support) for nx 13+

Hello there, I stumbled upon this repo after failing to get https://github.com/ZachJW34/nx-plus running (doesn't support nx 13 and seems to be using custom webpack to build the apps / libs, instead of utilising vite / vue cli to the fullest), are there any plans to support generating and building publishable Vue libraries?

nx serve app throws error: Cannot find module 'execa'

Hi!

I tried creating a new project with this plugin and I came accross this error.
Steps:

• Create an empty nx workspace
• Install @wanews/x-vite
• Generate an app with the plugin
• Serve the app

Tried with nx latest. Then I noticed you main branch nx version was 12.3.6 so I tried with that as well.

Looking forward for this plugin so we can get faster builds 🎉

➜  projects npx [email protected] testingrepo
npx: installed 48 in 5.752s
✔ What to create in the new workspace · empty
✔ Use Nx Cloud? (It's free and doesn't require registration.) · No

>  NX  Nx is creating your workspace.

  To make sure the command works reliably in all environments, and that the preset is applied correctly,
  Nx will run "npm install" several times. Please wait.

✔ Installing dependencies with npm
✔ Nx has successfully created the workspace.

———————————————————————————————————————————————


>  NX   NOTE  Nx CLI is not installed globally.

  This means that you might have to use "yarn nx" or "npx nx" to execute commands in the workspace.
  Run "yarn global add nx" or "npm install -g nx" to be able to execute command directly.

➜  projects cd testingrepo
➜  testingrepo git:(master) npm i -D @wanews/nx-vite

npm WARN @wanews/[email protected] requires a peer of @vitejs/plugin-react-refresh@>1.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @wanews/[email protected] requires a peer of nodemon@>2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @wanews/[email protected] requires a peer of react@>17.0.2 but none is installed. You must install peer dependencies yourself.
npm WARN @wanews/[email protected] requires a peer of react-dom@>17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @wanews/[email protected] requires a peer of vite@>2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @wanews/[email protected] requires a peer of vite-tsconfig-paths@>3.0.0 but none is installed. You must install peer dependencies yourself.

+ @wanews/[email protected]
added 1 package from 1 contributor and audited 210 packages in 1.24s

37 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

➜  testingrepo git:(master) ✗ npx nx generate @wanews/nx-vite:react website
UPDATE workspace.json
UPDATE nx.json
CREATE apps/website/.babelrc
CREATE apps/website/.eslintrc.json
CREATE apps/website/README.md
CREATE apps/website/index.html
CREATE apps/website/jest.config.js
CREATE apps/website/package.json
CREATE apps/website/src/App.tsx
CREATE apps/website/src/main.tsx
CREATE apps/website/tsconfig.json
➜  testingrepo git:(master) ✗ npx nx run website:serve

> nx run website:serve
Cannot find module 'execa'
Require stack:
- /home/apolo/projects/testingrepo/node_modules/@wanews/nx-vite/src/executors/serve/executor.js
- /home/apolo/projects/testingrepo/node_modules/@nrwl/tao/src/shared/workspace.js
- /home/apolo/projects/testingrepo/node_modules/@nrwl/tao/src/commands/run.js
- /home/apolo/projects/testingrepo/node_modules/@nrwl/tao/index.js
- /home/apolo/projects/testingrepo/node_modules/@nrwl/cli/lib/run-cli.js

———————————————————————————————————————————————

>  NX   ERROR  Running target "website:serve" failed

  Failed tasks:

  - website:serve

Node + NPM version

➜  testingrepo git:(master) ✗ node -v
v14.17.3
➜  testingrepo git:(master) ✗ npm -v
6.14.13

Execute nx-esbuild:build with esbuild-sass-plugin

Hello, everyone,

I would like to use a esbuild plugin with a transform option.

But I can't pass any functions via the project.json.

How could be integrated? Maybe similar the plugins array itself?

  "options": {
    "plugins": [{
        "package": "esbuild-sass-plugin",
        "args": {
          "type" : "style",
          "transform": "postcssModules"
        }
      }]
  },

nx-pulumi: nx generate @wanews/nx-pulumi:create-stack --dry-run is not a dry run

Running npx nx generate @wanews/nx-pulumi:create-stack --environment=<env name> --projectName=<nx project name> --no-interactive --dry-run will run the actual command instead of dry-run. The CLI dry-run argument is ignored.

Troublesome especially with vscode Nx console plugin since that automatically runs the dry-run when filling in the environment name.

[nx-pulumi] - nx-pulumi:restore-config command now restores file contents as an object

Hello,

Thanks once again for maintaining this plugin! Using the latest version trying to restore my config, i get only [object Object] in my newly created yaml file.

I believe it is related to the below when the s3 dependency was swapped over:
aws/aws-sdk-js-v3#1877

Not sure if this affects anything else in the repo.

Cheers!

TS 4.9 compatibility

@wanews/nx-typescript-project-references depends on tsup "^5.12.9" which depends on an esbuild version that's incompatible with TypeScript 4.9.

This can be "fixed" by adding "resolutions": { "tsup": "6.6.0" } to package.json, but it'd be nice to upgrade the dependency.

Should note that latest esbuild breaks @wanews/nx-esbuild (personally migrating to official plugins for that)

devkit_1.writeJson is not a function

Hi,

I really like what you are up to here, and it can potentially solve all my pain points with NX. So really excited to play around with it.

When trying to run the migrate command on our current NX codebase, I am receiving the following error:

devkit_1.writeJson is not a function

Is this due to my NX version?

Package "@wanews/nx-vite" was found but does not support schematics.

While running
npx nx generate @wanews/nx-vite:react test

getting issue - Package "@wanews/nx-vite" was found but does not support schematics.

Any @pointer?? @JakeGinnivan

wrong tsconfig.json and fail when run serve

Hi,

I'm new in using NX, so maybe i miss some steps here.

Basically i finally able to use your nx-vite plugin and finally created the folder into my workspace successfully. However, i have troubles in few areas :

1. tsconfig.json

In noticed in your repo that there's tsconfig.setting.json whereas in my newly created nx workspace there's only tsconfig.base.json so i need to change it manually.

i used --preset=empty for creating the workspace.

the changes i need to make to tsconfig.json is :

from

{
  "extends": "../../tsconfig.settings.json",
  "compilerOptions": {
    "outDir": "./out-tsc",
    "rootDir": "./src",
    "types": ["jest", "node"]
  },
  "include": ["src/**/*.ts", "src/**/*.tsx"]
}

to

{
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
    "outDir": "./dist",
    "jsx": "react-jsx",
    "types": ["jest", "node"]
  },
  "include": ["src"]
}

2. nx run <my app>:serve

when i run serve, i got an error.

Command failed with exit code 243: npx vite <my app path>--open
Error: Command failed with exit code 243: npx vite <my app path> --open
    at makeError (/<my app path>/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/<my app path>node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

can you show me where did i go wrong or is it actually a bug ?

esbuild fails to start with no package.json in an app

It looks like the readJson function throws if the package.json is not in an app. The docs seem to indicate that this should not be a fatal case, and it should instead just fallback to the root package.json.

nx-pulumi peer dependency on aws-sdk

Hello and thank you for your work.

We have noticed that the nx-pulumi plugin depends on aws-sdk. It is pulling unnecessary libraries for us since we are using azure.
Is it possible to remove that peer dependency.

Thank you.

[nx-esbuild] nx 13.10.0+ tree path changed

With @wanews/[email protected] + [email protected], following error occurs:

Cannot find module 'nx/src/shared/tree'
Require stack:
- node_modules/@wanews/nx-esbuild/src/executors/build/executor.js
- node_modules/nx/src/config/workspaces.js
- node_modules/nx/src/command-line/run.js
- node_modules/nx/bin/run-executor.js

nx-plugins/libs/nx-esbuild/src/executors/build/executor.ts

Line 3 in 5c9d8bb

import { FsTree } from 'nx/src/shared/tree'

Looks like path to tree has been refactored from packages/nx/src/shared/tree.ts to packages/nx/src/config/tree.ts

Related PR:
cleanup(core): create more meaningful file structure in nx package #9621
https://github.com/nrwl/nx/pull/9621/files#diff-ecb44f754a1e1420adb824a5bbd14c752c5c3ce076b49e17ed51450ff8c7b3e4

nx-pulumi:init-standalone is missing up target

Hi there, I'm new to nx so I could be misreading the project. I'm looking at the generators for init and init-standalone and found the standalone does not contain an up target

I'm starting with an empty workspace (choosing ts during create-nx-workspace) and attempting to deploy an API gateway as described in this tutorial: https://www.pulumi.com/registry/packages/aws/how-to-guides/rest-api/

Makes possible to thread the config of the vite build via the plugin Options

I'm open to do a PR if it would be accepted

Package naming

We have @wanews/typescript-project-references and @wanews/nx-esbuild

@wanews/typescript-project-references

Has the generator which converts an NX project, and a package executor which will package a library for NPM publish (using tsup atm).

@wanews/nx-esbuild

Has a generator to create a node project, and executors to build (for prod) and serve (for local dev) that node project.

Next up

• Generator to create a library
• Generator to create a Pulumi project for another project - this will allow serverless mono to have an infrastructure project for each of it's apps. ie corporate-subs-dash and corporate-subs-dash-deploy/corporate-subs-dash-infrastructure
• A Vite project generator
• Others?

What should the projects be named? For a minimum the typescript one should probably be prefixed with nx-

project_graph_1.createProjectGraphAsync is not a function

I hoped your tool could help to enable support for project references in nx. I tried it. It emits the following error:

❯ npx nx generate @wanews/nx-typescript-project-references:migrate
project_graph_1.createProjectGraphAsync is not a function

nx-vite | npx nx generate @wanews/nx-vite:react downstream-vite fails

Unable to resolve @wanews/nx-vite:react. Cannot find module '@wanews/nx-vite/package.json'

❯ npx nx generate @wanews/nx-vite:react downstream-vite
Unable to resolve @wanews/nx-vite:react.
Cannot find module '@wanews/nx-vite/package.json'

nx-vite:serve is not working with npm

A freshly created project with nx-vite:react is not working with nx serve command.. following error is coming from npm package manager which i still have from the default workspace settings. Do i need to use a different package manager?