simonihmig/ember-ecsy-babylon

WORK IN PROGRESS

ember-ecsy-babylon's Issues

Make rendered `<canvas>` use `tabindex="0"`

It has tabindex="1" by default, which is stupied IMHO, as it messes with tab order and is an a11y anti-pattern AFAIK. See https://forum.babylonjs.com/t/canvas-tabindex-1/8052.

I think we should set engine.canvasTabUndex = 0 by default (in onCanvasReady)!?

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update typescript-eslint monorepo to v5.33.1 (patch) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Update dependency @types/ember-qunit to v5
• Update dependency release-it to v15
• Update dependency release-it-lerna-changelog to v5
• Lock file maintenance
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update Node.js to v16
• Update actions/checkout action to v3
• Update actions/setup-node action to v3

Detected dependencies

github-actions

.github/workflows/ci.yml

• actions/checkout v2
• actions/setup-node v2
• actions/checkout v2
• actions/setup-node v2
• actions/checkout v2
• actions/setup-node v2

.github/workflows/docs.yml

• actions/checkout v3
• actions/setup-node v3
• bahmutov/npm-install v1
• peaceiris/actions-gh-pages v3

npm

package.json

• @ember/render-modifiers ^2.0.0
• @ember/test-waiters ^3.0.0
• @glimmer/env ^0.1.7
• @glimmer/tracking ^1.0.4
• ecsy ^0.4.2
• ember-auto-import ^2.4.1
• ember-cli-babel ^7.26.11
• ember-cli-htmlbars ^6.0.1
• ember-cli-typescript ^5.0.0
• ember-concurrency ^2.1.0
• ember-concurrency-async ^1.0.0
• ember-concurrency-ts ^0.3.1
• ember-destroyable-polyfill ^2.0.3
• ember-named-blocks-polyfill ^0.2.4
• ember-on-resize-modifier ^1.0.0
• ember-resources ^5.0.2
• @babylonjs/core 5.19.0
• @babylonjs/gui 5.19.0
• @babylonjs/gui-editor 5.19.0
• @babylonjs/inspector 5.19.0
• @babylonjs/loaders 5.19.0
• @babylonjs/materials 5.19.0
• @babylonjs/serializers 5.19.0
• @ember/optional-features 2.0.0
• @ember/test-helpers 2.8.1
• @embroider/test-setup 1.8.3
• @glimmer/component 1.1.2
• @glimmer/tracking 1.1.2
• @types/ember 4.0.1
• @types/ember-qunit 3.4.15
• @types/ember-resolver 5.0.11
• @types/ember__test-helpers 2.8.0
• @types/qunit 2.19.2
• @types/rsvp 4.0.4
• @typescript-eslint/eslint-plugin 5.33.0
• @typescript-eslint/parser 5.33.0
• broccoli-asset-rev 3.0.0
• ember-cli 4.6.0
• ember-cli-dependency-checker 3.3.1
• ember-cli-inject-live-reload 2.1.0
• ember-cli-sri 2.1.1
• ember-cli-terser 4.0.2
• ember-cli-typescript-blueprints 3.0.0
• ecsy-babylon 0.8.0
• ember-disable-prototype-extensions 1.1.3
• ember-export-application-global 2.0.1
• ember-load-initializers 2.1.2
• ember-page-title 7.0.0
• ember-qunit 5.1.5
• ember-resolver 8.0.3
• ember-source 4.6.0
• ember-source-channel-url 3.0.0
• ember-template-lint 4.12.0
• ember-truth-helpers 3.1.1
• ember-try 2.0.0
• eslint 8.22.0
• eslint-config-prettier 8.5.0
• eslint-plugin-ember 11.0.5
• eslint-plugin-node 11.1.0
• eslint-plugin-prettier 4.2.1
• eslint-plugin-qunit 7.3.1
• loader.js 4.7.0
• npm-run-all 4.1.5
• prettier 2.7.1
• qunit 2.19.1
• qunit-dom 2.0.0
• release-it 14.14.3
• release-it-lerna-changelog 4.0.1
• typescript 4.7.4
• webpack 5.74.0
• @babylonjs/core ^5.0.0
• @babylonjs/gui ^5.0.0
• @babylonjs/gui-editor ^5.0.0
• @babylonjs/inspector ^5.0.0
• @babylonjs/loaders ^5.0.0
• @babylonjs/materials ^5.0.0
• @babylonjs/serializers ^5.0.0
• ecsy-babylon ^0.8.0
• node 14.* || >= 16
• node 14.20.0
• yarn 1.22.19

---

• Check this box to trigger a request for Renovate to run again on this repository

Support LoadGltfs to load dynamic list of assets

The current API requires key-value pairs of assets to be passed as component arguments:

<World.LoadGltfs
  @bedmodel={{this.bedmodelFile}}
  @material={{this.materialFile}}
  @material_base={{this.baseMaterialFile}}
  as |ach|>

But what if the assets are dynamic, like a map/hash of assets we don't know beforehand. We have no splarguments syntax available...

<World.LoadGltfs
  ...this.assetMap
  as |ach|>

So need some other API, like:

<World.LoadGltfs
  @assets={{this.assetMap}}
  as |ach|>

If we have that API, the former one is a bit redundant, as you could also do:

<World.LoadGltfs
  @assets={{hash
    bedmodel=this.bedmodelFile
    material=this.materialFile
    material_base=this.baseMaterialFile
  }}
  as |ach|>

Provide support for custom WebXR buttons

Rendering the buttons using Ember, for better customizability. Should support detected supported sessionModes, and entering that mode on click. Maybe a helper for support detection, and a yielded action for entering the mode?

The detection helper could also be used to show a notice and a QR code to switch from desktop browser (not supporting WebXR) to mobile.