smarkets/smk_python_sdk

Smarkets Python SDK

smk_python_sdk's Issues

snap_to_decimal can return None

https://github.com/smarkets/smk_python_sdk/blob/master/smarkets/odds.py#L594

snap_to_decimal() snap_to_decimal_move_out_by()

These function can return None. This feels wrong especially for snap_to_decimal().

I think an exception would be neater.

Is this package still being maintained?

I'm following documentation and I'm getting an error trying to log in.

Is this package still being maintained?
Is there a plan to maintain it?

Error
smarkets.streaming_api.exceptions.ConnectionError: Error -2 connecting stream.smarkets.com:3801. Name or service not known.

import logging
logging.basicConfig(level=logging.DEBUG)

from smarkets.streaming_api.api import SessionSettings, Session, StreamingAPIClient

username = '[email protected]'
password = 'barpassword'

settings = SessionSettings(username, password)
settings.host = 'stream.smarkets.com'
session = Session(settings)

client = StreamingAPIClient(session)
client.login()

Thanks

Can't instantiate more than one smarkets.clients.Smarkets

If you have more than one client, their Callback objects are the same.

>>> import smarkets.clients
>>> a = smarkets.clients.Smarkets('_')
>>> b = smarkets.clients.Smarkets('_')
>>> def h(msg): print repr(("client a received", msg))
... 
>>> a.add_handler('seto.http_found', h)

# pretend b is connected and got a message...
>>> b.callbacks['seto.http_found']('example_message')
('client a received', 'example_message')

Snippet under "Getting Started" doesn't work

Snippet in https://github.com/smarkets/smk_python_sdk#getting-started is outdated.

Looks like:

• settings.host and/or settings.port was changed
• order.market is obsolete, one should use order.market_id instead, the same for order.contract
• order.time_in_force was renamed to order.tif
• BUY was renamed to SIDE_BUY

Expected behaviour:

After copy pasting it to Python REPL (with correct credentials, market_id and contract_id) it should login and place a bet.

Can't resolve "stream.smarkets.com"

Hi, I try to run the intro script and can't resolve host "stream.smarkets.com"
I also cant resolve it using google DNS server. On older "api.smarkets.com" I get timeout error.

>>> client.login()
INFO:smarkets.session.socket:connecting with new socket to stream.smarkets.com:3801
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/anaconda2/lib/python2.7/site-packages/smarkets/streaming_api/client.py", line 54, in login
    self.session.connect()
  File "/opt/anaconda2/lib/python2.7/site-packages/smarkets/streaming_api/session.py", line 90, in connect
    if self.socket.connect():
  File "/opt/anaconda2/lib/python2.7/site-packages/smarkets/streaming_api/session.py", line 253, in connect
    reraise(ConnectionError(self._error_message(exc)))
  File "/opt/anaconda2/lib/python2.7/site-packages/smarkets/errors.py", line 13, in reraise
    _six.reraise(type(exception), exception, tb)
  File "/opt/anaconda2/lib/python2.7/site-packages/smarkets/streaming_api/session.py", line 249, in connect
    sock.connect((self.settings.host, self.settings.port))
  File "/opt/anaconda2/lib/python2.7/ssl.py", line 876, in connect
    self._real_connect(addr, False)
  File "/opt/anaconda2/lib/python2.7/ssl.py", line 863, in _real_connect
    socket.connect(self, addr)
  File "/opt/anaconda2/lib/python2.7/socket.py", line 228, in meth
    return getattr(self._sock,name)(*args)
smarkets.streaming_api.exceptions.ConnectionError: Error -2 connecting stream.smarkets.com:3801. Name or service not known.
>>> 

Small frames are being padded to 3 instead of 4 bytes

Frames of less than 4 bytes are supposed to be padded to 4 bytes. According to https://github.com/smarkets/smk_python_sdk/blob/master/smarkets/sessions.py#L266 it seems though as if they are padded to 3 bytes. IMO this should read padding = '\x00' * max(0, 4 - byte_count).