smbolton/whysynth

Versatile multi-mode DSSI softsynth.

whysynth's Issues

Make Qtractor/Rosegarden sessions with whysynth portable

Hi Sean,

I am using whysynth for a while but once created a little dirty patch. I work on the same Rosegarden- and Qtractor sessions in different computers. That means only the directories with the DAW's session file, midi files and audio files are in sync.

So writing anything to a temp dir makes trouble.

That was the reason I created a quick-n-dirty patch (attached).

What do you think? Did I get things horribly wrong? Do you think it's a good idea to disable writing to a temp dir?

tempdirpatch.txt

Regards
Holger

Undefined symbol

So I’m getting the following error and I’m thinking I’m missing a library or something. Not sure how to best troubleshoot or move ahead?

ghostess: dlopen of '/usr/lib/dssi/whysynth.so' failed: /usr/lib/dssi/whysynth.so: undefined symbol: dssp_voicelist_mutex_unlock

Please create an AppData file for WhySynth

Please consider writing and installing an AppData file with the application description and some screenshots, else WhySynth looks really bad in the GNOME and KDE Software Centers. We'd love to showcase more applications, but without the extra data file we can't. See http://people.freedesktop.org/~hughsient/appdata/ for details; thanks!

Richard

Two off by one errors ?

[common_data.c:473]: (error) Width 180 given in format string (no. 1) is larger than destination buffer 'buf2[180]', use %179s to prevent overflowing it.

Source code is

} else if (sscanf(buf, " comment %180s", buf2) == 1) {

[gui_data.c:700]: (error) Width 90 given in format string (no. 1) is larger than destination buffer 'buf2[90]', use %89s to prevent overflowing it.

if (sscanf(buf, " name %90s", buf2) == 1) {

An improper locking bug(e.g., deadlock) on the lock global_mutex

Hi, developers, thank you for your checking. It seems the lock global_mutex is not released correctly when !global.grain_envelope== 1 and !sampleset_init()==1 in the function y_instantiate?

whysynth/src/dssp_synth.c

Lines 110 to 141 in 32e4bc7

	pthread_mutex_lock(&global_mutex);
	if (global.initialized) {
	if (sample_rate != global.sample_rate) {
	/* all instances must share same sample rate */
	pthread_mutex_unlock(&global_mutex);
	free(synth);
	return NULL;
	}
	global.instance_count++;
	} else {
	global.sample_rate = sample_rate;
	global.grain_envelope = create_grain_envelopes(sample_rate);
	if (!global.grain_envelope) {
	YDB_MESSAGE(-1, " y_instantiate: out of memory!\n");
	free(synth);
	return NULL;
	}
	if (!sampleset_init()) {
	YDB_MESSAGE(-1, " y_instantiate: sampleset_setup() failed!\n");
	free(synth);
	return NULL;
	}
	global.instance_count = 1;
	global.initialized = 1;
	}
	pthread_mutex_unlock(&global_mutex);

Best,

viewing exact value on knobs

It's annoying that we can't see the exact value corresponding to the position of a knob.

It's especially annoying for the FM engines where freq ratio precision matters a lot.

(I'm trying to investigate how to fix that, any suggestion/guidance is welcome).

Discontinuities in PD mode

I wonder whether there are discontinuities in the Res 1 and 3 modes at the modulo phase reset.

Shouldn't the reset happen to the same position whether the waveform is muted to?

At least according to Wikipedia there shouldn't be discontinuities http://en.wikipedia.org/wiki/Phase_distortion_synthesis