snapwich/fun-hooks

A generalized and simple hooking API for adding extensibility to applications

fun-hooks's Issues

Stop relying on unsafe `new Function()`

https://github.com/snapwich/fun-hooks/blob/master/index.js#L336

As mentioned here this line prevents safer CSP policies on prebid. Would it be possible to find a different solution?

Library cannot use bind on the website with mootools

There is a website, which has mootools library loaded on the page.
When using Prebid 2.0 (with fun-hooks) - getting an error when the bind function is used.
The problem is that mootools re-defining the Function.prototype.bind.
See screenshot for some details.
Example (sample page) to be created.
What would you suggest for a fix? There is no access to change the website content (remove mootools).

name parameter unknown by typescript

Hi,
Thanks for sharing your work, that's a very usefull library !
I've just noticed that typescript doesn't know that one can pass a third parameter for specifying a name :

Repro right here, based on your doc's example :

import hookFactory from "fun-hooks";
let hook = hookFactory();

function getPrice(item: string) {
  return `foo: ${item}`;
}

hook("sync", getPrice, "price");

export const getHook = hook.get;

rises following ts error: Expected 1-2 arguments, but got 3.ts(2554)

Thanks for your help.
Mathias.

"sync:methodName" "async:methodName" for object functionality doesn't work

hook(obj, method, name) works (albeit with a typescript error) only when used without the async or sync prefix.